Issue 722625 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	dsinclair@chromium.org
Closed:	May 2017
Cc:	thestig@chromium.org glevin@chromium.org
Components:	Internals>Plugins>PDF
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-61

PDFExtensionTest.TouchHandling browser_tests failure on the Linux ChromiumOS Tests builder

Project Member Reported by afakhry@chromium.org, May 15 2017

Issue description

Link to most recent build failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/38592

Culprit CL is https://codereview.chromium.org/2861383003. Reverting shortly.

[ RUN      ] PDFExtensionTest.TouchHandling
[20033:20033:0515/161301.339283:WARNING:chrome_browser_main_chromeos.cc(492)] Running as stub user with profile dir: test-user
Xlib:  extension "RANDR" missing on display ":99".
[20033:20129:0515/161301.702595:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[20033:20207:0515/161301.960314:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[20033:20133:0515/161302.466612:ERROR:service_manager.cc(140)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser
[20033:20033:0515/161302.562106:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuSingleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[20033:20033:0515/161302.565404:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuDoubleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[20033:20033:0515/161311.708863:ERROR:tab_manager_delegate_chromeos.cc(90)] Set OOM score error:
[20033:20033:0515/161312.569059:INFO:CONSOLE(0)] "[SUCCESS] testLongPressSelectsText", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[20033:20033:0515/161312.571413:INFO:CONSOLE(0)] "[FAIL] testLongPressSelectsText: API Test Error in testLongPressSelectsText
Actual:
Expected: some
Error
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at Object.<anonymous> (extensions::test:215:18)
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at <anonymous>:192:21
    at safeFunctionApply (extensions::test:260:26)
    at PDFScriptingAPI.selectedTextCallback_ (extensions::test:285:18)
    at PDFScriptingAPI.<anonymous> (chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/pdf_scripting_api.js:95:16)", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[20033:20033:0515/161312.571575:INFO:CONSOLE(263)] "Uncaught chrome.test.failure", source: extensions::test (263)
../../chrome/browser/pdf/pdf_extension_test.cc:165: Failure
Failed
Failed 1 of 3 tests
[  FAILED  ] PDFExtensionTest.TouchHandling, where TypeParam =  and GetParam() =  (11529 ms)
[ RUN      ] PDFExtensionTest.TouchHandling
[16970:16970:0515/162034.173239:WARNING:chrome_browser_main_chromeos.cc(492)] Running as stub user with profile dir: test-user
Xlib:  extension "RANDR" missing on display ":99".
[16970:16991:0515/162034.476961:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[16970:17052:0515/162034.673926:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[16970:16995:0515/162035.060748:ERROR:service_manager.cc(140)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser
[16970:16970:0515/162035.118229:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuSingleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[16970:16970:0515/162035.120816:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuDoubleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[16970:16970:0515/162044.480870:ERROR:tab_manager_delegate_chromeos.cc(90)] Set OOM score error:
[16970:16970:0515/162045.123821:INFO:CONSOLE(0)] "[SUCCESS] testLongPressSelectsText", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[16970:16970:0515/162045.125559:INFO:CONSOLE(0)] "[FAIL] testLongPressSelectsText: API Test Error in testLongPressSelectsText
Actual:
Expected: some
Error
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at Object.<anonymous> (extensions::test:215:18)
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at <anonymous>:192:21
    at safeFunctionApply (extensions::test:260:26)
    at PDFScriptingAPI.selectedTextCallback_ (extensions::test:285:18)
    at PDFScriptingAPI.<anonymous> (chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/pdf_scripting_api.js:95:16)", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[16970:16970:0515/162045.125689:INFO:CONSOLE(263)] "Uncaught chrome.test.failure", source: extensions::test (263)
../../chrome/browser/pdf/pdf_extension_test.cc:165: Failure
Failed
Failed 1 of 3 tests
[  FAILED  ] PDFExtensionTest.TouchHandling, where TypeParam =  and GetParam() =  (11110 ms)
[ RUN      ] PDFExtensionTest.TouchHandling
[17176:17176:0515/162046.225821:WARNING:chrome_browser_main_chromeos.cc(492)] Running as stub user with profile dir: test-user
Xlib:  extension "RANDR" missing on display ":99".
[17176:17197:0515/162046.534571:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[17176:17238:0515/162046.716192:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[17176:17201:0515/162047.105403:ERROR:service_manager.cc(140)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser
[17176:17176:0515/162047.165083:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuSingleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17176:17176:0515/162047.167954:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuDoubleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17176:17176:0515/162056.539769:ERROR:tab_manager_delegate_chromeos.cc(90)] Set OOM score error:
[17176:17176:0515/162057.172306:INFO:CONSOLE(0)] "[SUCCESS] testLongPressSelectsText", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17176:17176:0515/162057.174521:INFO:CONSOLE(0)] "[FAIL] testLongPressSelectsText: API Test Error in testLongPressSelectsText
Actual:
Expected: some
Error
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at Object.<anonymous> (extensions::test:215:18)
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at <anonymous>:192:21
    at safeFunctionApply (extensions::test:260:26)
    at PDFScriptingAPI.selectedTextCallback_ (extensions::test:285:18)
    at PDFScriptingAPI.<anonymous> (chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/pdf_scripting_api.js:95:16)", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17176:17176:0515/162057.174812:INFO:CONSOLE(263)] "Uncaught chrome.test.failure", source: extensions::test (263)
../../chrome/browser/pdf/pdf_extension_test.cc:165: Failure
Failed
Failed 1 of 3 tests
[  FAILED  ] PDFExtensionTest.TouchHandling, where TypeParam =  and GetParam() =  (11109 ms)
[ RUN      ] PDFExtensionTest.TouchHandling
[17275:17275:0515/162057.513667:WARNING:chrome_browser_main_chromeos.cc(492)] Running as stub user with profile dir: test-user
Xlib:  extension "RANDR" missing on display ":99".
[17275:17297:0515/162057.821224:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[17275:17337:0515/162058.027446:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[17275:17301:0515/162058.446954:ERROR:service_manager.cc(140)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser
[17275:17275:0515/162058.499534:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuSingleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17275:17275:0515/162058.507330:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuDoubleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17275:17275:0515/162107.823870:ERROR:tab_manager_delegate_chromeos.cc(90)] Set OOM score error:
[17275:17275:0515/162108.510523:INFO:CONSOLE(0)] "[SUCCESS] testLongPressSelectsText", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17275:17275:0515/162108.512391:INFO:CONSOLE(0)] "[FAIL] testLongPressSelectsText: API Test Error in testLongPressSelectsText
Actual:
Expected: some
Error
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at Object.<anonymous> (extensions::test:215:18)
    at Object.handleRequest (extensions::binding:63:27)
    at Object.<anonymous> (extensions::binding:422:32)
    at <anonymous>:192:21
    at safeFunctionApply (extensions::test:260:26)
    at PDFScriptingAPI.selectedTextCallback_ (extensions::test:285:18)
    at PDFScriptingAPI.<anonymous> (chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/pdf_scripting_api.js:95:16)", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[17275:17275:0515/162108.512455:INFO:CONSOLE(263)] "Uncaught chrome.test.failure", source: extensions::test (263)
../../chrome/browser/pdf/pdf_extension_test.cc:165: Failure
Failed
Failed 1 of 3 tests
[  FAILED  ] PDFExtensionTest.TouchHandling, where TypeParam =  and GetParam() =  (11158 ms)

Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efe1452454a46b9926b8298e318f83042c11ff19

commit efe1452454a46b9926b8298e318f83042c11ff19
Author: afakhry <afakhry@chromium.org>
Date: Mon May 15 23:58:12 2017

Revert of Reland: Handle long press in PDF documents. (patchset #4 id:60001 of https://codereview.chromium.org/2861383003/ )

Reason for revert:
Causes failure in browser_tests on the Linux ChromiumOS Tests builder (PDFExtensionTest.TouchHandling).
BUG= 722625 

Original issue's description:
> Reland: Handle long press in PDF documents.
>
> This Cl updates the touch handlers for PDF documents to better support
> long press. The long press context menu is suppressed and the wonder
> under the press is of sufficient time.
>
> BUG= chromium:490184 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> PRIOR REVIEWS:
> > Review-Url: https://codereview.chromium.org/2855953003
> > Revert Review-Url: https://codereview.chromium.org/2864603006
>
> Review-Url: https://codereview.chromium.org/2861383003
> Cr-Commit-Position: refs/heads/master@{#471915}
> Committed: https://chromium.googlesource.com/chromium/src/+/c40173af073adb3b81cc4de1e8e8467b48b384df

TBR=thestig@chromium.org,mcnee@chromium.org,dsinclair@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:490184 

Review-Url: https://codereview.chromium.org/2886623002
Cr-Commit-Position: refs/heads/master@{#471951}

[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/chrome/browser/resources/pdf/gesture_detector.js
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/chrome/browser/resources/pdf/pdf.js
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/chrome/test/data/pdf/gesture_detector_test.js
[delete] https://crrev.com/8a4e4200086bc67a61c83d60edfb450844377e5a/chrome/test/data/pdf/touch_handling_test.js
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/out_of_process_instance.cc
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/out_of_process_instance.h
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/pdf_engine.h
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/pdfium/pdfium_engine.h
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/preview_mode_client.cc
[modify] https://crrev.com/efe1452454a46b9926b8298e318f83042c11ff19/pdf/preview_mode_client.h

Comment 2 by dsinclair@chromium.org, May 16 2017

Components: Internals>Plugins>PDF

Also Win10 still too.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin10_Tests_x64%2F11664%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests_on_Windows-10-10586%2F0%2Fstdout

And mac.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.12_Tests%2F537%2F%2B%2Frecipes%2Fsteps%2Fbrowser_side_navigation_browser_tests_on_Mac-10.12%2F0%2Fstdout


Seems to be something other then the originally though race condition.

Comment 3 by dsinclair@chromium.org, May 18 2017

Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

►

Issue 722625 link

Issue metadata

PDFExtensionTest.TouchHandling browser_tests failure on the Linux ChromiumOS Tests builder

Issue description

Comment 1 by bugdroid1@chromium.org, May 15 2017

Comment 1 Deleted

Comment 2 by dsinclair@chromium.org, May 16 2017

Comment 2 Deleted

Comment 3 by dsinclair@chromium.org, May 18 2017

Comment 3 Deleted

Comment 4 by dchan@chromium.org, Aug 1 2017

Comment 4 Deleted

Comment 5 by dchan@chromium.org, Jan 22 2018

Comment 5 Deleted

Sign in to add a comment