I believe that
- It's intentional that chrome://* pages cannot be set as startup pages.
- it's the same behavior as the old options, other than the old options didn't indicate that it would open a new tab page (NTP).

Other things we could do instead: Maybe disable the "Use current pages" button if clicking it will not have an effect.

I only see a problem with chrome://settings. All other chrome://* pages seems to work just fine as startup pages (see screenshot).

Deleted: chrome_startup_pages.png 25.6 KB

	chrome_startup_pages.png 25.6 KB View Download

Whoops, you're right. It still looks like chrome://settings is cleared from the list in old options when clicking Use current pages.

I suppose the code is only excluding chrome://settings from the startup URLs list. If I have two tabs open, chrome://md-settings and google.com, clicking "Use current pages" adds google.com only as a startup page.

The fact that md-settings is successfully added as a startup page is probably a bug (which I had using for many months for convenience).

I agree that perhaps disabling the "Use current pages" button when no page will be added would be better, but probably a P3.

It should prohibit this list:
https://cs.chromium.org/chromium/src/chrome/browser/extensions/extension_tab_util.cc?type=cs&l=578

Here's the filtering for use current pages
https://cs.chromium.org/chromium/src/chrome/browser/custom_home_pages_table_model.cc?type=cs&q=SetToCurrentlyOpenPages&l=33

I am rephrasing this bug to better reflect the issue, now that we established that ignoring chrome://settings is WAI.

chrome://settings page will always be open when you click this button ;) ... from chrome://settings.  i imagine why the special case for this URL was added to ignore it.

we should probably just ignore the tab it was triggered from, not blanket-ly by URL.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f94b0755c37c196d8459119dfb933d9d5e744dc

commit 6f94b0755c37c196d8459119dfb933d9d5e744dc
Author: dbeam <dbeam@chromium.org>
Date: Thu Jun 08 00:20:18 2017

MD Settings/On Startup: ignore current tab when using current pages

This changes the approach away from a URL blacklist.

R=dschuyler@chromium.org
BUG=722623

Review-Url: https://codereview.chromium.org/2924943002
Cr-Commit-Position: refs/heads/master@{#477823}

[modify] https://crrev.com/6f94b0755c37c196d8459119dfb933d9d5e744dc/chrome/browser/custom_home_pages_table_model.cc
[modify] https://crrev.com/6f94b0755c37c196d8459119dfb933d9d5e744dc/chrome/browser/custom_home_pages_table_model.h
[modify] https://crrev.com/6f94b0755c37c196d8459119dfb933d9d5e744dc/chrome/browser/ui/webui/options/startup_pages_handler.cc
[modify] https://crrev.com/6f94b0755c37c196d8459119dfb933d9d5e744dc/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot