New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722612 link

Starred by 1 user
Status: Fixed
Owner:
ccameron@chromium.org
Closed: May 2017
Cc:
f...@opera.com
brianosman@chromium.org
█ msarett@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

blink: Rename blink::ColorSpace to something more accurate

Project Member Reported by ccameron@chromium.org, May 15 2017 
The enum blink::ColorSpace conflicts conceptually with gfx::ColorSpace.

Eliminate kColorSpaceDeviceRGB, as there is to be no device-dependent rendering.

It appears that a blink::ColorSpace refers only to a transfer function, in particular sRGB or linear. Rename blink::ColorSpace to blink::Gamma to reflect this.

Comment 1 by ccameron@chromium.org, May 15 2017 

To look a bit more at the context in  issue 336440 , I think just renaming this to "ColorInterpolation" or "InteroplationSpace" may be better.

Comment 2 by ccameron@chromium.org, May 15 2017

Cc: msarett@chromium.org brianosman@chromium.org

Comment 3 by f...@opera.com, May 16 2017 

c#1 SGTM
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8a4655d6d92c49853dc1d395d09d7cf86777d84

commit b8a4655d6d92c49853dc1d395d09d7cf86777d84
Author: ccameron <ccameron@chromium.org>
Date: Thu May 18 03:44:32 2017

color: Rename blink::ColorSpace to blink::InterpolationSpace

blink::ColorSpace is used to specify in which space to perform pixel
value interpolation. Change the name to reflect that.

We use gfx::ColorSpace and SkColorSpace for true color spaces.

BUG= 722612 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2884313002
Cr-Commit-Position: refs/heads/master@{#472645}

[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp
[delete] https://crrev.com/f1eefca818771900ae2977d86952d42cb3b7fcb2/third_party/WebKit/Source/platform/graphics/ColorSpace.cpp
[delete] https://crrev.com/f1eefca818771900ae2977d86952d42cb3b7fcb2/third_party/WebKit/Source/platform/graphics/ColorSpace.h
[add] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.cpp
[add] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/ColorSpaceGamut.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[add] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/InterpolationSpace.cpp
[add] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/InterpolationSpace.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEBoxReflect.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEDropShadow.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEFlood.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FETile.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/ImageFilterBuilderTest.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/PaintFilterEffect.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp
[modify] https://crrev.com/b8a4655d6d92c49853dc1d395d09d7cf86777d84/third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp

Comment 5 by ccameron@chromium.org, May 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment