ArcExt4Migration: Critical update available message is seen for supervised user but no migration UI on signin |
||||||||
Issue descriptionGoogle Chrome 60.0.3100.0 (Official Build) dev (32-bit) Revision 0 Platform 9554.0.0 (Official Build) dev-channel kevin What steps will reproduce the problem? 1. Device on M59. 2. Add a supervised user account and AU from M59 to M60. 3. Click on supervised user pod 4. See message "You've got a critical update. Sign in to get started". 5. Login and see there is no migration UI. 6. Log-out 7. "You've got a critical update. Sign in to get started" message is still there.
,
May 16 2017
crbug.com/721623 is somewhat related but different ?
,
May 16 2017
Issue 721623 is about signing into the parent to create a supervised user. This bug is about signing into an already created supervised user that was created before AU
,
May 16 2017
#3 is right. 721623 is a different issue. Well, good catch. > 3. Click on supervised user pod > 4. See message "You've got a critical update. Sign in to get started". Since we don't migrate supervised users (who cannot use ARC), the users stay in ecryptfs, but the login-screen banner only checks the Arc availability in general on the device and hence it shows the popup. xiyuan@, fukino@, any ideas? If we can known the user is a supervised user at the point we can filter them out, but there may be nicer more generic solution.
,
May 16 2017
I don't have generic solution. Got CL https://codereview.chromium.org/2879393003/ that restricts the banner to only users with Gaia account and AD users (when ARC for AD is enabled). The logic is from IsArcAllowedInAppListForProfile [1]. [1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/arc_util.cc?rcl=266c2738a4fb94018caba538e308c60a44cb9646&l=135
,
May 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/468a6511775fca06ef0ae9d483cd2dc5668fdff8 commit 468a6511775fca06ef0ae9d483cd2dc5668fdff8 Author: xiyuan <xiyuan@chromium.org> Date: Tue May 16 16:34:38 2017 cros: No migration banner if user not allowed for ARC Only show migration banner for the following user types: - Users with Gaia account (regular and child users); - AD users when ARC is allowed for AD users; BUG= 722602 Review-Url: https://codereview.chromium.org/2879393003 Cr-Commit-Position: refs/heads/master@{#472128} [modify] https://crrev.com/468a6511775fca06ef0ae9d483cd2dc5668fdff8/chrome/browser/chromeos/login/screens/user_selection_screen.cc
,
May 16 2017
,
May 16 2017
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5571ae86055a58688b4dc9969b759d0df76b8fcd commit 5571ae86055a58688b4dc9969b759d0df76b8fcd Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed May 17 16:17:51 2017 Merge "cros: No migration banner if user not allowed for ARC" > Only show migration banner for the following user types: > - Users with Gaia account (regular and child users); > - AD users when ARC is allowed for AD users; > > BUG= 722602 > > Review-Url: https://codereview.chromium.org/2879393003 > Cr-Commit-Position: refs/heads/master@{#472128} > (cherry picked from commit 468a6511775fca06ef0ae9d483cd2dc5668fdff8) Review-Url: https://codereview.chromium.org/2888653004 . Cr-Commit-Position: refs/branch-heads/3071@{#599} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/5571ae86055a58688b4dc9969b759d0df76b8fcd/chrome/browser/chromeos/login/screens/user_selection_screen.cc
,
May 17 2017
,
May 19 2017
Verified on Kevin cros:9567.0.0/60.0.3103.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dhadd...@chromium.org
, May 15 2017Summary: ArcExt4Migration: Critical update available message is seen for supervised user but no migration UI on signin (was: ArcExt4Migration: Critical update available message is seen for supervised user)