New issue
Advanced search Search tips

Issue 722601 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Renamed SharedMemoryHandle to SharedMemoryReference

Project Member Reported by erikc...@chromium.org, May 15 2017

Issue description

rockot@ points out:
"""
I think maybe the issue here is that the word "handle" is a bit of a
misnomer at this point, and it's setting the wrong expectations for what
the type should represent. Keeping track of a shared buffer reference in a
way that can be used consistently and reliably across process boundaries
requires more than just a system object handle, in practice.

Imagine we renamed it to MappableSharedBufferReference or something, but
then imagine that such a rename would create more churn than is worthwhile.
"""

Giant refactors are never fun, and are best done at odd hours of the day.
 

Comment 1 by thakis@chromium.org, May 15 2017

Doesn't have to be giant.

1.) Rename class, add `typedef NewName OldName` right below class
2.) In small batches, s/OldName/NewName/ all over the code base
3.) Remove typedef
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment