New issue
Advanced search Search tips

Issue 722589 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 696356



Sign in to add a comment

Upgrade FreeType to 2.8

Project Member Reported by js...@chromium.org, May 15 2017

Issue description

FreeType 2.8 was released a couple of days ago. 

CrOS has had a rather large patch applied on top of 2.7.1. We can drop that large patch by going to 2.8. 

Chrome has 2.7.1+update, but we can roll a bit more to 2.8. 

In addition to features, we can get a few security fixes as well.


 

Comment 1 by js...@chromium.org, May 15 2017

Cc: behdad@chromium.org

Comment 2 by drott@chromium.org, May 16 2017

Cc: thestig@chromium.org
Chromium CL up in https://codereview.chromium.org/2885503004

Comment 3 by js...@chromium.org, May 16 2017

Blocking: 696356
Project Member

Comment 4 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e568fe667c7bf74a30b59659f07cafe1fdee54

commit 93e568fe667c7bf74a30b59659f07cafe1fdee54
Author: drott <drott@chromium.org>
Date: Wed May 17 06:28:55 2017

Roll FreeType to 2.8

Update ftoption.h with new (unused by us) setting:
AF_CONFIG_OPTION_TT_SIZE_METRICS

BUG= 722589 

Review-Url: https://codereview.chromium.org/2885503004
Cr-Commit-Position: refs/heads/master@{#472350}

[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/DEPS
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-inside-transforms-backward-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/editing/selection/extend-inside-transforms-forward-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-transformed-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-transform-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/fast/text/color-emoji-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/compositing/text-match-highlight-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/animated-path-inside-transformed-html-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/tabgroup-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/svg/zoom-foreignObject-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-text-07-t-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/as-background-image/svg-as-background-5-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/smallFonts-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect3-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textLayout2-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath2-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath3-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPathSpaces-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalText-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/verticalTextOnPath-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/colourpicker-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/combobox-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/carto.net/selectionlist-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/foreign-object-skew-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/glyph-transformation-with-hkern-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/linking-a-03-b-transform-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-dom-01-f-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-linking-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-match-highlight-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-rotated-gradient-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-rotation-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-1-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-2-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-3-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-4-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-5-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-disallowed-foreign-object-6-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/custom/use-on-non-svg-namespaced-element-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/hixie/perf/003-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/text/bbox-with-glyph-overflow-zoomed-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/text/ligature-queries-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-decorations-in-scaled-pattern-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-path-01-b-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-text-07-t-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-mask-with-svg-transform-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-scalable-background-image2-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-foreignObject-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/compound-transforms-vs-containers-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/transforms/shadows-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-table-row-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/transforms/transformed-document-element-expected.png
[add] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png
[add] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png
[add] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[add] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/compositing/text-match-highlight-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/tabgroup-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/zoom-foreignObject-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/popup-menu-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/freetype/README.chromium
[modify] https://crrev.com/93e568fe667c7bf74a30b59659f07cafe1fdee54/third_party/freetype/include/freetype-custom-config/ftoption.h

Comment 5 by drott@chromium.org, May 17 2017

So, fixed for Chromium, should I keep the bug open for ChromeOS?

Comment 6 by js...@chromium.org, May 19 2017

Chrome OS CL is in CQ. Will land soon (if I'm lucky with CrOS CQ :-) ). 

Comment 7 by js...@chromium.org, May 19 2017

https://chromium-review.googlesource.com/c/506850/  : CQ failed. WIth my fingers cross, I sent it to CQ again :-)

BTW, thank you for quickly updating Chrome's bundled FT as well as statically linking FT to Linux Chrome. 

Comment 8 by drott@chromium.org, May 19 2017

You're welcome, thank you for taking care of the CrOS side. 
Project Member

Comment 9 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a81623747d0e78c88e9744e4bcee0f3d8c413270

commit a81623747d0e78c88e9744e4bcee0f3d8c413270
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri May 19 23:23:37 2017

Update FreeType to 2.8 from 2.7.1+patches (e432ebf)

A few notable changes include:

 - Autohinting support for a number of "small" scripts
 - Variable font support fixes (e.g. MVAR/HVAR/VVAR handling, CFF2,
   instance namining)
 - Sanitizer issue fixes
 - Allow linear scaling for unhinted rendering ( crbug.com/696356 )

The first one will allow us to use autohints for more fonts.

Changlog:

https://chromium.googlesource.com/chromium/src/third_party/freetype2/+log/e432ebf..a12a344

BUG= chromium:722589 , chromium:696356 , chromium:716995 
TEST=emerge-{x86-alex,amd64-generic,daisy} freetype succeeds.
TEST=cbuildbot chromiumos-sdk
TEST=cbuildbot  amd64-generic-full x86-generic-full arm-generic-full
TEST=manual/visual: WebUI rendering and web page rendering do not have any noticeable regression. (they can be slightly different).

Change-Id: I08504ddf568ce0cb2e73fe05c4013ebd92dc3240
Reviewed-on: https://chromium-review.googlesource.com/506850
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/e523e17f5f8eb48bb5f2482dd4a11d807c377916/media-libs/freetype/files/freetype-2.7.1-ttnames.patch
[rename] https://crrev.com/a81623747d0e78c88e9744e4bcee0f3d8c413270/media-libs/freetype/freetype-2.8.ebuild
[delete] https://crrev.com/e523e17f5f8eb48bb5f2482dd4a11d807c377916/media-libs/freetype/freetype-2.7.1-r1.ebuild
[modify] https://crrev.com/a81623747d0e78c88e9744e4bcee0f3d8c413270/media-libs/freetype/Manifest
[delete] https://crrev.com/e523e17f5f8eb48bb5f2482dd4a11d807c377916/media-libs/freetype/files/freetype-2.7.1-e432ebf.patch
[add] https://crrev.com/a81623747d0e78c88e9744e4bcee0f3d8c413270/media-libs/freetype/freetype-2.8-r1.ebuild

Comment 10 by js...@chromium.org, May 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment