New issue
Advanced search Search tips

Issue 722577 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Move mobile client UI code into subdirectory

Project Member Reported by yuweih@chromium.org, May 15 2017

Issue description

This cleans up the project structure and makes it easier to have more granular control on the dependencies.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/631efbaf799b5af0f13986871a700289d66f8c9e

commit 631efbaf799b5af0f13986871a700289d66f8c9e
Author: yuweih <yuweih@chromium.org>
Date: Tue May 16 02:20:03 2017

[CRD iOS] Move UI stuff into a subdirectory

We started having too much mobile UI code under /client. This starts becomming
a pain when we deal with mobile client dependencies that involve /client and
/client/display.

This CL moves the mobile UI code under /client/ui

BUG= 722577 

Review-Url: https://codereview.chromium.org/2879383002
Cr-Commit-Position: refs/heads/master@{#471983}

[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/BUILD.gn
[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/BUILD.gn
[add] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/BUILD.gn
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/desktop_viewport.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/desktop_viewport.h
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/desktop_viewport_unittest.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/direct_input_strategy.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/direct_input_strategy.h
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/fling_animation.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/fling_animation.h
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/fling_animation_unittest.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/fling_tracker.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/fling_tracker.h
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/gesture_interpreter.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/gesture_interpreter.h
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/input_strategy.h
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/view_matrix.cc
[rename] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/client/ui/view_matrix.h
[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/ios/app/host_view_controller.mm
[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/ios/client_gestures.mm
[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/ios/display/gl_display_handler.h
[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/ios/session/BUILD.gn
[modify] https://crrev.com/631efbaf799b5af0f13986871a700289d66f8c9e/remoting/ios/session/remoting_client.mm

Comment 2 by yuweih@chromium.org, May 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment