New issue
Advanced search Search tips

Issue 722570 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Use PaintImage stable id from blink to make checkering decisions.

Project Member Reported by khushals...@chromium.org, May 15 2017

Issue description

Now that we have a stable image id from blink, along with the static/animated and partial/complete state, update checker-imaging to not checker animated and partially decoded images.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e13bff12f02c4dc487d87451b329754ce1c1cc

commit d5e13bff12f02c4dc487d87451b329754ce1c1cc
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed May 17 08:08:50 2017

cc: Keep PaintImage in DrawImage.

Currently we only store the SkImage in DrawImage during discardable
meta-data generation. This change extends that to store PaintImage so
it can be used by the checker-imaging system during raster.

It also updates checker-imaging to not checker on static and partially
loaded images.

BUG= 722570 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2857923004
Cr-Commit-Position: refs/heads/master@{#472379}

[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/layers/picture_layer_impl.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/discardable_image_map.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/discardable_image_map_unittest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/discardable_image_store.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/discardable_image_store.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/display_item_list.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/display_item_list.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/draw_image.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/draw_image.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/image_id.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/paint_image.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/paint/paint_image.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/raster/image_hijack_canvas.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/raster/image_hijack_canvas.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/raster/image_hijack_canvas_unittest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/raster/raster_source.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/raster/raster_source.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/test/fake_content_layer_client.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/test/fake_recording_source.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/checker_image_tracker.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/image_controller.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/software_image_decode_cache.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/software_image_decode_cache_perftest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/software_image_decode_cache_unittest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/tile_manager.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/tiles/tile_manager.h
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/d5e13bff12f02c4dc487d87451b329754ce1c1cc/cc/trees/layer_tree_impl.h

Status: Fixed (was: Assigned)

Sign in to add a comment