Issue metadata
Sign in to add a comment
|
Two BackgroundLoaderOfflinerTest flaky: crashing intermittently on chromium.android/Lollipop Phone Tester |
||||||||||||||||||||||||
Issue descriptionThere's a new crash on this build https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11985 dewittj@ Maybe your recent CL might be involved? https://codereview.chromium.org/2873953003
,
May 15 2017
Not likely to be my change <punt>
,
May 16 2017
chili@, we're seeing several crashes a day on this, so it would be nice if you could take a look or give us an update here. Any idea how long this has been going on? Maybe CC other folks that might have some idea? I see lots of frequent runs with a roughly 10% crash rate here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests%20(with%20patch)&tests=BackgroundLoaderOfflinerTest.NoNextOnInternetDisconnected
,
May 16 2017
Seems like there's another test that's also flaky. Will take a look
,
May 16 2017
Yes, looks like FailsOnErrorPage and NoNextOnInternetDisconnected are intermittently crashing (flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=BackgroundLoaderOfflinerTest) This is pretty bad. I think we should disable these failing tests until they are fixed.
,
May 16 2017
I was able to repro the crash with a N7 tablet and got a stack trace, but it doesn't look very informative to me.
background_loader_offliner_unittest.cc:183 reads " PumpLoop();"
background_loader_offliner_unittest.cc:520 is a blank line after " PumpLoop();" and before " EXPECT_TRUE(completion_callback_called());"
signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 15848 (st:test_process)
pid: 15848, tid: 15848, name: st:test_process >>> org.chromium.native_test:test_process <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
r0 93d84e10 r1 00000002 r2 00000000 r3 0000004c
r4 be8357a4 r5 93d84e10 r6 aed88268 r7 be835798
r8 aeccc4dc r9 b4d7e554 sl 00000000 fp 00000000
ip aed85948 sp be835790 lr aeca4373 pc 00000000
Stack Trace:
RELADDR FUNCTION FILE:LINE
00000000 <unknown>
v------> Destruct /usr/local/google/code/clankium/src/base/callback_internal.cc:21
v------> Release /usr/local/google/code/clankium/src/base/memory/ref_counted.h:310
v------> Release /usr/local/google/code/clankium/src/base/memory/ref_counted.h:572
v------> ~scoped_refptr /usr/local/google/code/clankium/src/base/memory/ref_counted.h:473
0008a371 ~CallbackBase /usr/local/google/code/clankium/src/base/callback_internal.cc:82
00089949 Run /usr/local/google/code/clankium/src/base/callback.h:92
00095cfd RunTask /usr/local/google/code/clankium/src/base/debug/task_annotator.cc:59
000b2329 RunTask /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:404
000b257d DeferOrRunPendingTask /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:415
000b2679 DoWork /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:503
000b4c11 Run /usr/local/google/code/clankium/src/base/message_loop/message_pump_libevent.cc:219
000b21a7 RunHandler /usr/local/google/code/clankium/src/base/message_loop/message_loop.cc:368
000d0603 Run /usr/local/google/code/clankium/src/base/run_loop.cc:105
000d08e3 RunUntilIdle /usr/local/google/code/clankium/src/base/run_loop.cc:115
0040141b policy::PolicyTestBase::TearDown() /usr/local/google/code/clankium/src/chrome/browser/download/download_path_reservation_tracker_unittest.cc:89
006bb81f CompleteLoading /usr/local/google/code/clankium/src/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc:183
006bdf71 TestBody /usr/local/google/code/clankium/src/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc:520
v------> HandleExceptionsInMethodIfSupported<testing::Test, void> /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:2458
00773fa3 Run /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:2474
0077468d Run /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:2656
007749b9 Run /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:2774
0077856d RunAllTests /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:4650
v------> HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:2458
007782eb Run /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/src/gtest.cc:4258
v------> RUN_ALL_TESTS /usr/local/google/code/clankium/src/third_party/googletest/src/googletest/include/gtest/gtest.h:2237
00a024fd Run /usr/local/google/code/clankium/src/base/test/test_suite.cc:271
v------> Run /usr/local/google/code/clankium/src/base/callback.h:80
v------> LaunchUnitTestsInternal /usr/local/google/code/clankium/src/base/test/launcher/unit_test_launcher.cc:192
00a0f097 LaunchUnitTests /usr/local/google/code/clankium/src/base/test/launcher/unit_test_launcher.cc:458
009f4e1b main /usr/local/google/code/clankium/src/chrome/test/base/run_all_unittests.cc:30
v------> RunTests /usr/local/google/code/clankium/src/testing/android/native_test/native_test_launcher.cc:128
009eec2d Java_org_chromium_native_1test_NativeTest_nativeRunTests /usr/local/google/code/clankium/src/out-gn/Debug/gen/testing/android/native_test/native_test_jni_headers/testing/jni/NativeTest_jni.h:49
021940f1 offset 0x171e000) (void org.chromium.native_test.NativeTest.nativeRunTests(java.lang.String, java.lang.String, java.lang.String, android.content.Context, java.lang.String)+196 /data/app/org.chromium.native_test-1/oat/arm/base.odex
02194d8f offset 0x171e000) (void org.chromium.native_test.NativeTest.runTests(android.app.Activity)+250 /data/app/org.chromium.native_test-1/oat/arm/base.odex
02193ffd offset 0x171e000) (void org.chromium.native_test.NativeTest.access$000(org.chromium.native_test.NativeTest, android.app.Activity)+64 /data/app/org.chromium.native_test-1/oat/arm/base.odex
02193a5b offset 0x171e000) (void org.chromium.native_test.NativeTest$1.run()+110 /data/app/org.chromium.native_test-1/oat/arm/base.odex
73979487 offset 0x1ed5000 /data/dalvik-cache/arm/system@framework@boot.oat
,
May 16 2017
Merging back from the other bug because there's better info in this bug.
,
May 16 2017
,
May 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ed92c85ad786af4f04f9934c1c994236403d01 commit c4ed92c85ad786af4f04f9934c1c994236403d01 Author: donnd <donnd@chromium.org> Date: Wed May 17 02:12:23 2017 Disable crashing unittests in background offliner. Two unit tests are crashing a lot on Android, disabling those tests in background_loader_offliner_unittest.cc for Android only. BUG= 722556 TBR=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2891623002 Cr-Commit-Position: refs/heads/master@{#472286} [modify] https://crrev.com/c4ed92c85ad786af4f04f9934c1c994236403d01/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
,
May 30 2017
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 30 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f58b43a235e222eeb4620d5f379182c78414189 commit 6f58b43a235e222eeb4620d5f379182c78414189 Author: Cathy Li <chili@chromium.org> Date: Thu Jun 15 01:42:58 2017 [Offline pages] Detect and record http error codes in new combined UMA. Also fix test flake caused by deleting calling object. NetError codes are reported for the network errors for which chrome would have to generate our own error message and error page. http error codes are when the server had an error, often accompanied by server-generated error page. Either way, our decision on not downloading any error page still applies. Bug: 725682 , 722556 Change-Id: I9f016b5724a8ea6a98b574bd41d490ceb5aeb197 Reviewed-on: https://chromium-review.googlesource.com/517812 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#479575} [modify] https://crrev.com/6f58b43a235e222eeb4620d5f379182c78414189/chrome/browser/offline_pages/background_loader_offliner.cc [modify] https://crrev.com/6f58b43a235e222eeb4620d5f379182c78414189/chrome/browser/offline_pages/background_loader_offliner_unittest.cc [modify] https://crrev.com/6f58b43a235e222eeb4620d5f379182c78414189/content/public/test/web_contents_tester.h [modify] https://crrev.com/6f58b43a235e222eeb4620d5f379182c78414189/content/test/test_web_contents.cc [modify] https://crrev.com/6f58b43a235e222eeb4620d5f379182c78414189/content/test/test_web_contents.h [modify] https://crrev.com/6f58b43a235e222eeb4620d5f379182c78414189/tools/metrics/histograms/histograms.xml
,
Jun 15 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by donnd@chromium.org
, May 15 2017