We don't need it for mustash anymore.
Starting to remove WmWindow from Alt+Tab (WindowCycler) and Overview mode (WindowSelector). https://codereview.chromium.org/2893643003
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b094092929ca499b94465bfefe68ebac5195947 commit 4b094092929ca499b94465bfefe68ebac5195947 Author: varkha <varkha@chromium.org> Date: Thu May 18 03:36:31 2017 [mus+ash] Removes WmWindow from ash/wm/window_cycle_* Refactors Alt+Tab and starts refactoring Overview mode to use aura::Window directly. BUG= 722553 TEST=None Review-Url: https://codereview.chromium.org/2893643003 Cr-Commit-Position: refs/heads/master@{#472638} [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_cycle_controller.cc [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_cycle_controller.h [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_cycle_list.cc [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_cycle_list.h [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_mirror_view.cc [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm/window_mirror_view.h [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm_window.cc [modify] https://crrev.com/4b094092929ca499b94465bfefe68ebac5195947/ash/wm_window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8 commit 4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8 Author: sky <sky@chromium.org> Date: Thu May 18 23:50:26 2017 chromeos: removes WmWindow usage from MultiWindowResizeController BUG= 722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2891183002 Cr-Commit-Position: refs/heads/master@{#472978} [modify] https://crrev.com/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8/ash/root_window_controller.cc [modify] https://crrev.com/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8/ash/root_window_controller.h [modify] https://crrev.com/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8/ash/wm/workspace/multi_window_resize_controller.cc [modify] https://crrev.com/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8/ash/wm/workspace/multi_window_resize_controller.h [modify] https://crrev.com/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8/ash/wm/workspace/multi_window_resize_controller_unittest.cc [modify] https://crrev.com/4befdb0d6d0896948df1f5d3a7fcfb3b33a611b8/ash/wm/workspace/workspace_event_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a781fb649239a915431b9ab98a8e6e0f4155f2fa commit a781fb649239a915431b9ab98a8e6e0f4155f2fa Author: sky <sky@chromium.org> Date: Fri May 19 22:35:45 2017 chromeos: nukes window_state_aura And moves the lookup functions in window_state. I would prefer these functions be static functions on WindowState, but that's for another day. BUG= 722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2889413002 Cr-Commit-Position: refs/heads/master@{#473369} [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/BUILD.gn [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/accelerators/accelerator_commands_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/accelerators/accelerator_controller_delegate_aura.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/accelerators/accelerator_filter_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/accelerators/accelerator_interactive_uitest_chromeos.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/display/display_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/display/window_tree_host_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/frame/caption_buttons/frame_size_button_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/root_window_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/root_window_controller_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/shell/toplevel_window.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/ash_focus_rules.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/ash_focus_rules_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/fullscreen_window_finder.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/lock_layout_manager.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/lock_layout_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/mru_window_tracker_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/overview/window_grid.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/panels/panel_window_event_handler.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/resize_handle_window_targeter.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/resize_shadow_and_cursor_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/system_gesture_event_filter_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/toplevel_window_event_handler.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/video_detector.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/video_detector_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_animations_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_cycle_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_cycle_list.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_mirror_view.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_state.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_state.h [delete] https://crrev.com/f1d7f62ed596312a3e0bb1c3677a4a1ccbd8030d/ash/wm/window_state_aura.cc [delete] https://crrev.com/f1d7f62ed596312a3e0bb1c3677a4a1ccbd8030d/ash/wm/window_state_aura.h [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_state_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_util.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/window_util_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace/multi_window_resize_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/ash/wm_window.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/chromeos/events/event_rewriter_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/notifications/fullscreen_notification_blocker.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/accelerator_commands_browsertest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/accelerator_controller_browsertest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/chrome_views_delegate_chromeos.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/frame/browser_frame_ash.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/tabs/tab_drag_controller.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/components/exo/shell_surface.cc [modify] https://crrev.com/a781fb649239a915431b9ab98a8e6e0f4155f2fa/components/exo/shell_surface_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c commit a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c Author: sky <sky@chromium.org> Date: Mon May 22 20:45:35 2017 chromeos: converts WindowResizer to aura::Window BUG= 722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2897993003 Cr-Commit-Position: refs/heads/master@{#473682} [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/frame/caption_buttons/frame_size_button.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/default_state.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/default_window_resizer.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/drag_window_resizer.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/drag_window_resizer.h [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/panels/panel_window_resizer.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/panels/panel_window_resizer.h [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/system_gesture_event_filter_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/window_positioning_utils.h [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/window_resizer.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/window_resizer.h [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/workspace/multi_window_resize_controller.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/workspace/workspace_window_resizer.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/workspace/workspace_window_resizer.h [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm_window.cc [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/ash/wm_window.h [modify] https://crrev.com/a5e9a12879fd2dd7d9ce4e389c5d8e36e648568c/components/exo/shell_surface.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd5eef96e6af8e2c6a5350524a1b782162b0b34d commit fd5eef96e6af8e2c6a5350524a1b782162b0b34d Author: sky <sky@chromium.org> Date: Tue May 23 18:31:13 2017 chromeos: converts WindowState to aura::Window BUG= 722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2901663003 Cr-Commit-Position: refs/heads/master@{#473992} [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/frame/custom_frame_view_ash.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/root_window_controller.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/test/BUILD.gn [delete] https://crrev.com/02950edae45e711363532457ec564092ca1666f6/ash/test/wm_window_test_api.cc [delete] https://crrev.com/02950edae45e711363532457ec564092ca1666f6/ash/test/wm_window_test_api.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/default_state.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/drag_details.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/drag_details.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/lock_layout_manager.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/lock_window_state.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/lock_window_state.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/overview/window_grid.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/panels/panel_layout_manager.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/window_resizer.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/window_state.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/window_state.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/window_state_util.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/window_util.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/workspace/workspace_event_handler.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm/workspace/workspace_window_resizer.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm_window.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/ash/wm_window.h [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/chrome/browser/ui/ash/accelerator_commands_browsertest.cc [modify] https://crrev.com/fd5eef96e6af8e2c6a5350524a1b782162b0b34d/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/843aa52b01713a6605988ab3ee104b43d9087cd7 commit 843aa52b01713a6605988ab3ee104b43d9087cd7 Author: varkha <varkha@chromium.org> Date: Wed May 24 16:05:59 2017 [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview WIP - uploading to give visibility into what I am doing here. Refactoring mru_window_tracker and connected classes to remove use of WmWindow. BUG= 722553 TEST=None TBR=xiyuan@chromium.org for a small non-behavioral change in chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc Review-Url: https://codereview.chromium.org/2895713002 Cr-Commit-Position: refs/heads/master@{#474310} [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/accelerators/accelerator_commands.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/content/screen_orientation_delegate_chromeos.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/display/display_manager_unittest.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/display/screen_orientation_controller_chromeos.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/display/screen_orientation_controller_chromeos.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/focus_cycler.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/system/overview/overview_button_tray.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/ash_focus_rules.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/focus_rules.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/focus_rules.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_controller.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_controller.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_window_manager.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_window_manager.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/maximize_mode/maximize_mode_window_state.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/mru_window_tracker.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/mru_window_tracker.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/mru_window_tracker_unittest.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/scoped_overview_animation_settings_factory.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/scoped_overview_animation_settings_factory_aura.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/scoped_overview_animation_settings_factory_aura.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_grid.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_grid.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_selector.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_selector.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/window_cycle_controller.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/window_positioner.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/window_positioner.h [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/chromeos/login/users/wallpaper/wallpaper_window_state_manager.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/843aa52b01713a6605988ab3ee104b43d9087cd7/chrome/browser/ui/window_sizer/window_sizer_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/007c108740cae36d86b5778dee1829a46b8a4ca9 commit 007c108740cae36d86b5778dee1829a46b8a4ca9 Author: sky <sky@chromium.org> Date: Wed May 24 18:40:08 2017 chromeos: converts PanelLayoutManager to aura::Window As well as AlwaysOnTopController. BUG= 722553 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2896273004 Cr-Commit-Position: refs/heads/master@{#474369} [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/root_window_controller.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/always_on_top_controller.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/always_on_top_controller.h [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/container_finder.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/overview/window_selector.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/panels/panel_layout_manager.h [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/panels/panel_window_resizer.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/007c108740cae36d86b5778dee1829a46b8a4ca9/ash/wm/workspace_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6af4d8438538098e9c0a06bd17453f0ca32ecece commit 6af4d8438538098e9c0a06bd17453f0ca32ecece Author: varkha <varkha@chromium.org> Date: Wed May 24 20:36:26 2017 [ash] Cleanup of ScopedOverviewAnimationSettings This cleanup is now possible with WmWindow gone. BUG= 722553 TEST=None (refactoring) TBR=jamescook@chromium.org (for a trivial removal in ash/shell.cc) Review-Url: https://codereview.chromium.org/2901903003 Cr-Commit-Position: refs/heads/master@{#474403} [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/BUILD.gn [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/shell.cc [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/shell.h [rename] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/wm/overview/scoped_overview_animation_settings.cc [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/wm/overview/scoped_overview_animation_settings.h [delete] https://crrev.com/5bb096e9730d7ffc0fe3352fce677fafc0d7fd0c/ash/wm/overview/scoped_overview_animation_settings_aura.h [delete] https://crrev.com/5bb096e9730d7ffc0fe3352fce677fafc0d7fd0c/ash/wm/overview/scoped_overview_animation_settings_factory.cc [delete] https://crrev.com/5bb096e9730d7ffc0fe3352fce677fafc0d7fd0c/ash/wm/overview/scoped_overview_animation_settings_factory.h [delete] https://crrev.com/5bb096e9730d7ffc0fe3352fce677fafc0d7fd0c/ash/wm/overview/scoped_overview_animation_settings_factory_aura.cc [delete] https://crrev.com/5bb096e9730d7ffc0fe3352fce677fafc0d7fd0c/ash/wm/overview/scoped_overview_animation_settings_factory_aura.h [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/wm/overview/window_grid.cc [modify] https://crrev.com/6af4d8438538098e9c0a06bd17453f0ca32ecece/ash/wm/overview/window_selector_item.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c60fc576be97e04b4035257194d4e66daac825b commit 3c60fc576be97e04b4035257194d4e66daac825b Author: varkha <varkha@chromium.org> Date: Thu May 25 16:25:11 2017 Removes WmWindow from ash/wm/root_window_finder.h, ash/wm/workspace/phantom_window_controller.h and connected code. BUG= 722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2900423002 Cr-Commit-Position: refs/heads/master@{#474672} [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/autoclick/autoclick_controller.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/display/screen_ash.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/drag_drop/drag_drop_tracker.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/extended_desktop_unittest.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/frame/caption_buttons/frame_size_button.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/mus/screen_mus.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/shelf/shelf_view.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/shell_port.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/test/ui_controls_factory_ash.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/wm/container_finder.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/wm/root_window_finder.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/wm/root_window_finder.h [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/wm/workspace/phantom_window_controller.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/wm/workspace/phantom_window_controller.h [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/ash/wm/workspace/workspace_window_resizer.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/3c60fc576be97e04b4035257194d4e66daac825b/chrome/browser/ui/views/tabs/window_finder_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b72981a509569fa37fac74dc2488f57ddbc5930 commit 5b72981a509569fa37fac74dc2488f57ddbc5930 Author: varkha <varkha@chromium.org> Date: Thu May 25 18:51:47 2017 Removes WmWindow from window_positioning_utils BUG= 722553 TEST=None (refactoring) TBR=reveman@chromium.org for a trivial change in components/exo. Review-Url: https://codereview.chromium.org/2908433005 Cr-Commit-Position: refs/heads/master@{#474728} [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/ash/display/screen_position_controller.cc [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/ash/wm/window_positioning_utils.h [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/ash/wm/window_util_unittest.cc [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/components/exo/pointer_unittest.cc [modify] https://crrev.com/5b72981a509569fa37fac74dc2488f57ddbc5930/components/exo/test/exo_test_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87 commit cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87 Author: sky <sky@chromium.org> Date: Thu May 25 19:38:33 2017 chromeos: convert more ash/wm code to aura::Window BUG= 722553 TEST=covered by tests R=varkha@chromium.org Review-Url: https://codereview.chromium.org/2905893002 Cr-Commit-Position: refs/heads/master@{#474757} [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/frame/caption_buttons/frame_size_button.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/mus/move_event_handler.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/mus/move_event_handler.h [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/mus/window_manager.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/panels/panel_window_event_handler.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/toplevel_window_event_handler.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/toplevel_window_event_handler.h [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/window_util.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/window_util.h [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/wm_toplevel_window_event_handler.h [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/workspace/multi_window_resize_controller.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/workspace/workspace_event_handler.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/workspace/workspace_event_handler.h [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm/workspace/workspace_event_handler_aura.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm_window.cc [modify] https://crrev.com/cd9d4aeceea0690b9ce7aef8b84d6ed92b7b2f87/ash/wm_window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19d7e6c565f69afe7d6e20e6def303033faa1be6 commit 19d7e6c565f69afe7d6e20e6def303033faa1be6 Author: varkha <varkha@chromium.org> Date: Thu May 25 21:15:30 2017 [mus+ash] Removes WmWindow from ash/wm/screen_pinning_controller.h BUG= 722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2904073002 Cr-Commit-Position: refs/heads/master@{#474806} [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/accelerators/accelerator_commands_aura.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/shell.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/shell.h [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/shell_observer.h [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/wm/default_state.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/wm/maximize_mode/maximize_mode_window_state.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/wm/screen_pinning_controller.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/wm/screen_pinning_controller.h [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/19d7e6c565f69afe7d6e20e6def303033faa1be6/ash/wm/workspace/workspace_layout_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c71444e5419f060125cfdabe732bad8175d748c1 commit c71444e5419f060125cfdabe732bad8175d748c1 Author: varkha <varkha@chromium.org> Date: Thu May 25 22:51:56 2017 [mus+ash] Removes WmWindow from screen_dimmer and video_detector BUG= 722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2906693003 Cr-Commit-Position: refs/heads/master@{#474832} [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/high_contrast/high_contrast_controller.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/high_contrast/high_contrast_controller.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/root_window_controller.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/shell.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/shell.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/shell_observer.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wallpaper/wallpaper_view.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wallpaper/wallpaper_view.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/screen_dimmer.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/screen_dimmer.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/video_detector.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/video_detector.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/workspace/workspace_layout_manager.h [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/c71444e5419f060125cfdabe732bad8175d748c1/chrome/browser/chromeos/accessibility/accessibility_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da commit 6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da Author: varkha <varkha@chromium.org> Date: Fri May 26 16:14:45 2017 [mus+ash] Removes WmWindow from ash/shelf and ash/shell BUG= 722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2907853002 Cr-Commit-Position: refs/heads/master@{#475025} [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/root_window_controller.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/root_window_controller.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_controller.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_widget.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shelf/shelf_widget.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shell.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shell.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/shell_observer.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/system/palette/palette_tray.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/system/virtual_keyboard/virtual_keyboard_tray.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/test/test_shell_delegate.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/always_on_top_controller_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/default_state.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/drag_window_controller.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/drag_window_resizer.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/drag_window_resizer_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/immersive_context_ash.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/lock_layout_manager.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/attached_panel_window_targeter.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/attached_panel_window_targeter.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_frame_view.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_frame_view.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_layout_manager.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_layout_manager.h [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_window_resizer.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/screen_dimmer.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/screen_dimmer_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/screen_pinning_controller.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/screen_pinning_controller_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/system_gesture_event_filter_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/video_detector.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_animations.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_cycle_controller.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_cycle_list.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_mirror_view.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_positioner.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_resizer.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_state_util.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_util.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/window_util_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/ash/wm/workspace_controller_unittest.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/6b016b0f9a7cedd416dfc47b09e9b1da7f5d22da/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
Taking this since I have the last 2 remaining pieces drafted here: https://codereview.chromium.org/2908793002/ https://codereview.chromium.org/2908643003/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae5decc21d826351ebb953cab11c0014ea35585d commit ae5decc21d826351ebb953cab11c0014ea35585d Author: varkha <varkha@chromium.org> Date: Fri May 26 20:05:38 2017 [mus+ash] Removes WmWindow from ash/wm/overview and ash/wm/workspace BUG= 722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2908793002 Cr-Commit-Position: refs/heads/master@{#475096} [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/aura/shell_port_classic.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/aura/shell_port_classic.h [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shelf/shelf_window_watcher_item_delegate.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shelf/shelf_window_watcher_item_delegate.h [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shell.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/shell_port.h [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/cleanup_animation_observer_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/window_grid.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/window_selector.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/tablet_mode/tablet_mode_event_handler.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/tablet_mode/tablet_mode_window_state.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/window_util.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/window_util.h [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/backdrop_controller.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/multi_window_resize_controller_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/workspace_event_handler_aura.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/workspace_event_handler_aura.h [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/workspace_layout_manager.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace/workspace_window_resizer_unittest.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm/workspace_controller.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm_window.cc [modify] https://crrev.com/ae5decc21d826351ebb953cab11c0014ea35585d/ash/wm_window.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d43f552484b80d116b5e07960d2565e3399d67c0 commit d43f552484b80d116b5e07960d2565e3399d67c0 Author: varkha <varkha@chromium.org> Date: Fri May 26 20:55:58 2017 [mus+ash] Removes WmWindow from ash/wm/focus_rules With this CL WmWindow is no longer used in ash/wm. BUG= 722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2908643003 Cr-Commit-Position: refs/heads/master@{#475121} [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/mus/shell_delegate_mus.cc [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/mus/shell_delegate_mus.h [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/shell/shell_delegate_impl.cc [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/shell/shell_delegate_impl.h [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/shell_delegate.h [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/test/test_shell_delegate.cc [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/test/test_shell_delegate.h [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/ash/wm/focus_rules.cc [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/chrome/browser/ui/ash/chrome_shell_delegate.h [modify] https://crrev.com/d43f552484b80d116b5e07960d2565e3399d67c0/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14d8865d517de84e02b6ae59a7665612cdc06830 commit 14d8865d517de84e02b6ae59a7665612cdc06830 Author: varkha <varkha@chromium.org> Date: Sat May 27 01:10:37 2017 [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG= 722553 TEST=None (refactoring) TBR=oshima@chromium.org NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2913433002 Cr-Commit-Position: refs/heads/master@{#475195} [modify] https://crrev.com/14d8865d517de84e02b6ae59a7665612cdc06830/ash/wm/maximize_mode/maximize_mode_window_state.cc
Comment 1 by varkha@chromium.org
, May 17 2017