New issue
Advanced search Search tips

Issue 722552 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 687656



Sign in to add a comment

mash: Remove WmWindow from ash/system

Project Member Reported by jamescook@chromium.org, May 15 2017

Issue description

We don't need it for mustash anymore.

 
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320d7f295bf6705998c40241630638f40a6e7d17

commit 320d7f295bf6705998c40241630638f40a6e7d17
Author: jamescook <jamescook@chromium.org>
Date: Mon May 22 21:41:50 2017

chromeos: Eliminate WmWindow from //ash/system

It's left over from the early days of mustash/mash and we don't need it
anymore.

I left one reference because it'll be easier to clean up when WmShelf
gets converted.

Pure refactor, no behavior changes.

BUG= 722552 
TEST=ash_unittests, manual tests of chrome stylus tools

Review-Url: https://codereview.chromium.org/2895843002
Cr-Commit-Position: refs/heads/master@{#473709}

[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/mock_palette_tool_delegate.h
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_tool.h
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_tool_manager.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_tool_manager.h
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_tool_manager_unittest.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_tray.h
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/palette/palette_utils.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/status_area_widget.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/status_area_widget.h
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/toast/toast_overlay.cc
[modify] https://crrev.com/320d7f295bf6705998c40241630638f40a6e7d17/ash/system/tray/tray_bubble_wrapper.cc

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment