We don't need it for mash anymore.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d609a1b0650829208d50d74c26d4dd8dd8e9dd7 commit 5d609a1b0650829208d50d74c26d4dd8dd8e9dd7 Author: msw <msw@chromium.org> Date: Tue May 16 23:22:17 2017 mash: Remove some WmWindow usage in ash/shelf. Just a first pass, more to come later. BUG= 722551 TEST=No Chrome OS shelf changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2888623005 Cr-Commit-Position: refs/heads/master@{#472245} [modify] https://crrev.com/5d609a1b0650829208d50d74c26d4dd8dd8e9dd7/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/5d609a1b0650829208d50d74c26d4dd8dd8e9dd7/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/5d609a1b0650829208d50d74c26d4dd8dd8e9dd7/ash/shelf/wm_shelf.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad3d9551c524430d184c1d62a128576bcb2dd452 commit ad3d9551c524430d184c1d62a128576bcb2dd452 Author: msw <msw@chromium.org> Date: Thu May 18 21:23:36 2017 mash: remove more shell/shelf WmWindow usage. Eliminate Shell::GetWmRootWindowForNewWindows(). Convert ShellPort::Get*RootWindow*() to aura::Window. (use Shell::GetPrimaryRootWindow() instead in many places) Convert ScopedRootWindowForNewWindows (etc.) to aura::Window. Convert WmShelf::ForWindow to take aura::Window. Cleanup some helpers and misc WmWindow usage. BUG= 722551 , 687656 TEST=Automated; no behavior changes R=jamescook@chromium.org,xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2886253002 Cr-Commit-Position: refs/heads/master@{#472934} [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/accelerators/exit_warning_handler.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/app_list/app_list_delegate_impl.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/app_list/app_list_presenter_delegate.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/app_list/app_list_presenter_delegate_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/aura/shell_port_classic.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/aura/shell_port_classic.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/drag_drop/drag_drop_tracker_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/first_run/first_run_helper_impl.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/accelerators/accelerator_controller_registrar.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/bridge/shell_port_mash.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/bridge/shell_port_mash.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/top_level_window_factory.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/window_manager.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/mus/window_manager.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/root_window_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/root_window_controller_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/scoped_root_window_for_new_windows.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/scoped_root_window_for_new_windows.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_view.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/wm_shelf.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shelf/wm_shelf.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell/window_watcher.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell_port.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell_port.h [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/shell_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/palette/palette_utils.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/session/logout_confirmation_dialog.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/toast/toast_overlay.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/system/tray/system_tray_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/test/ash_test_base.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/drag_window_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/immersive_context_ash.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/mru_window_tracker.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/overview/window_grid.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/overview/window_selector.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_animations.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_cycle_list.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_positioner.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_positioner_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_positioning_utils.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/window_util.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/ash/wm/workspace_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/accessibility/chromevox_panel.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/first_run/steps/tray_step.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/chromeos/ui/accessibility_cursor_ring_layer.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/shelf_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/ash/system_tray_client_browsertest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc [modify] https://crrev.com/ad3d9551c524430d184c1d62a128576bcb2dd452/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca7526effd33b9d60760f5fc1d361830243a71c3 commit ca7526effd33b9d60760f5fc1d361830243a71c3 Author: msw <msw@chromium.org> Date: Wed May 31 00:52:48 2017 mash: Remove last WmWindow uses in ash/shelf. BUG= 722551 TEST=Compiles; no behavior changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2915553004 Cr-Commit-Position: refs/heads/master@{#475711} [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/overflow_bubble_view.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/shelf.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/shelf_controller.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/shelf_view.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/ca7526effd33b9d60760f5fc1d361830243a71c3/chrome/browser/ui/ash/shelf_browsertest.cc
Comment 1 by bugdroid1@chromium.org
, May 16 2017