New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722547 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 744711
issue 756173
issue 757517



Sign in to add a comment

[Findit] Flake Analyzer - Swarming task times out if there are too many iterations

Project Member Reported by st...@chromium.org, May 15 2017

Issue description

Comment 2 by wylieb@chromium.org, May 23 2017

Owner: wylieb@chromium.org

Comment 3 by st...@chromium.org, May 23 2017

Cc: chanli@chromium.org robert...@chromium.org lijeffrey@chromium.org
Status: Assigned (was: Available)

Comment 4 by st...@chromium.org, May 23 2017

Labels: -Pri-2 Pri-1

Comment 5 by wylieb@chromium.org, Jul 12 2017

Summary: [Findit] Flake Analyzer - Swarming task times out if there are too many iterations (was: Swarming task still timed out if the iteration is too many)

Comment 6 by wylieb@chromium.org, Jul 19 2017

Blocking: 744711
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1638435172301dc74285c0cdab7fe9ab96a8db67

commit 1638435172301dc74285c0cdab7fe9ab96a8db67
Author: Brandon Wylie <wylieb@chromium.org>
Date: Tue Jul 25 00:22:40 2017

[Findit] Flake Analyzer - Fix swarming timeouts for large iterations.

This breaks up test iterations into 1-hour pieces. It calculates how many tests
can run under that time constraint, and executes the 'buckets' until there are
no more iterations to run.

Bug:722547
Change-Id: I6903bb7b1e750d9ce7ef0ac821c75cdfc630386d
Reviewed-on: https://chromium-review.googlesource.com/574696
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/model/flake/test/master_flake_analysis_test.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/handlers/config.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/waterfall/flake/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/1638435172301dc74285c0cdab7fe9ab96a8db67/appengine/findit/model/wf_config.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/82cb49e7e7224e43bda371361ecc5465c45d030d

commit 82cb49e7e7224e43bda371361ecc5465c45d030d
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Jul 27 20:18:59 2017

Revert "[Findit] Flake Analyzer - Fix swarming timeouts for large iterations."

This reverts commit 1638435172301dc74285c0cdab7fe9ab96a8db67.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Findit] Flake Analyzer - Fix swarming timeouts for large iterations.
> 
> This breaks up test iterations into 1-hour pieces. It calculates how many tests
> can run under that time constraint, and executes the 'buckets' until there are
> no more iterations to run.
> 
> Bug:722547
> Change-Id: I6903bb7b1e750d9ce7ef0ac821c75cdfc630386d
> Reviewed-on: https://chromium-review.googlesource.com/574696
> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

TBR=robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org,wylieb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  722547 
Change-Id: I079bd3d5b2c0f02fda12c788e0520347282b9a93
Reviewed-on: https://chromium-review.googlesource.com/590097
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/model/flake/test/master_flake_analysis_test.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/handlers/config.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/waterfall/flake/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/82cb49e7e7224e43bda371361ecc5465c45d030d/appengine/findit/model/wf_config.py

Comment 9 by wylieb@chromium.org, Aug 17 2017

Blocking: 756173
Blocking: 757517
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f1cf828510416ff0b5d8af6e564c257762f7d61d

commit f1cf828510416ff0b5d8af6e564c257762f7d61d
Author: Brandon Wylie <wylieb@chromium.org>
Date: Fri Aug 25 17:33:43 2017

[Findit] Flake Analyzer - FindTruePassRatePipeline so iterations not needed.

Implemented the FindTruePassRatePipeline that samples the test to find out
if the pass rate has converged. This eliminates the need for storing/using
iterations.

Bug:722547
Change-Id: Ieca5c984481586c807171ba28c71c18fe72dd36e
Reviewed-on: https://chromium-review.googlesource.com/614287
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[add] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/test/wf_testcase.py
[add] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/test/analyze_flake_for_build_number_pipeline_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/test/flake_analysis_util_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/model/flake/test/master_flake_analysis_test.py
[add] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/analyze_flake_for_build_number_pipeline.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/handlers/config.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/next_build_number_pipeline.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/flake_analysis_util.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/flake_constants.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/test/next_build_number_pipeline_test.py
[modify] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/model/wf_config.py
[add] https://crrev.com/f1cf828510416ff0b5d8af6e564c257762f7d61d/appengine/findit/waterfall/flake/determine_true_pass_rate_pipeline.py

Status: Verified (was: Assigned)

Sign in to add a comment