This came up in the meeting today, as part of the discussion on making mustash easier for non-team-members to develop: https://docs.google.com/document/d/1rXhOnmOXiG_C319XerTfZJf-pg6jJx-qZs65ILfda-4/edit mus_ws_unittests -> services_ui_ws_unittests? mus_public_unittests -> services_ui_unittests or services_ui_public_unittests etc.
After talking with jam@ and rockot@.
Bonus points for an email to services-dev@ after this is done telling people about the new glorious future. :-)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee commit 0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee Author: erg <erg@chromium.org> Date: Mon May 22 20:19:43 2017 Move more mus tests to service_unittest. This moves mus_ime_unittests, ui_struct_traits_unittests, input_device_unittests, mus_public_unittests, mus_demo_unittests to service_unittest. BUG= 722546 Review-Url: https://codereview.chromium.org/2885193002 Cr-Commit-Position: refs/heads/master@{#473675} [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/demo/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/ime/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/ime/ime_unittest.cc [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/ime/test_manifest.json [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/input_devices/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/public/cpp/tests/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/public/interfaces/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/services/ui/ws/BUILD.gn [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/testing/buildbot/chromium.linux.json [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/testing/buildbot/chromium.win.json [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/0dd1838e7333e0b81bc5ef5e42b6f629459aa7ee/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/965f939c0b2db8ecb2b7afd607f2b161d8872c06 commit 965f939c0b2db8ecb2b7afd607f2b161d8872c06 Author: erg <erg@chromium.org> Date: Mon May 22 23:12:20 2017 Remove navigation_service_unittests, along with the service itself. Also removes everything that depends on it, including its inclusion in chrome, where it was never used, along with two subdirectories in mash/, which appeared to be defunct. BUG= 722546 Review-Url: https://codereview.chromium.org/2901613002 Cr-Commit-Position: refs/heads/master@{#473735} [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/BUILD.gn [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/content/shell/BUILD.gn [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/content/shell/browser/DEPS [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/mash/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/DEPS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/browser.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/browser.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/debug_view.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/debug_view.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/main.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/manifest.json [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/public/interfaces/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/public/interfaces/OWNERS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/browser/public/interfaces/constants.mojom [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/DEPS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/main.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/manifest.json [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/public/interfaces/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/public/interfaces/OWNERS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/public/interfaces/constants.mojom [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/webtest.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/mash/webtest/webtest.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/DEPS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/OWNERS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/README.md [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/embedder_manifest.json [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/manifest.json [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/navigation.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/navigation.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/navigation_unittest.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/cpp/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/cpp/view.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/cpp/view.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/cpp/view_delegate.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/cpp/view_observer.h [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/interfaces/BUILD.gn [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/interfaces/OWNERS [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/public/interfaces/view.mojom [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/unittest_manifest.json [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/view_impl.cc [delete] https://crrev.com/7265b1cc285ca137198ba1f2d75bfc649aa2c3a3/services/navigation/view_impl.h [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/testing/buildbot/chromium.linux.json [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/testing/buildbot/chromium.win.json [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/965f939c0b2db8ecb2b7afd607f2b161d8872c06/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab commit a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab Author: erg <erg@chromium.org> Date: Tue May 23 18:17:54 2017 Move more tests suites to services_unittests. Moves the tests in mus_gpu_unittests and resource_coordinator_unittest into services_unittests and remove references to the old targets. BUG= 722546 Review-Url: https://codereview.chromium.org/2901623002 Cr-Commit-Position: refs/heads/master@{#473983} [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/services/BUILD.gn [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/services/ui/gpu/BUILD.gn [rename] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/services/ui/gpu/test_manifest.json [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/testing/buildbot/chromium.linux.json [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/testing/buildbot/chromium.win.json [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/a5ac6b4b9fc2170c8edad07d6a7666674da7f9ab/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ce908eea615191798b109b4d67ce267421b69f6 commit 8ce908eea615191798b109b4d67ce267421b69f6 Author: erg <erg@chromium.org> Date: Thu May 25 19:06:12 2017 Move display_service_unittests to services_unittests. This adapts the service_test.gni template to take an optional test runner target which overrides the default services_manager test runner. It also reorganizes the service_manager test runner to be modular so tests can use their own base::TestSuite subclass while still using the rest of the initialization that run_all_service_tests provided. BUG= 722546 Review-Url: https://codereview.chromium.org/2897123004 Cr-Commit-Position: refs/heads/master@{#474740} [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/BUILD.gn [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/BUILD.gn [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/service_manager/public/cpp/test/BUILD.gn [add] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/service_manager/public/cpp/test/common_initialization.cc [add] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/service_manager/public/cpp/test/common_initialization.h [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/service_manager/public/cpp/test/run_all_service_tests.cc [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/service_manager/public/tools/test/service_test.gni [add] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/test/BUILD.gn [add] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/test/DEPS [rename] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/test/run_all_service_tests.cc [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/services/ui/display/BUILD.gn [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/8ce908eea615191798b109b4d67ce267421b69f6/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3d24ad5c4879b43f34cce80a66aa1317c233bc3 commit f3d24ad5c4879b43f34cce80a66aa1317c233bc3 Author: erg <erg@chromium.org> Date: Fri May 26 04:48:16 2017 Ensure the services gpu tests run with ozone. When I moved mus_gpu_unittests into service_unittests, I didn't copy the ozone initialization into the new test runner. BUG= 722546 Review-Url: https://codereview.chromium.org/2907663003 Cr-Commit-Position: refs/heads/master@{#474908} [modify] https://crrev.com/f3d24ad5c4879b43f34cce80a66aa1317c233bc3/services/test/BUILD.gn [modify] https://crrev.com/f3d24ad5c4879b43f34cce80a66aa1317c233bc3/services/test/run_all_service_tests.cc [modify] https://crrev.com/f3d24ad5c4879b43f34cce80a66aa1317c233bc3/services/ui/common/BUILD.gn [delete] https://crrev.com/10be211f21100f7e9a3069cdefff580ddd0ef544/services/ui/common/run_all_service_tests.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4218b99824379697944831c4fdef622848fbc26 commit f4218b99824379697944831c4fdef622848fbc26 Author: erg <erg@chromium.org> Date: Fri May 26 23:37:01 2017 Move ui_services_unittests into service_unittest. All //services/ui/ test targets have been eliminated. BUG= 722546 Review-Url: https://codereview.chromium.org/2903423003 Cr-Commit-Position: refs/heads/master@{#475188} [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/services/BUILD.gn [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/services/test/run_all_service_tests.cc [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/services/ui/public/cpp/tests/BUILD.gn [delete] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/services/ui/public/cpp/tests/run_all_unittests.cc [delete] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/services/ui/public/cpp/tests/window_server_test_suite.cc [delete] https://crrev.com/341337af9e7325e850cedacec0e9da958765dd83/services/ui/public/cpp/tests/window_server_test_suite.h [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/services/ui/ws/BUILD.gn [rename] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/services/ui/ws/test_manifest.json [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/services/ui/ws/window_server_service_test_base.cc [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/testing/buildbot/chromium.linux.json [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/testing/buildbot/chromium.win.json [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/f4218b99824379697944831c4fdef622848fbc26/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd559ca9b161b9bf1cf77b7f387faf4f6616c945 commit cd559ca9b161b9bf1cf77b7f387faf4f6616c945 Author: erg <erg@chromium.org> Date: Fri May 26 23:43:38 2017 Rename "service_unittests" -> "services_unittests". Test suites are supposed to have the same name as the directory they're in; also this test target doesn't test a single service, it tests multiple. BUG= 722546 Review-Url: https://codereview.chromium.org/2908843002 Cr-Commit-Position: refs/heads/master@{#475192} [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/BUILD.gn [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/services/BUILD.gn [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.android.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.gpu.fyi.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.linux.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.mac.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/chromium.win.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/cd559ca9b161b9bf1cf77b7f387faf4f6616c945/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2af81092b5b12048827c8610b5845aa8bf7a872 commit a2af81092b5b12048827c8610b5845aa8bf7a872 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Jun 22 00:34:51 2017 Deploy Win10 Release (Intel HD 630) bot. Also fix name of services_unittests. BUG=719580, 722546 NOTRY=true TBR=zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie513c39e294374551cbea9ab6a22740b7c47ba4d Reviewed-on: https://chromium-review.googlesource.com/544226 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#481376} [modify] https://crrev.com/a2af81092b5b12048827c8610b5845aa8bf7a872/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/a2af81092b5b12048827c8610b5845aa8bf7a872/testing/buildbot/chromium.gpu.fyi.json
Comment 1 by e...@chromium.org
, May 15 2017