New issue
Advanced search Search tips

Issue 722544 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Run mash_unittests as ash_unittests --mash, like ash_unittests --mus

Project Member Reported by jamescook@chromium.org, May 15 2017

Issue description

This came up in the meeting today, as part of the discussion on making mustash easier for non-team-members to develop:

https://docs.google.com/document/d/1rXhOnmOXiG_C319XerTfZJf-pg6jJx-qZs65ILfda-4/edit

This might involve moving some of the tests to a new target (maybe keep mash_unittests for that).

Jon, we picked you as a victim because you weren't in the room. :-) Thoughts?

I can help with this if needed.

 
Yeah I can take a look at this.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48

commit 8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48
Author: jonross <jonross@chromium.org>
Date: Tue May 30 20:03:42 2017

Setup ash_unittests --mash

Have ash_unittests handle the --mash flag by setting up the internal config to
be mash, as well as setting aura to be non-local.

Create filter of blacklisted tests.

Update bot configs for new test.

TEST=ash_unittests --mash
BUG= 722544 

Review-Url: https://codereview.chromium.org/2911213002
Cr-Commit-Position: refs/heads/master@{#475638}

[modify] https://crrev.com/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48/ash/test/ash_test_suite.cc
[modify] https://crrev.com/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/8d1a3c75e20c8bdc048d29a3020115d3ecdf0e48/testing/buildbot/filters/ash_unittests_mash.filter

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment