New issue
Advanced search Search tips

Issue 722541 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Can't access chromium_presubmit stdio logs on cq

Project Member Reported by msw@chromium.org, May 15 2017

Issue description

Can't access chromium_presubmit stdio logs on cq

I tried landing this patch:
  https://codereview.chromium.org/2878133002/
chromium_presubmit failed:
  http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/437277
I can't open the presubmit step stdio (hangs blank as long as I've waited...):
  https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F437277%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout

There's no indication of progress or outages other than "Rendering logs."
This is an annoying obstacle to my work.
 

Comment 1 by d...@chromium.org, May 15 2017

I just clicked the link and it loaded instantly. It's possible that you hit a viewer bug or that the log was delayed. Did you try refreshing? Was it reproducible? Did you look in the JavaScript console and see any errors?

I'm not sure if there's anything actionable ATM since I cannot reproduce and I have no additional data.
I'm having the same issue. I still can't load any log files, including the one from the opener. Another example.
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_rel_ng%2F445077%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout


Screen Shot 2017-05-15 at 4.37.06 PM.png
53.0 KB View Download
Screen Shot 2017-05-15 at 4.36.59 PM.png
131 KB View Download

Comment 3 by d...@chromium.org, May 15 2017

What's your browser revision?
Works on 60.0.3093.0, fails on 60.0.3100.0
Blockedon: 722637
Blockedon: -722637

Comment 7 by d...@chromium.org, May 16 2017

 Issue 722912  has been merged into this issue.

Comment 8 by sdy@chromium.org, May 16 2017

 Issue 722926  has been merged into this issue.

Comment 9 by d...@chromium.org, May 17 2017

Owner: d...@chromium.org
Status: Started (was: Untriaged)
I think this is actually a bug. I filed this to investigate:  crbug.com/723132 

Either way, I'll commit and roll out a workaround.
Project Member

Comment 10 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/205d5943440077441f141c12f2b0e6d54dc6a26d

commit 205d5943440077441f141c12f2b0e6d54dc6a26d
Author: dnj <dnj@chromium.org>
Date: Wed May 17 00:33:19 2017

Fix LogDog viewer in unstable Chrome.

Address a possible bug in upstream Chrome JavaScript engine that
caused incorrect binding of "this". We fix this by coding the
"appendBlock" function as a formal member function instead of an inline
arrow function.

BUG= chromium:722541 
TEST=local
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2886873004

[modify] https://crrev.com/205d5943440077441f141c12f2b0e6d54dc6a26d/web/inc/logdog-stream-view/model.ts

Comment 11 by d...@chromium.org, May 17 2017

Workaround the V8 potential-bug has been pushed. Can any reporters verify?

Comment 12 by msw@chromium.org, May 17 2017

All logs have been loading just fine for me since your first comment, thanks!
My chrome is: 60.0.3100.0 (Official Build) canary (64-bit) (cohort: 64-Bit)

Comment 13 by d...@chromium.org, May 17 2017

Status: Fixed (was: Started)
Great!

Sign in to add a comment