New issue
Advanced search Search tips

Issue 722539 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make use_ozone the default for target_os="chromeos" for developers

Project Member Reported by jamescook@chromium.org, May 15 2017

Issue description

I think the bots already have an explicit use_ozone=false. See kylechar's recent CLs.

Making it the default will make things easier for non-mustash developers, since chrome --mash will work out of the box.

 

Comment 1 by sky@chromium.org, May 18 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03964155ee6907576b1b1ece4db4b477751e4933

commit 03964155ee6907576b1b1ece4db4b477751e4933
Author: sky <sky@chromium.org>
Date: Fri May 19 17:46:32 2017

chromeos: make ozone the default

X11 is no longer used on any machines and X11 for chromeos will soon be removed entirely. So, switch the default for chromeos to use_ozone. All the builders explicitly specify what config they want, so there shouldn't be any changes needed there.

BUG= 722539 
TEST=none
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2895523002
Cr-Commit-Position: refs/heads/master@{#473237}

[modify] https://crrev.com/03964155ee6907576b1b1ece4db4b477751e4933/build/config/ui.gni

Comment 3 by sky@chromium.org, May 19 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d3a20bbd7d11217380cfcd267e4593eda5fe36

commit 86d3a20bbd7d11217380cfcd267e4593eda5fe36
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Thu Aug 10 05:33:51 2017

Remove obsolete use_ozone comment

use_ozone defaults true in Chrome OS as of
https://codereview.chromium.org/2895523002 and fuschia as of
https://chromium-review.googlesource.com/c/609086.

Remove the comment, it was self-evident when it was accurate anyway.

Bug:  722539 
Change-Id: I2c084417b1aba01f264ec572ffc33f12e7c7719a
Reviewed-on: https://chromium-review.googlesource.com/609543
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493280}
[modify] https://crrev.com/86d3a20bbd7d11217380cfcd267e4593eda5fe36/build/config/ui.gni

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment