New issue
Advanced search Search tips

Issue 722497 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: /LayoutTests/inspector/console/console-copy-truncated-text.html fails

Project Member Reported by l...@chromium.org, May 15 2017

Issue description

A recent test seems to fail bots, but errors were not caught early enough.

Originally introduced here:
https://codereview.chromium.org/2644753002/

We should fix this test and re-add it.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46ab10923ea52c1e02980027a5e098ae25e904b7

commit 46ab10923ea52c1e02980027a5e098ae25e904b7
Author: luoe <luoe@chromium.org>
Date: Wed Jun 07 23:52:09 2017

DevTools: fix offset condition in console viewport _selectedText and add tests

When selecting non-truncated text, the selection start offset == 1 and the
selected node has text length > 1, the viewport would return incorrect values
for _selectedText(). It should only use the untruncated offset when it differs
from the node's rendered text length.

This CL corrects the condition and adds tests for other cases.

BUG= 722497 

Review-Url: https://codereview.chromium.org/2900733003
Cr-Commit-Position: refs/heads/master@{#477809}

[add] https://crrev.com/46ab10923ea52c1e02980027a5e098ae25e904b7/third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text-expected.txt
[add] https://crrev.com/46ab10923ea52c1e02980027a5e098ae25e904b7/third_party/WebKit/LayoutTests/inspector/console/console-copy-truncated-text.html
[modify] https://crrev.com/46ab10923ea52c1e02980027a5e098ae25e904b7/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewport.js

Comment 2 by l...@chromium.org, Jul 7 2017

Status: Fixed (was: Assigned)

Sign in to add a comment