New issue
Advanced search Search tips

Issue 722482 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 705071



Sign in to add a comment

security_RuntimeExecStack fails for ARM when using compiler-rt

Project Member Reported by manojgupta@chromium.org, May 15 2017

Issue description

Arm images have executable stack warnings with compiler-rt. 
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/release/builds/11336
 
Sent patch for upstream review.
https://reviews.llvm.org/D33211
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/911b59605fc781ac77d2ff51a8f78284d34cee35

commit 911b59605fc781ac77d2ff51a8f78284d34cee35
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed May 17 18:54:14 2017

Fix executable stack issue with compiler-rt object files.

Cherry-pick upstream fix to disable executable stack for
some assembly files in compiler-rt.
Cherry-pick fixes for aapcs ABI in compiler-rt for ARM.

Does not impact current llvm since libgcc is used right now
for builtins.

BUG= chromium:722482 
TEST=security_RuntimeExecStack fails are fixed.

Change-Id: I6b7fef64466afc1846411f995752bd7ac20ad708
Reviewed-on: https://chromium-review.googlesource.com/506240
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/compiler-rt-5.0_pre300080-r4.ebuild
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-devel/llvm/files/cherry/96eed06b6e57a3c8e2593e73d6f33bdd407f43b9.patch
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/96eed06b6e57a3c8e2593e73d6f33bdd407f43b9.patch
[delete] https://crrev.com/9e48b0b9f35a0a5b8d47a1a7fc5d75197effc97c/sys-libs/compiler-rt/files/compiler-rt-arm-aapcs-abi.patch
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/e60a00c0dfb05bad4912315912b70fa35050a058.patch
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/c74078b0a058c70de3504cb2533352ee48e71836.patch
[rename] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-devel/llvm/llvm-5.0_pre300080-r5.ebuild
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/99e2e66daf8d334858cec4f6e8e7a39d6a535a55.patch

Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/911b59605fc781ac77d2ff51a8f78284d34cee35

commit 911b59605fc781ac77d2ff51a8f78284d34cee35
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed May 17 18:54:14 2017

Fix executable stack issue with compiler-rt object files.

Cherry-pick upstream fix to disable executable stack for
some assembly files in compiler-rt.
Cherry-pick fixes for aapcs ABI in compiler-rt for ARM.

Does not impact current llvm since libgcc is used right now
for builtins.

BUG= chromium:722482 
TEST=security_RuntimeExecStack fails are fixed.

Change-Id: I6b7fef64466afc1846411f995752bd7ac20ad708
Reviewed-on: https://chromium-review.googlesource.com/506240
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/compiler-rt-5.0_pre300080-r4.ebuild
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-devel/llvm/files/cherry/96eed06b6e57a3c8e2593e73d6f33bdd407f43b9.patch
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/96eed06b6e57a3c8e2593e73d6f33bdd407f43b9.patch
[delete] https://crrev.com/9e48b0b9f35a0a5b8d47a1a7fc5d75197effc97c/sys-libs/compiler-rt/files/compiler-rt-arm-aapcs-abi.patch
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/e60a00c0dfb05bad4912315912b70fa35050a058.patch
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/c74078b0a058c70de3504cb2533352ee48e71836.patch
[rename] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-devel/llvm/llvm-5.0_pre300080-r5.ebuild
[add] https://crrev.com/911b59605fc781ac77d2ff51a8f78284d34cee35/sys-libs/compiler-rt/files/cherry/99e2e66daf8d334858cec4f6e8e7a39d6a535a55.patch

Status: Fixed (was: Untriaged)
Status: Verified (was: Fixed)
Labels: compiler-rt-migration

Sign in to add a comment