New issue
Advanced search Search tips

Issue 722470 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add Noto Serif CJK and drop licensed Serif (C+J) fonts

Project Member Reported by js...@chromium.org, May 15 2017

Issue description

Noto Serif CJK is released. Add it to CrOS and drop licensed Chinese and Japanese fonts. 




 

Comment 1 by js...@chromium.org, May 15 2017

Cc: yusukes@chromium.org
Owner: js...@chromium.org
Status: Started (was: Untriaged)
Cool. Can this be M-60 (the current milestone)?
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/cae60da0a92bf7e81c503939272479e89c2e019e

commit cae60da0a92bf7e81c503939272479e89c2e019e
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jul 19 13:12:14 2017

Add aliases mapping Windows CJ fonts to Noto Serif CJK

CrOS will have Noto Serif CJK as the default serif fonts for CJK.
Aliases in Skia need to be updated.

See https://chromium-review.googlesource.com/c/576708/ and
    https://chromium-review.googlesource.com/c/576789/

BUG= chromium:722470 
TEST=With all the related CLs in, Noto Serif CJK {JP,SC,TC} are used
when MS (P)Mincho,(N)Simsun,(P)MingLiu are requested.

Change-Id: I8340c2b460671c0b2854360a89b051e0e9e8d57c
Reviewed-on: https://skia-review.googlesource.com/24521
Commit-Queue: Ben Wagner <bungeman@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/cae60da0a92bf7e81c503939272479e89c2e019e/src/ports/SkFontConfigInterface_direct.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a76b1d6d66b131e3ead86d85dafcb6c6d2c7545

commit 7a76b1d6d66b131e3ead86d85dafcb6c6d2c7545
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Wed Jul 19 16:51:00 2017

Roll src/third_party/skia/ 5af44defb..925f52d03 (12 commits)

https://skia.googlesource.com/skia.git/+log/5af44defbd5f..925f52d03b73

$ git log 5af44defb..925f52d03 --date=short --no-merges --format='%ad %ae %s'
2017-07-19 ethannicholas fixed SPIR-V int->uint conversion
2017-07-14 bsalomon Remove GrAnalyticRectOp, the last legacy GrMeshDrawOp
2017-07-19 reed experimental: draw into unpremul
2017-07-19 reed remove google3 colortable flag
2017-07-19 fmalita Singleton SRGB color filters
2017-07-19 egdaniel Add blacklist to vk win intel for skp
2017-07-19 halcanary SkPDF: Fix color glyphs with absolute positioning
2017-07-18 scroggo Report first GIF frame after knowing its meta data
2017-07-19 rmistry Download material design SVGs from Google Storage
2017-07-18 brianosman Some basic Flutter/Fuchsia docs
2017-07-18 jshin Add aliases mapping Windows CJ fonts to Noto Serif CJK
2017-07-18 bsalomon Revert "Revert "Make GrAtlasTextOp a non-legacy GrMeshDrawOp""

Created with:
  roll-dep src/third_party/skia
BUG= 617403 , 722470 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I75eac4d2db0d0c21b05c5561ad44556fb25dcf8f
Reviewed-on: https://chromium-review.googlesource.com/577769
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487889}
[modify] https://crrev.com/7a76b1d6d66b131e3ead86d85dafcb6c6d2c7545/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94

commit 0ed4a0bf3e59dbc59d4470b456b8d018a797ab94
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Jul 25 22:08:07 2017

Update font prefs to use Noto Serif CJK on CrOS

Noto Serif CJK was released a few months ago and CrOS is getting them.
Use Noto Serif CJK instead of 3rd party CJK Serif fonts.

Related CLs:
  https://chromium-review.googlesource.com/c/576708
  https://skia-review.googlesource.com/c/24521/
  https://chrome-internal-review.googlesource.com/c/414228/

BUG= chromium:722470 
TEST=In CJK locales, the default serif font is Noto Serif CJK.

Change-Id: I41e831d67ea725f91c6682a9a388a153ca5c3d73
Reviewed-on: https://chromium-review.googlesource.com/576789
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Pam Greene (Please send IM for reviews) <pam@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489459}
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/locale_settings_chromiumos.grd
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/locale_settings_google_chromeos.grd
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/app/resources/platform_locale_settings/locale_settings_linux_ko.xtb
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/chrome/test/data/profiles/web_prefs/Default/Preferences
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/third_party/google_input_tools/README.chromium
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/third_party/google_input_tools/src/chrome/os/inputview/common.css
[modify] https://crrev.com/0ed4a0bf3e59dbc59d4470b456b8d018a797ab94/ui/chromeos/ime/candidate_window_constants.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/229c8f27eb9f110c9319f959732c1e3d6b263b2d

commit 229c8f27eb9f110c9319f959732c1e3d6b263b2d
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jul 26 23:46:49 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e7df4f91433dd214cdad9ce6ba5a613526178b9e

commit e7df4f91433dd214cdad9ce6ba5a613526178b9e
Author: Jungshik Shin <jshin@chromium.org>
Date: Wed Jul 26 23:46:49 2017

Update Noto CJK and drop Nanum Myeongjo

- Add Noto Sans CJK Light 1.004 in addition to the current 2 weights
  (+17,509,408).
- Add Noto Serif CJK 1.001 [1]: 3 weights (+75,345,168).
- Drop Nanum Myeongjo & Update Nanum Gothic to 3.20 (-8,452,328).
- Update fontconfig aliases and hint settings for Noto CJK.
- Update font directory lists in fontconfig's local.conf for fontcache
  generation.

This CL will be landed together with another CL to drop
Motoya/IPA fonts (-37,011,780) and Chinese Serif fonts licensed from Monotype
(-49,761,676).

The net size impact of the two CLs will be the decrease of 2,229,012 bytes.

Related CLs:
   https://skia-review.googlesource.com/c/24521/
   https://chrome-internal-review.googlesource.com/c/414228/
   https://chromium-review.googlesource.com/c/576789/

CQ-DEPEND=CL:*414228

[1]
https://developers.googleblog.com/2017/04/noto-serif-cjk-is-here.html

BUG= chromium:722470 
TEST=Noto Serif CJK fonts are used for serif in CJK locales.

Change-Id: If30b4b4712c6aa59dc55233656e4e32d7c3203a4
Reviewed-on: https://chromium-review.googlesource.com/576708
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-fonts/noto-cjk/noto-cjk-20170501.ebuild
[modify] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1.ebuild
[modify] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-fonts/noto-cjk/Manifest
[delete] https://crrev.com/bc25a902690b60562c208cde13df787cf670b81c/media-fonts/noto-cjk/noto-cjk-20150910-r1.ebuild
[rename] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-fonts/ko-nanumfonts/ko-nanumfonts-3.20.ebuild
[rename] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-libs/fontconfig/fontconfig-2.11.1-r19.ebuild
[modify] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-fonts/ko-nanumfonts/Manifest
[modify] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-libs/fontconfig/files/local.conf
[add] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/media-fonts/noto-cjk/noto-cjk-20170501-r1.ebuild
[rename] https://crrev.com/e7df4f91433dd214cdad9ce6ba5a613526178b9e/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1-r27.ebuild

Comment 8 by js...@chromium.org, Jul 27 2017

Labels: M-61
Status: Fixed (was: Started)
Fixed in ToT. Wait for a couple of days and ask for merge to M61 branch.

Comment 9 by js...@chromium.org, Jul 31 2017

Labels: Merge-Request-61
Verified on Canary. Asking for merge to 61 branch. 

CLs to merge to 61 branch are:

   https://chromium-review.googlesource.com/576708
   https://chrome-internal-review.googlesource.com/c/414228/
   https://chromium-review.googlesource.com/c/576789/

They're font update (to use Google's own Noto Serif CJK instead of 3rd party fonts) and font preference updates. So, they should be very safe. 

Skia was rolled to include this CL before the 61 branch cut. 
https://skia-review.googlesource.com/c/24521/ 
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 31 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 35 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Merge approved for M61 Chrome OS.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/81b8e3d6fa0501fa292ad43913a5ef713ca109ef

commit 81b8e3d6fa0501fa292ad43913a5ef713ca109ef
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Aug 01 16:29:23 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/16dbca2a48b23d0ba524ce19c4dc6add62e833ce

commit 16dbca2a48b23d0ba524ce19c4dc6add62e833ce
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Aug 01 16:29:26 2017

[R61 branch] Update Noto CJK and drop Nanum Myeongjo

- Add Noto Sans CJK Light 1.004 in addition to the current 2 weights
  (+17,509,408).
- Add Noto Serif CJK 1.001 [1]: 3 weights (+75,345,168).
- Drop Nanum Myeongjo & Update Nanum Gothic to 3.20 (-8,452,328).
- Update fontconfig aliases and hint settings for Noto CJK.
- Update font directory lists in fontconfig's local.conf for fontcache
  generation.

This CL will be landed together with another CL to drop
Motoya/IPA fonts (-37,011,780) and Chinese Serif fonts licensed from Monotype
(-49,761,676).

The net size impact of the two CLs will be the decrease of 2,229,012 bytes.

Related CLs:
   https://skia-review.googlesource.com/c/24521/
   https://chrome-internal-review.googlesource.com/c/414228/
   https://chromium-review.googlesource.com/c/576789/

CQ-DEPEND=CL:*422032

[1]
https://developers.googleblog.com/2017/04/noto-serif-cjk-is-here.html

BUG= chromium:722470 
TEST=Noto Serif CJK fonts are used for serif in CJK locales.

Change-Id: If30b4b4712c6aa59dc55233656e4e32d7c3203a4
Reviewed-on: https://chromium-review.googlesource.com/576708
Commit-Ready: Jungshik Shin <jshin@chromium.org>
Tested-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit e7df4f91433dd214cdad9ce6ba5a613526178b9e)
Reviewed-on: https://chromium-review.googlesource.com/595225
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>

[rename] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-fonts/noto-cjk/noto-cjk-20170501.ebuild
[modify] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1.ebuild
[modify] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-fonts/noto-cjk/Manifest
[delete] https://crrev.com/3b5db7ff686e9bc9d34d3e7738246cfd8736dd6b/media-fonts/noto-cjk/noto-cjk-20150910-r1.ebuild
[rename] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-fonts/ko-nanumfonts/ko-nanumfonts-3.20.ebuild
[rename] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-libs/fontconfig/fontconfig-2.11.1-r19.ebuild
[modify] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-fonts/ko-nanumfonts/Manifest
[modify] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-libs/fontconfig/files/local.conf
[add] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/media-fonts/noto-cjk/noto-cjk-20170501-r1.ebuild
[rename] https://crrev.com/16dbca2a48b23d0ba524ce19c4dc6add62e833ce/chromeos-base/chromeos-fonts/chromeos-fonts-0.0.1-r27.ebuild

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837

commit 7dbb61cd6e3e9d7d03b4cba144cbede4194d3837
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Aug 01 17:47:58 2017

[M61 branch] Update font prefs to use Noto Serif CJK on CrOS

Noto Serif CJK was released a few months ago and CrOS is getting them.
Use Noto Serif CJK instead of 3rd party CJK Serif fonts.

Related CLs:
  https://chromium-review.googlesource.com/c/576708
  https://skia-review.googlesource.com/c/24521/
  https://chrome-internal-review.googlesource.com/c/414228/

BUG= chromium:722470 
TEST=In CJK locales, the default serif font is Noto Serif CJK.
TBR=jshin@chromium.org

(cherry picked from commit 0ed4a0bf3e59dbc59d4470b456b8d018a797ab94)

Change-Id: I41e831d67ea725f91c6682a9a388a153ca5c3d73
Reviewed-on: https://chromium-review.googlesource.com/576789
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Pam Greene (Please send IM for reviews) <pam@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489459}
Reviewed-on: https://chromium-review.googlesource.com/595204
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#212}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/locale_settings_chromiumos.grd
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/locale_settings_google_chromeos.grd
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/platform_locale_settings/locale_settings_cros_ja.xtb
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/platform_locale_settings/locale_settings_cros_ko.xtb
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-CN.xtb
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/platform_locale_settings/locale_settings_cros_zh-TW.xtb
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/app/resources/platform_locale_settings/locale_settings_linux_ko.xtb
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/chrome/test/data/profiles/web_prefs/Default/Preferences
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/third_party/google_input_tools/README.chromium
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/third_party/google_input_tools/src/chrome/os/inputview/common.css
[modify] https://crrev.com/7dbb61cd6e3e9d7d03b4cba144cbede4194d3837/ui/chromeos/ime/candidate_window_constants.h

Issue 716242 has been merged into this issue.

Comment 16 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment