New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722467 link

Starred by 1 user
Status: Assigned
Owner:
█ dim...@chromium.org
Last visit > 30 days ago
Cc:
dewittj@chromium.org
fgor...@chromium.org
█ chili@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 654635



Sign in to add a comment

Split off the cross-platform part of Offline Pages

Project Member Reported by dim...@chromium.org, May 15 2017 
Currently, Offline Pages live in 2 locations:

- component/offline_pages
- chrome/browser/android/offline_pages

The latter is needed to hook up the component to the UI and other browser-dependent things. Most of this code is not Android-specific and thus does nto have to live in c/b/a. Furthermore, over time it takes infusions of really Android-specific code which is bad, and it also prevents OfflinePages from being potentially implemented on other platforms.

In order to improve layering, the following can be done:
- create c/b/offline_pages
- move most of the code form c/b/a/o_p -> c/b/o_p, split Android-specific code into smaller platform parts.
- create c/b/offline_pages/android for those remaining android dependencies.
- [maybe] remove c/b/a/o_p

Comment 1 by chili@chromium.org, May 15 2017 

This is the remaining part of crbug/654635

should i merge that into this one?
Project Member

Comment 2 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f

commit d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f
Author: dimich <dimich@chromium.org>
Date: Tue May 16 21:36:48 2017

Create chrome/browser/offline_pages to host browser-related parts of offline_pages which
are currently in c/b/android/offline_pages but are not Android-dependent.
This is to avoid mixing of Android-specific code with cross-platform and to
facilitate offline_pages on other platforms (like ChromeOS) in the future.

Also, move the first file there. Tighter DEPS will come in the next CL.

BUG=722467

Review-Url: https://codereview.chromium.org/2881223002
Cr-Commit-Position: refs/heads/master@{#472222}

[modify] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/BUILD.gn
[modify] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/android/offline_pages/request_coordinator_factory.cc
[modify] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[add] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/offline_pages/DEPS
[add] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/offline_pages/OWNERS
[rename] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/offline_pages/background_loader_offliner.cc
[rename] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/offline_pages/background_loader_offliner.h
[rename] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/d733a613d2e4faddc4c3a0e5cac907fc9a4aef7f/chrome/test/BUILD.gn

Comment 3 by dim...@chromium.org, May 16 2017

Blocking: 654635
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91494853f713cfb11c13ba2720689e6288639e4e

commit 91494853f713cfb11c13ba2720689e6288639e4e
Author: dimich <dimich@chromium.org>
Date: Thu May 25 17:36:04 2017

Split Android-specific dependency from BackgroundLoaderOffliner. Create a subfolder of c/b/offline_pages which will contain
Android-specific code. Update DEPS files.

BUG=722467

Review-Url: https://codereview.chromium.org/2898393002
Cr-Commit-Position: refs/heads/master@{#474687}

[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/BUILD.gn
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/android/offline_pages/request_coordinator_factory.cc
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/DEPS
[add] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/android/DEPS
[add] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/android/load_termination_listener_impl.cc
[add] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/android/load_termination_listener_impl.h
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/components/offline_pages/core/background/BUILD.gn
[add] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/components/offline_pages/core/background/load_termination_listener.h
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/components/offline_pages/core/background/offliner_stub.cc
[modify] https://crrev.com/91494853f713cfb11c13ba2720689e6288639e4e/components/offline_pages/core/background/offliner_stub.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8d6fb54b9f0f98750963fecf3275df74dec37d7

commit d8d6fb54b9f0f98750963fecf3275df74dec37d7
Author: Dmitry Titov <dimich@chromium.org>
Date: Tue May 30 21:35:35 2017

Correct typos, follow-up to https://codereview.chromium.org/2898393002/

Bug: 722467
Change-Id: Ib6008d706d848ca0ae75d70f02c106253d94ca91
Reviewed-on: https://chromium-review.googlesource.com/516782
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475680}
[modify] https://crrev.com/d8d6fb54b9f0f98750963fecf3275df74dec37d7/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/d8d6fb54b9f0f98750963fecf3275df74dec37d7/chrome/browser/offline_pages/android/DEPS
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e632ebc8577a1f6c2848eddb139e29b15ce2393b

commit e632ebc8577a1f6c2848eddb139e29b15ce2393b
Author: Jian Li <jianli@chromium.org>
Date: Fri Jun 30 23:40:32 2017

Move OfflinePageModelFactory to platform independent directory

BUG=722467
TBR=thestig@chromium.org

Change-Id: Id65c57f70359cbeed6b2d5a92993dab12eebf3e1
Reviewed-on: https://chromium-review.googlesource.com/558525
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483863}
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/BUILD.gn
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/background_scheduler_bridge.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/offline_page_bookmark_observer.h
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/android/offline_pages/request_coordinator_factory.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_factory.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[rename] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/offline_pages/offline_page_model_factory.cc
[rename] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/offline_pages/offline_page_model_factory.h
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/e632ebc8577a1f6c2848eddb139e29b15ce2393b/chrome/test/base/testing_profile.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1460702f07a158a82fa25de2be72de31f383b26

commit d1460702f07a158a82fa25de2be72de31f383b26
Author: Dmitry Titov <dimich@chromium.org>
Date: Thu Jul 13 01:25:49 2017

[Offline Pages] Move files without dependency on Android to os-independent folder.

This is ongoing refactoring of offline pages, in order to remove/isolate
Android-specific dependdencies. In this case, it's just a result
of:
tools/git/move_source_file.py chrome/browser/android/offline_pages/offline_page_bookmark_observer.* chrome/browser/offline_pages/

Bug: 722467
Change-Id: I35ecde79bee6b6fba7d7c27d75c5fb7be1799c00
Reviewed-on: https://chromium-review.googlesource.com/568565
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486202}
[modify] https://crrev.com/d1460702f07a158a82fa25de2be72de31f383b26/chrome/browser/BUILD.gn
[modify] https://crrev.com/d1460702f07a158a82fa25de2be72de31f383b26/chrome/browser/bookmarks/chrome_bookmark_client.cc
[rename] https://crrev.com/d1460702f07a158a82fa25de2be72de31f383b26/chrome/browser/offline_pages/offline_page_bookmark_observer.cc
[rename] https://crrev.com/d1460702f07a158a82fa25de2be72de31f383b26/chrome/browser/offline_pages/offline_page_bookmark_observer.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909e8d6100823c088e74f278d76b443fd928c25e

commit 909e8d6100823c088e74f278d76b443fd928c25e
Author: Dmitry Titov <dimich@chromium.org>
Date: Wed Jul 19 01:39:56 2017

[Offline Pages] Move files without dependency on Android to os-independent folder.

This is ongoing refactoring of offline pages, in order to remove/isolate
Android-specific dependencies. In this case, it's just a result
of running tools/git/move_source_file.py on a few files.

Also,
#if defined(OS_ANDROID)
changed to:
#if BUILDFLAG(ENABLE_OFFLINE_PAGES)
Since those are currently defined in sync, the result should be exactly no
change for all build targets.

Also, OfflinePageUtils is split to platform-independent part and a small
android-only implementation, now in offline_pages_utils_android.cc

Bug: 722467
Change-Id: Ib1384e97f7f2bc5e5d88ecf889e2942f0ac02342
Reviewed-on: https://chromium-review.googlesource.com/571683
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487713}
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/BUILD.gn
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/BUILD.gn
[delete] https://crrev.com/85a2dce7b025bb27313a6a45b2d63ef413fae39f/chrome/browser/android/offline_pages/BUILD.gn
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/android/offline_pages/downloads/resource_throttle.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/browsing_data/cache_counter.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/net/net_error_tab_helper.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/net/net_error_tab_helper_unittest.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/DEPS
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/DEPS
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/background_scheduler_bridge.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/background_scheduler_bridge.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/cct_request_observer.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/cct_request_observer.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/offline_page_bridge.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/offline_page_bridge.h
[add] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/offline_page_utils_android.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/prerendering_offliner.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/prerendering_offliner.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/prerendering_offliner_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/android/request_coordinator_factory.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_info_handler.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_info_handler.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_mhtml_archiver.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_request_interceptor.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_request_interceptor.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_request_job.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_request_job.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_request_job_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_tab_helper.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_tab_helper.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_tab_helper_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_utils.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_utils.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offliner_helper.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/offliner_helper.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/prerender_adapter.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/prerender_adapter.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/prerender_adapter_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/prerendering_loader.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/prerendering_loader.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/prerendering_loader_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/recent_tab_helper.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/recent_tab_helper.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/recent_tab_helper_unittest.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/request_coordinator_factory.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/test_offline_page_model_builder.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/test_offline_page_model_builder.h
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/test_request_coordinator_builder.cc
[rename] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/offline_pages/test_request_coordinator_builder.h
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/909e8d6100823c088e74f278d76b443fd928c25e/chrome/test/BUILD.gn
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5145c5b10f5c5c8514ddee956d0529411e1b381

commit d5145c5b10f5c5c8514ddee956d0529411e1b381
Author: Yafei Duan <romax@chromium.org>
Date: Fri Aug 25 21:47:08 2017

[Offline Pages] Move more files out of c/b/a/offline_pages.

Cleared chrome/browser/android/offline_pages, and moved corresponding
files to chrome/browser/offline_pages/android. Modified related build
files and includes.
Also changed in BUILD.gn that enable_offline_page_harness will not build
anything unless enable_offline_page is enabled as well.

Bug: 722467
Change-Id: I8ac53e897026aa71481f2602a11f15dd25c71291
Reviewed-on: https://chromium-review.googlesource.com/627239
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497548}
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/BUILD.gn
[delete] https://crrev.com/fe2f08ca01f71d646ae17fa81817bb8c5571a194/chrome/browser/android/offline_pages/DEPS
[delete] https://crrev.com/fe2f08ca01f71d646ae17fa81817bb8c5571a194/chrome/browser/android/offline_pages/OWNERS
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/bookmarks/chrome_bookmark_client.h
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/DEPS
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/DEPS
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/downloads/offline_page_download_bridge.h
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/downloads/offline_page_infobar_delegate.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/downloads/offline_page_infobar_delegate.h
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/downloads/offline_page_notification_bridge.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/downloads/offline_page_notification_bridge.h
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/evaluation/evaluation_test_scheduler.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/evaluation/evaluation_test_scheduler.h
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.h
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/evaluation/run_offline_page_evaluation_test.py
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/offline_page_model_factory.cc
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/offline_page_utils_android.cc
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/android/request_coordinator_factory.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/downloads/resource_throttle.cc
[rename] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/browser/offline_pages/downloads/resource_throttle.h
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/common/BUILD.gn
[modify] https://crrev.com/d5145c5b10f5c5c8514ddee956d0529411e1b381/chrome/common/render_messages.h
►

Sign in to add a comment