New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722464 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chaps: failed to build on asan-builder.

Project Member Reported by yunlian@chromium.org, May 15 2017

Issue description

chaps-0.0.1-r1974: ninja: Entering directory `/build/amd64-generic/var/cache/portage/chromeos-base/chaps/out/Default'
chaps-0.0.1-r1974: 
chaps-0.0.1-r1974: [0/2] SOLINK lib/libchaps.so
chaps-0.0.1-r1974: [1/2] SOLINK lib/libchaps.so
chaps-0.0.1-r1974: FAILED: lib/libchaps.so lib/libchaps.so.TOC 
chaps-0.0.1-r1974: if [ ! -e lib/libchaps.so -o ! -e lib/libchaps.so.TOC ]; then flock linker.lock x86_64-cros-linux-gnu-clang++ -shared -Wl,-O1 -Wl,-O2 -Wl,--as-needed -fsanitize=address -fsanitize=alignment -fsanitize=shift -Wl,-z,relro -Wl,-z,noexecstack -Wl,-z,now -Wl,--as-needed --sysroot=/build/amd64-generic -pthread -o lib/libchaps.so -Wl,-soname=libchaps.so -Wl,--whole-archive obj/chaps/libchaps.attributes.o obj/chaps/libchaps.chaps.o obj/chaps/libchaps.chaps_proxy.o obj/chaps/libchaps.chaps_utility.o obj/chaps/libchaps.isolate_chromeos.o obj/chaps/libchaps.proto_conversion.o obj/chaps/libchaps.token_manager_client.o obj/chaps/libchaps-protos.a  -Wl,--no-whole-archive -ldbus-c++-1 -ldbus-1 -lsystem_api-power_manager-protos -lsystem_api-cryptohome-protos -lsystem_api-authpolicy-protos -lsystem_api-biod-protos -lsystem_api-protos -lsystem_api-login_manager-protos -lsystem_api-chaps-protos -lprotobuf-lite -lpthread -lssl -lcrypto -lbrillo-395517 -lbase-395517 && { readelf -d lib/libchaps.so | grep SONAME ; nm -gD -f p lib/libchaps.so | cut -f1-2 -d' '; } > lib/libchaps.so.TOC; else flock linker.lock x86_64-cros-linux-gnu-clang++ -shared -Wl,-O1 -Wl,-O2 -Wl,--as-needed -fsanitize=address -fsanitize=alignment -fsanitize=shift -Wl,-z,relro -Wl,-z,noexecstack -Wl,-z,now -Wl,--as-needed --sysroot=/build/amd64-generic -pthread -o lib/libchaps.so -Wl,-soname=libchaps.so -Wl,--whole-archive obj/chaps/libchaps.attributes.o obj/chaps/libchaps.chaps.o obj/chaps/libchaps.chaps_proxy.o obj/chaps/libchaps.chaps_utility.o obj/chaps/libchaps.isolate_chromeos.o obj/chaps/libchaps.proto_conversion.o obj/chaps/libchaps.token_manager_client.o obj/chaps/libchaps-protos.a  -Wl,--no-whole-archive -ldbus-c++-1 -ldbus-1 -lsystem_api-power_manager-protos -lsystem_api-cryptohome-protos -lsystem_api-authpolicy-protos -lsystem_api-biod-protos -lsystem_api-protos -lsystem_api-login_manager-protos -lsystem_api-chaps-protos -lprotobuf-lite -lpthread -lssl -lcrypto -lbrillo-395517 -lbase-395517 && { readelf -d lib/libchaps.so | grep SONAME ; nm -gD -f p lib/libchaps.so | cut -f1-2 -d' '; } > lib/libchaps.so.tmp && if ! cmp -s lib/libchaps.so.tmp lib/libchaps.so.TOC; then mv lib/libchaps.so.tmp lib/libchaps.so.TOC ; fi; fi
chaps-0.0.1-r1974: /usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51/ld.gold.real: error: /build/amd64-generic/usr/lib/../lib64/libsystem_api-chaps-protos.a(system_api-chaps-protos.ck_structs.pb.o): requires dynamic R_X86_64_PC32 reloc against '_ZSt9make_pairIRjbESt4pairINSt17__decay_and_stripIT_E6__typeENS2_IT0_E6__typeEEOS3_OS6_' which may overflow at runtime; recompile with -fPIC
chaps-0.0.1-r1974: clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
chaps-0.0.1-r1974: ninja: build stopped: subcommand failed.
chaps-0.0.1-r1974: Traceback (most recent call last):
 
Owner: yunlian@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/1e05a1a9d22a6bd0179c7088a2c90fb432ea4c8f

commit 1e05a1a9d22a6bd0179c7088a2c90fb432ea4c8f
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri May 19 20:57:56 2017

system_api: use '-fPIC' for libsystem_api-chaps-protos.a

libsystem_api-chaps-protos.a is linked into a shared library,
so we should build it with -fPIC instead of -fPIE.

BUG= chromium:722464 
TEST=cbuildbot amd64-generic-asan, it builds fine.

Change-Id: I0f1409c4a10f5ccaf3d5303d6b315ae4c0f08c47
Reviewed-on: https://chromium-review.googlesource.com/506033
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1e05a1a9d22a6bd0179c7088a2c90fb432ea4c8f/system_api.gyp

Status: Verified (was: Started)

Sign in to add a comment