New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722461 link

Starred by 1 user
Status: Fixed
Owner:
mortonm@chromium.org
Closed: Jul 2017
Cc:
█ jialiul@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Rename zip_analyzer::Results to ArchiveAnalyzerResult

Project Member Reported by jialiul@chromium.org, May 15 2017 
zip_analyzer::Results are used by both zip_analyzer and dmg_analyzer. We want to rename it to ArchiveAnalyzerResult and put it in safe_browsing namespace.
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/099f5b20a46bc52066e9cbd2167d7747e59984cd

commit 099f5b20a46bc52066e9cbd2167d7747e59984cd
Author: mortonm <mortonm@google.com>
Date: Tue May 23 23:31:41 2017

Also moved archive_analyzer_results into the safebrowsing namespace.

BUG= 722461 

Review-Url: https://codereview.chromium.org/2900803002
Cr-Commit-Position: refs/heads/master@{#474102}

[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac.h
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac_unittest.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/sandboxed_zip_analyzer.h
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/browser/safe_browsing/sandboxed_zip_analyzer_unittest.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/BUILD.gn
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/chrome_utility_messages.h
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/safe_archive_analyzer.typemap
[add] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/safe_browsing/archive_analyzer_results.cc
[add] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/safe_browsing/archive_analyzer_results.h
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/safe_browsing/zip_analyzer.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/common/safe_browsing/zip_analyzer.h
[delete] https://crrev.com/dedb25685f8838221a1b68034d91460c32fd0467/chrome/common/safe_browsing/zip_analyzer_results.cc
[delete] https://crrev.com/dedb25685f8838221a1b68034d91460c32fd0467/chrome/common/safe_browsing/zip_analyzer_results.h
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/utility/safe_browsing/mac/dmg_analyzer.cc
[modify] https://crrev.com/099f5b20a46bc52066e9cbd2167d7747e59984cd/chrome/utility/safe_browsing/mac/dmg_analyzer.h

Comment 2 by mortonm@google.com, Jul 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment