New issue
Advanced search Search tips

Issue 722458 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove high/medium security on lock screen options in settings.

Project Member Reported by sammiequon@chromium.org, May 15 2017

Issue description

Security does not want to show users the level of security.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d2bac567d775397058622d6434702ede6c1d580

commit 0d2bac567d775397058622d6434702ede6c1d580
Author: sammiequon <sammiequon@chromium.org>
Date: Tue May 16 01:13:17 2017

md settings: Remove level of security indicator on lock screen.

Secuirty does not want users to know the level of security on their lock screen unlock method.

TEST=manual
BUG= 722458 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885503002
Cr-Commit-Position: refs/heads/master@{#471966}

[modify] https://crrev.com/0d2bac567d775397058622d6434702ede6c1d580/chrome/app/settings_strings.grdp
[modify] https://crrev.com/0d2bac567d775397058622d6434702ede6c1d580/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/0d2bac567d775397058622d6434702ede6c1d580/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/0d2bac567d775397058622d6434702ede6c1d580/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Labels: Merge-Request-59
Can you please mark which OS this change affects?
Labels: OS-Chrome

Comment 5 by gkihumba@google.com, May 16 2017

Labels: Merge-Approved-59
Project Member

Comment 6 by sheriffbot@chromium.org, May 17 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 19 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, May 17 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f7c39daf9f52ff4347c0817f9beb098ac319cad

commit 0f7c39daf9f52ff4347c0817f9beb098ac319cad
Author: Sammie Quon <sammiequon@google.com>
Date: Wed May 17 18:04:13 2017

[merge to m59]md settings: Remove level of security indicator on lock screen.

Secuirty does not want users to know the level of security on their lock screen unlock method.

TEST=manual
BUG= 722458 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2885503002
Cr-Original-Commit-Position: refs/heads/master@{#471966}
Review-Url: https://codereview.chromium.org/2889723004 .
Cr-Commit-Position: refs/branch-heads/3071@{#602}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/0f7c39daf9f52ff4347c0817f9beb098ac319cad/chrome/app/settings_strings.grdp
[modify] https://crrev.com/0f7c39daf9f52ff4347c0817f9beb098ac319cad/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/0f7c39daf9f52ff4347c0817f9beb098ac319cad/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/0f7c39daf9f52ff4347c0817f9beb098ac319cad/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
ChromeOS 9460.48.0, 59.0.3071.67

Sign in to add a comment