New issue
Advanced search Search tips

Issue 722453 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Create a build flag for GuestView

Project Member Reported by mcnee@chromium.org, May 15 2017

Issue description

Currently, GuestView callers are #ifdef'd behind ENABLE_EXTENSIONS and sometimes !OS_ANDROID. Although nothing outside of extensions currently uses GuestViews, it would be better to have GuestViews decoupled from extensions for clarity, consistency and to allow for potential GuestView usage on mobile (see also  crbug.com/444869  ).

We should add an ENABLE_GUESTVIEW build flag which can, for now, just be an alias for ENABLE_EXTENSIONS, and then update the caller #ifdefs and build files to use it.
 

Comment 1 by mcnee@chromium.org, May 30 2017

Actually, referencing extensions from //components/guest_view/ would be a layering violation. Perhaps it would be better to just define ENABLE_GUESTVIEW independently and then assert it from //extensions/.

Sign in to add a comment