New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722452 link

Starred by 1 user
Status: Fixed
Owner:
█ mad@chromium.org
Last visit 16 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Profiles created from autofill settings get wrong region list in the payment request shipping address editor

Project Member Reported by mad@chromium.org, May 15 2017 
Create an incomplete address (e.g., no phone number or postal/zip code) from the autofill settings and use any Country but the US.

Open a payment request and choose this address (it should open in the address editor, since it's incomplete).

Problem: The list of US states is shown in the combo box.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09f15955329247e16c8547119e326ac8f35a269c

commit 09f15955329247e16c8547119e326ac8f35a269c
Author: mad <mad@chromium.org>
Date: Thu May 18 06:33:58 2017

Payment request shipping address editor now properly handles countries

The autofill profile needs the country to be set before other fields so that they can be properly internaionalized.

And the country must be set using its internationalized name (as opposed to country code) when using the SetInfo method.

BUG= 722039 , 722452 

Review-Url: https://codereview.chromium.org/2883333003
Cr-Commit-Position: refs/heads/master@{#472708}

[modify] https://crrev.com/09f15955329247e16c8547119e326ac8f35a269c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/09f15955329247e16c8547119e326ac8f35a269c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/09f15955329247e16c8547119e326ac8f35a269c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Comment 2 by mad@chromium.org, May 18 2017

Status: Fixed (was: Started)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment