New issue
Advanced search Search tips

Issue 722436 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

When users clear their browsing history they should receive previews again (even if they recently opted out)

Project Member Reported by ryansturm@chromium.org, May 15 2017

Issue description

When the user clears history, recent opt outs (in the history timeout range) should be ignored.

Currently, the session recency rule (x minutes after an opt out, the user is not shown a preview, 5 minutes by default) is still enforced after clearing history.

Specifically, if the user clears more than x minutes of history and there are no opt outs after the range they are clearing, the recency rule should no longer apply.
 
Labels: -M-61 M-60
Project Member

Comment 2 by bugdroid1@chromium.org, May 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cd77228276c278c78ff13639d319fd9e7198752

commit 4cd77228276c278c78ff13639d319fd9e7198752
Author: ryansturm <ryansturm@chromium.org>
Date: Fri May 26 02:59:19 2017

If users clear history, the previews recency rule should be cleared

When a user clears a chunk of history, the recency rule (previews aren't
shown for ~5 minutes after an opt out). Should be reset if the chunk of
history is longer than 5 minutes.

BUG= 722436 

Review-Url: https://codereview.chromium.org/2878363004
Cr-Commit-Position: refs/heads/master@{#474890}

[modify] https://crrev.com/4cd77228276c278c78ff13639d319fd9e7198752/components/previews/core/previews_black_list.cc
[modify] https://crrev.com/4cd77228276c278c78ff13639d319fd9e7198752/components/previews/core/previews_black_list_unittest.cc

Status: Fixed (was: Started)

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment