New issue
Advanced search Search tips

Issue 722427 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Call onAbort with the proper parameter

Project Member Reported by anthonyvd@chromium.org, May 15 2017 
When Mojo's PaymentRequest.Abort() method is called, if the user is not on the CVC unmask screen, close the dialog and call Mojo's PaymentRequestClient.onAbort(true). If CVC unmask screen is open, don't close the dialog and call Mojo's onAbort(false).
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6813c144fa64c40521277681894db2526dba7ec3

commit 6813c144fa64c40521277681894db2526dba7ec3
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Wed May 17 21:07:02 2017

[Web Payments] Reject abort when required

Bug:  722427 
Change-Id: I262b166944cad827524b3828e0df53a500d99336
Reviewed-on: https://chromium-review.googlesource.com/506232
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472567}
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/components/payments/content/payment_request.cc
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/components/payments/content/payment_request.h
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/6813c144fa64c40521277681894db2526dba7ec3/components/payments/content/payment_request_state.h

Comment 2 by anthonyvd@chromium.org, May 17 2017

Status: Fixed (was: Started)

Comment 3 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment