Issue metadata
Sign in to add a comment
|
24kb regression in resource_sizes (MonochromePublic.apk) at 471382:471384 |
||||||||||||||||||||
Issue descriptionCaused by: Compile Skia image encoders https://codereview.chromium.org/2865363002
,
May 24 2017
,
May 25 2017
msarett@ - is this size jump expected? Anything we can do to decrease it? Sorry about the delay. Here's a size diff (created with //tools/binary_size) for reference:
Section Sizes (Total=22.6kb (23128 bytes)):
.bss: 32 bytes (32 bytes) (not included in totals)
.data: 0 bytes (0 bytes) (0.0%)
.data.rel.ro: 16 bytes (16 bytes) (0.1%)
.data.rel.ro.local: 48 bytes (48 bytes) (0.2%)
.rodata: 400 bytes (400 bytes) (1.7%)
.text: 22.1kb (22664 bytes) (98.0%)
108 symbols added (+), 403 changed (~), 1 removed (-), 381207 unchanged (not shown)
9 paths added, 1 removed, 395 changed
Showing 512 symbols (512 unique) with total pss: 20026 bytes
.text=19.1kb .rodata=400 bytes .data*=64 bytes .bss=16 bytes total=19.6kb
Number of unique paths: 408
Index, Running Total, Section@Address, PSS
------------------------------------------------------------
~ 0) -2073 (-10.4%) r@0x2cede30 -2073 net/cert/cert_database.cc
~ 1) -25 (-0.1%) r@0x2d7d388 2048 v8/src/json-stringifier.cc
~ 2) 2016 (10.1%) r@0x2cede58 2041 net/cert/ct_known_logs.cc
~ 3) -20 (-0.1%) r@0x2d7a070 -2036 v8/src/compiler/c-linkage.cc
+ 4) 1648 (8.2%) t@Group 1668 third_party/skia/src/images/{{shared}}/3
transform_scanline_565 (count=3)
+ 5) 3124 (15.6%) t@Group 1476 third_party/skia/src/images/{{shared}}/3
transform_scanline_444 (count=3)
~ 6) 1777 (8.9%) r@0x2d4ec18 -1347 net/websockets/websocket_inflater.cc
~ 7) 3121 (15.6%) r@0x2d4f318 1344 gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc
+ 8) 4193 (20.9%) t@Group 1072 third_party/skia/src/images/{{shared}}/2
transform_scanline_BGRX (count=2)
+ 9) 5265 (26.3%) t@Group 1072 third_party/skia/src/images/{{shared}}/2
transform_scanline_RGBX (count=2)
+ 10) 6233 (31.1%) t@0x6016b4 968 third_party/skia/src/images/SkWebpEncoder.cpp
do_encode
+ 11) 7045 (35.2%) t@0x17ac6d4 812 third_party/libwebp/mux/muxedit.c
WebPMuxAssemble
+ 12) 7813 (39.0%) r@0x2f6f120 768 third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/locale_android.o
+ 13) 8581 (42.8%) t@0x60001c 768 third_party/skia/src/images/SkPngEncoder.cpp
SkPngEncoderMgr::setPalette
+ 14) 9337 (46.6%) t@0x17ad20c 756 third_party/libwebp/mux/muxread.c
WebPMuxCreateInternal
~ 15) 8609 (43.0%) r@0x2e81ae8 -728 third_party/webrtc/p2p/base/tcpport.cc
~ 16) 9317 (46.5%) r@0x2e8f2a8 708 third_party/webrtc/pc/peerconnectionfactory.cc
+ 17) 9925 (49.6%) t@Group 608 third_party/skia/src/images/{{shared}}/2
transform_scanline_BGRA (count=2)
~ 18) 9373 (46.8%) d@0x315dd4c -552 blink/bindings/core/v8/V8CharacterData.cpp
+ 19) 9905 (49.5%) t@0x5feccc 532 third_party/skia/src/images/SkJpegEncoder.cpp
SkJpegEncoder::Make
+ 20) 10433 (52.1%) t@Group 528 third_party/skia/src/images/{{shared}}/2
choose_proc (count=2)
~ 21) 10953 (54.7%) d@0x315dd80 520 blink/bindings/core/v8/V8DOMException.cpp
+ 22) 11441 (57.1%) t@0x60048c 488 third_party/skia/src/images/SkPngEncoder.cpp
SkPngEncoder::Make
~ 23) 11057 (55.2%) r@0x2f6de14 -384 third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_static.a/hash.o
~ 24) 10681 (53.3%) r@0x2f06a70 -376 components/subresource_filter/content/renderer/subresource_filter_agent.cc
+ 25) 11057 (55.2%) t@0x5feb04 376 third_party/skia/src/images/SkJpegEncoder.cpp
SkJpegEncoderMgr::setParams
~ 26) 10701 (53.4%) r@0x2e81ac0 -356 third_party/webrtc/p2p/base/stunport.cc
+ 27) 11053 (55.2%) t@0x5ffebc 352 third_party/skia/src/images/SkPngEncoder.cpp
SkPngEncoderMgr::setHeader
~ 28) 11401 (56.9%) r@0x2e8ecc0 348 third_party/webrtc/pc/peerconnection.cc
+ 29) 11745 (58.6%) t@0x600708 344 third_party/skia/src/images/SkWebpEncoder.cpp
transform_scanline_gray
~ 30) 12057 (60.2%) d@0x315e870 312 blink/bindings/core/v8/V8Mojo.cpp
~ 31) 12345 (61.6%) d@0x315e328 288 blink/bindings/core/v8/V8NodeFilter.cpp
~ 32) 12057 (60.2%) d@0x315e7e0 -288 blink/bindings/core/v8/V8ApplicationCache.cpp
+ 33) 12321 (61.5%) t@0x17aced0 264 third_party/libwebp/mux/muxinternal.c
MuxValidate
~ 34) 12065 (60.2%) r@0x2d8a250 -256 v8/src/arm/code-stubs-arm.cc
+ 35) 12321 (61.5%) t@Group 256 third_party/skia/src/images/{{shared}}/2
transform_scanline_4444 (count=2)
+ 36) 12577 (62.8%) t@Group 256 third_party/skia/src/images/{{shared}}/2
transform_scanline_bgrA (count=2)
+ 37) 12833 (64.1%) t@Group 256 third_party/skia/src/images/{{shared}}/2
transform_scanline_rgbA (count=2)
~ 38) 12585 (62.8%) r@0x2da45c0 -248 third_party/libjpeg_turbo/jquant1.c
~ 39) 12337 (61.6%) d@0x315dbe4 -248 blink/bindings/core/v8/V8CSS.cpp
~ 40) 12585 (62.8%) d@0x315dbf8 248 blink/bindings/core/v8/V8CSSRule.cpp
+ 41) 12833 (64.1%) t@Group 248 third_party/skia/src/images/{{shared}}/2
transform_scanline_sbgrA (count=2)
~ 42) 13073 (65.3%) r@0x2dac230 240 gpu/command_buffer/service/feature_info.cc
+ 43) 13311 (66.5%) t@0x71583c 238 third_party/libpng/pngset.c
cr_png_set_iCCP
+ 44) 13547 (67.6%) t@0x17ac3ea 236 third_party/libwebp/mux/muxedit.c
,
May 25 2017
This is expected. This should be offset the deletion of the encoders that are being replaced (see bugs below). Many of the new symbols correspond to new encoding features that are needed by the platform (webp mux, embedding color profiles). https://bugs.chromium.org/p/chromium/issues/detail?id=713862 https://bugs.chromium.org/p/chromium/issues/detail?id=724616 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by agrieve@chromium.org
, May 15 2017