estBrowserThreadBundleTest.MultipleTestBrowserThreadBundle occasional timeout |
|||
Issue description
[ RUN ] TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle
[WARNING] ../../third_party/googletest/src/googletest/src/gtest-death-test.cc:836:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 6 threads.
[4038/4038] TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle (TIMED OUT)
1 test timed out:
TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle (../../content/public/test/test_browser_thread_bundle_unittest.cc:29)
Test introduced with https://codereview.chromium.org/2860533002
$ cat args.gn
is_chromecast=true
is_component_build=false
chromecast_branding="internal"
is_cast_audio_only=true
target_cpu="x64"
use_goma=true
enable_assistant=true
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2189c4293cf8a09dedc9792f801acf0396a070dc commit 2189c4293cf8a09dedc9792f801acf0396a070dc Author: Francois Doray <fdoray@chromium.org> Date: Tue Jun 27 13:33:25 2017 Do not EXPECT_DEATH after creating threads in TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle. When EXPECT_DEATH is used in a process that has more than 1 thread, the following message is printed: "Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected x threads." This CL ensures that no thread is created before EXPECT_DEATH in TestBrowserThreadBundleTest.MultipleTestBrowserThreadBundle. That prevents the error message above from being printed. I'm speculating that this may fix https://crbug.com/722412 . Bug: 722412 Change-Id: Ife15cdee26f17acb54218923af1d0a75a0c7e549 Reviewed-on: https://chromium-review.googlesource.com/549217 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Francois Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#482612} [modify] https://crrev.com/2189c4293cf8a09dedc9792f801acf0396a070dc/content/public/test/test_browser_thread_bundle_unittest.cc
,
Jun 27 2017
mbjorge@: Could you verify whether my patch fixes the issue?
,
Jul 7 2017
looking at recent test results, I am not seeing this error anymore, so it appears to be fixed. Thanks!
,
Jul 7 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mbjorge@chromium.org
, May 15 2017