New issue
Advanced search Search tips

Issue 722382 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Rename payments/ui/EditorView to payments/ui/EditorDialog

Project Member Reported by rouslan@chromium.org, May 15 2017

Issue description

The word "View" is used in the MVC sense, which is not conventional for Android code. Android uses View to mean a widget. However. EditorView is a Dialog. Therefore, it should be named EditorDialog to follow Android conventions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c

commit 9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon May 15 21:45:10 2017

Rename payments/ui/EditorView to payments/ui/EditorDialog

The word "View" is used in the MVC sense, which is not conventional for
Android code. Android uses View to mean a widget. However. EditorView is
a Dialog. Therefore, it should be named EditorDialog to follow Android
conventions.

Bug:  722382 
Change-Id: I47e720098ce43def28d1db1f6a23a70e84def527
Reviewed-on: https://chromium-review.googlesource.com/505870
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471913}
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/build/android/lint/suppressions.xml
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/EditorBase.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[rename] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/java_sources.gni
[modify] https://crrev.com/9edfd334b6666cd0e42b8f6994cb7807b6ad8f0c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment