New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722381 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: May 2017
Cc:
jam@chromium.org
█ ben@chromium.org
█ tibell@chromium.org
sa...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Service Manager should have direct catalog access

Project Member Reported by roc...@chromium.org, May 15 2017 
Rather than the service manager being just another client of the catalog service, it should simply own the catalog state and expose the catalog service itself for other clients to consume.

This will allow us to continue exposing a separate set of public service interfaces for catalog management without requiring the (quite hot) service resolution code path to be async within the service manager.
Project Member

Comment 1 by bugdroid1@chromium.org, May 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f378d95eebc60fd6568c4524abaec2aaa377c7d0

commit f378d95eebc60fd6568c4524abaec2aaa377c7d0
Author: Ken Rockot <rockot@chromium.org>
Date: Wed May 17 07:59:27 2017

Make Service Manager name resolution synchronous

Merges the catalog state into ServiceManager so it can do name
resolution synchronously and without any extra de/serialization steps.

BUG= 722381 
R=ben@chromium.org
TBR=tsepez@chromium.org

Change-Id: I462b8f76b833cc96265c9491dc6691b484139e93
Reviewed-on: https://chromium-review.googlesource.com/506310
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ben Goodger <ben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472376}
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/catalog.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/catalog.h
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/entry.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/entry.h
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/entry_unittest.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/instance.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/catalog/instance.h
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/BUILD.gn
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/DEPS
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/manifest.json
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/public/interfaces/BUILD.gn
[delete] https://crrev.com/8da317132e28f88c93241b56ea9e15ae121cedf4/services/service_manager/public/interfaces/resolver.mojom
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/service_manager.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/service_manager.h
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/standalone/context.cc
[modify] https://crrev.com/f378d95eebc60fd6568c4524abaec2aaa377c7d0/services/service_manager/standalone/context.h

Comment 2 by roc...@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment