New issue
Advanced search Search tips

Issue 722380 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Task

Blocked on:
issue 720933

Blocking:
issue 778564



Sign in to add a comment

Run SwiftShader unit tests on general buildbots

Project Member Reported by capn@chromium.org, May 15 2017

Issue description

SwiftShader's unit tests currently run on the GPU FYI bots: https://cs.chromium.org/swiftshader_unittests. They failed to catch  Issue 720933  because they don't run any build with is_official_build = true.

SwiftShader's unit tests don't depend on GPUs, so we can just run them on the general buildbots.
 

Comment 1 by capn@chromium.org, May 29 2017

Components: Internals>GPU>SwiftShader

Comment 2 by capn@chromium.org, Jul 6 2017

Cc: thakis@chromium.org mar...@chromium.org
@thakis, any advice on how to go about this? I did some code searches but was unable to figure out which bots build with is_official_build = true and where their scripts for running unit tests live. Thanks for any pointers.

Comment 3 by mar...@chromium.org, Aug 17 2017

Cc: mmoss@chromium.org
I just saw this request; doing an official build takes a lot of time, because it enables LTCG/WPO. Maybe you want these to run on the official builds? Michael is working on this.

Comment 4 by capn@chromium.org, Aug 17 2017

SwiftShader's unit tests don't depend on chrome (just gtest) and they're very small, so they don't take a lot of time to build.

Comment 5 by mar...@chromium.org, Aug 17 2017

Ah then you could add a separate builder, similar to whatever release you use but in addition with is_official_build=true to get this coverage.

Comment 6 by capn@chromium.org, Sep 2 2017

That is precisely what we could use some guidance on. Where do I add such a builder?
Cc: jbudorick@chromium.org
Is this still a need? cc'ing John as I'm not familiar with the CI system anymore.

Comment 8 by capn@chromium.org, Apr 9 2018

Yes, this would still be good to have.
Cc: capn@chromium.org
Owner: ----
Status: Available (was: Assigned)
Blocking: 778564
Yes, yes it is :).
You're better off starting with the instructions in //testing/buildbot/README.md at this point, and then asking jbudorick@ or martiniss@ or kbr@ or myself (or, failing all of those things, asking on chromium-dev) if you have questions.
Thanks for the pointers!

Sign in to add a comment