New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722371 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Manage ext4 migration for edu

Project Member Reported by igorcov@chromium.org, May 15 2017

Issue description

Chrome Version: 60
OS: Chrome

This is to track the progress to manage ext4 migration for edu devices.
Design doc for this:
https://docs.google.com/document/d/18Nz2OClU6CDb7TpZ2MbO4yySvgiOYWsFUxrR4LQYzXU/edit?ts=5915e354#
 
Owner: igorcov@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2e3a76424261598c4033dcb06e49f9c3205808

commit 3f2e3a76424261598c4033dcb06e49f9c3205808
Author: igorcov <igorcov@chromium.org>
Date: Wed May 17 17:20:38 2017

Policy definition for encryptfs to ext4 migration strategy

This is just the proto definition for the policy. It should allow
development on server side without waiting for client implementation.

BUG= 722371 

Review-Url: https://codereview.chromium.org/2885153005
Cr-Commit-Position: refs/heads/master@{#472487}

[modify] https://crrev.com/3f2e3a76424261598c4033dcb06e49f9c3205808/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/193a454cb1ee78b5a6cecc6c6e6fb63c1598c40c

commit 193a454cb1ee78b5a6cecc6c6e6fb63c1598c40c
Author: igorcov <igorcov@chromium.org>
Date: Tue May 23 11:48:13 2017

Default unspecified value added to enum in proto

Updated the enum in proto to be according to the rules from
https://engdoc.corp.google.com/eng/doc/devguide/proto/index.md?cl=head

BUG= 722371 

Review-Url: https://codereview.chromium.org/2898683002
Cr-Commit-Position: refs/heads/master@{#473862}

[modify] https://crrev.com/193a454cb1ee78b5a6cecc6c6e6fb63c1598c40c/chrome/browser/chromeos/policy/proto/chrome_device_policy.proto

Cc: josa...@chromium.org
Labels: Merge-Request-60
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 16 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I will need to merge back to 60 the CLs above, and two other CLs:
https://chromium-review.googlesource.com/c/529111/
https://codereview.chromium.org/2890843002/
Please tag with appropriate OSs.  Thanks.

Comment 8 by uekawa@chromium.org, Jun 20 2017

Labels: OS-Chrome
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6

commit 24be4caf84c7c14e68c4c10206c3ea0a506c0ee6
Author: igorcov <igorcov@chromium.org>
Date: Thu Jun 22 10:29:34 2017

Policy implementation for encryptfs to ext4 migration strategy

Chrome OS encrypts each user’s data with the user’s password. With M60,
Chrome OS is switching from ecryptfs to ext4 encryption. ARC N requires
ext4 encryption. The policy DeviceEcryptfsMigrationStrategy states
whether the device is allowed to use ARC or not. If it's not allowed,
the process of data migration should not be launched.

Design doc: https://docs.google.com/document/d/18Nz2OClU6CDb7TpZ2MbO4yySvgiOYWsFUxrR4LQYzXU/edit?ts=5915e354#

This implementation is planned to become obsolete, and be rolled back
after the migration process will finish. The issue for that:
 http://crbug.com/725493 

BUG= 722371 
TEST=Manual tests and unit tests.

Review-Url: https://codereview.chromium.org/2890843002
Cr-Commit-Position: refs/heads/master@{#481499}

[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/arc/arc_util.h
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chromeos/chromeos_switches.cc
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/chromeos/chromeos_switches.h
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/components/policy/resources/policy_templates.json
[modify] https://crrev.com/24be4caf84c7c14e68c4c10206c3ea0a506c0ee6/tools/metrics/histograms/enums.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f7458261c482be5adf995714c166366bce3c0eb5

commit f7458261c482be5adf995714c166366bce3c0eb5
Author: Igor <igorcov@chromium.org>
Date: Thu Jun 22 14:55:47 2017

libchromeos USE flags: add arc_migration_policy_check

If arc_migration_policy_check is set, then the device policy
DeviceEcryptfsMigrationStrategy must be checked before providing
the option to user to migrate the data. Only if the device is
consumer owned or the policy allows the migration the user should
be able to start data migration.

This is the cherry-pick of
https://chromium-review.googlesource.com/c/533216/
intended to go in release-R60-9592.B

BUG= chromium:722371 
TEST=none

Change-Id: Id19c9f989f71637cf8dfeaac04c3206fbd26c134
Reviewed-on: https://chromium-review.googlesource.com/544917
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>

[rename] https://crrev.com/f7458261c482be5adf995714c166366bce3c0eb5/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r27.ebuild
[modify] https://crrev.com/f7458261c482be5adf995714c166366bce3c0eb5/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b4de8ef1ac9cbf28ee064179d0972de37db9b20b

commit b4de8ef1ac9cbf28ee064179d0972de37db9b20b
Author: Igor <igorcov@chromium.org>
Date: Thu Jun 22 14:55:47 2017

login: need-arc-migration-policy-check flag

If arc_policy_migration_check USE flag is enabled, set
need-arc-migration-policy-check.

This is the cherry-pick of
https://chromium-review.googlesource.com/c/533236/
intended to go in release-R60-9592.B

BUG= chromium:722371 
TEST=none

Change-Id: Iacf1280665f11bc3b9bce14d3de9a5d157deb59f
Reviewed-on: https://chromium-review.googlesource.com/544995
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>

[modify] https://crrev.com/b4de8ef1ac9cbf28ee064179d0972de37db9b20b/login_manager/chrome_setup.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 23 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e

commit f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e
Author: Igor <igorcov@chromium.org>
Date: Fri Jun 23 11:19:45 2017

Policy implementation for encryptfs to ext4 migration strategy

Chrome OS encrypts each user’s data with the user’s password. With M60,
Chrome OS is switching from ecryptfs to ext4 encryption. ARC N requires
ext4 encryption. The policy DeviceEcryptfsMigrationStrategy states
whether the device is allowed to use ARC or not. If it's not allowed,
the process of data migration should not be launched.

Design doc: https://docs.google.com/document/d/18Nz2OClU6CDb7TpZ2MbO4yySvgiOYWsFUxrR4LQYzXU/edit?ts=5915e354#

This implementation is planned to become obsolete, and be rolled back
after the migration process will finish. The issue for that:
 http://crbug.com/725493 

BUG= 722371 
TEST=Manual tests and unit tests.

Review-Url: https://codereview.chromium.org/2890843002
Cr-Original-Commit-Position: refs/heads/master@{#481499}
Review-Url: https://codereview.chromium.org/2956633002 .
Cr-Commit-Position: refs/branch-heads/3112@{#448}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/arc/arc_util.h
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chromeos/chromeos_switches.cc
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/chromeos/chromeos_switches.h
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/components/policy/resources/policy_templates.json
[modify] https://crrev.com/f3deed295ff4ee4d8e0a42a4d9bb19d528dd2d2e/tools/metrics/histograms/enums.xml

Progress of efforts to make this controllable by user policy:
Design: go/chromeos-ext4-migration-user-policy

All CLs up:

CROS CLs:
system_api: https://chromium-review.googlesource.com/c/562137/
libbrillo: https://chromium-review.googlesource.com/c/562277/
session_manager: https://chromium-review.googlesource.com/c/562158/
cryptohome: https://chromium-review.googlesource.com/c/562157/

chromium CLs:
https://chromium-review.googlesource.com/c/564609/
(needs more polish in unit test + user policy description)

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/3aceabc2628edabf2e8c0442137060a327e1d108

commit 3aceabc2628edabf2e8c0442137060a327e1d108
Author: Igor <igorcov@chromium.org>
Date: Thu Jul 13 22:08:43 2017

chromeos-overlay: Set need-arc-migration-policy-check USE flags.

This is set for the list of overlays that will get ARC (N+) and have
been issued with ecryptfs encryption initially.

BUG= chromium:722371 
TEST=none

Change-Id: Ib0633747ce7fed366fe1ed9dbfa2a2af9be499ae
Reviewed-on: https://chromium-review.googlesource.com/529111
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-lars/profiles/base/make.defaults
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-asuka/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-relm/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-kevin/profiles/base/make.defaults
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-celes/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-kefka/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-banon/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-elm/profiles/base/make.defaults
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-terra/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-cave/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-reks/make.conf
[modify] https://crrev.com/3aceabc2628edabf2e8c0442137060a327e1d108/overlay-hana/profiles/base/make.defaults

The last CL to be merged-back to 60 is:
https://chromium-review.googlesource.com/c/571721/

which is a cherry-pick from
https://chromium-review.googlesource.com/c/529111/

It was in the list of CLs that was requested for the the merge.
With it, the work for device policy is done.

In 61, after the work on user policy will land, the CLs related to
device policy will be rolled-back.
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/69b19fbcbec5fa8f5933b9c3f3375052b0059980

commit 69b19fbcbec5fa8f5933b9c3f3375052b0059980
Author: Pavol Marko <pmarko@chromium.org>
Date: Fri Jul 14 12:51:52 2017

system_api: Support for temporary policy read

This contains two changes:
- Protobuf change in cryptohome to allow temporary user home mounts and
  return their location.
- New method in login_manager to read policy from a temporary user home
  mount.

Both changes are required to read user policy before actual cryptohome
mount, which will be necessary to decide if ext4 migration is allowed.

BUG= chromium:722371 
TEST=none

Change-Id: If734b17b4c1ebd7e3ae1adf698f21493258f2b34
Reviewed-on: https://chromium-review.googlesource.com/562137
Commit-Ready: Pavol Marko <pmarko@chromium.org>
Tested-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/69b19fbcbec5fa8f5933b9c3f3375052b0059980/dbus/cryptohome/rpc.proto
[modify] https://crrev.com/69b19fbcbec5fa8f5933b9c3f3375052b0059980/dbus/login_manager/dbus-constants.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/be10caf8f1930581cfaf4a742d052e7faa6e7bdf

commit be10caf8f1930581cfaf4a742d052e7faa6e7bdf
Author: Igor <igorcov@chromium.org>
Date: Mon Jul 17 09:16:20 2017

chromeos-overlay: Set need-arc-migration-policy-check USE flags.

This is set for the list of overlays that will get ARC (N+) and have
been issued with ecryptfs encryption initially.

BUG= chromium:722371 
TEST=none

Change-Id: Ib0633747ce7fed366fe1ed9dbfa2a2af9be499ae
Reviewed-on: https://chromium-review.googlesource.com/529111
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 3aceabc2628edabf2e8c0442137060a327e1d108)
Reviewed-on: https://chromium-review.googlesource.com/571721
Commit-Queue: Igor <igorcov@chromium.org>

[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-lars/profiles/base/make.defaults
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-asuka/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-relm/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-kevin/profiles/base/make.defaults
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-celes/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-kefka/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-banon/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-elm/profiles/base/make.defaults
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-terra/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-cave/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-reks/make.conf
[modify] https://crrev.com/be10caf8f1930581cfaf4a742d052e7faa6e7bdf/overlay-hana/profiles/base/make.defaults

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbbc5e35d93d1c3b6aadca1f6b63322e14045c75

commit bbbc5e35d93d1c3b6aadca1f6b63322e14045c75
Author: Pavol Marko <pmarko@chromium.org>
Date: Mon Jul 17 13:17:40 2017

Roll src/third_party/cros_system_api/ 137ec42a3..69b19fbcb (1 commit)

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/137ec42a355f..69b19fbcbec5

$ git log 137ec42a3..69b19fbcb --date=short --no-merges --format='%ad %ae %s'
2017-06-30 pmarko system_api: Support for temporary policy read

Created with:
  roll-dep src/third_party/cros_system_api

This will be used by CL:564609.

BUG= 722371 

Change-Id: Ieadd125ff2aa83a3ca69c3611d2c60aae3c1e2d6
Reviewed-on: https://chromium-review.googlesource.com/574347
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487062}
[modify] https://crrev.com/bbbc5e35d93d1c3b6aadca1f6b63322e14045c75/DEPS

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/9f21d7d47a8af692ccf19714ca59af873003434a

commit 9f21d7d47a8af692ccf19714ca59af873003434a
Author: Pavol Marko <pmarko@chromium.org>
Date: Mon Jul 17 17:28:24 2017

libbrillo: Add GetDaemonPathForTemporaryUserHome to cryptohome utilities

Similar to GetDaemonPath, GetDaemonPathForTemporaryUserHome returns
the directory where the passed daemon should store its data for a
temporary user home mount.

BUG= chromium:722371 
TEST=Tests still pass, actual functionality tested by CL
https://chromium-review.googlesource.com/c/562158/

Change-Id: I06efeed13bc611bab9baa542de47d9f7112e792e
Reviewed-on: https://chromium-review.googlesource.com/562277
Commit-Ready: Pavol Marko <pmarko@chromium.org>
Tested-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/9f21d7d47a8af692ccf19714ca59af873003434a/brillo/cryptohome.h
[modify] https://crrev.com/9f21d7d47a8af692ccf19714ca59af873003434a/brillo/cryptohome.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/090f3a40f054f89d1f865cca868ce2e4fbcc1645

commit 090f3a40f054f89d1f865cca868ce2e4fbcc1645
Author: Pavol Marko <pmarko@chromium.org>
Date: Tue Jul 18 21:26:18 2017

login: Add RetrievePolicyForUserWithoutSession

Add D-Bus method RetrievePolicyForUserWithoutSession which retrieves
user policy from a temporary user home mount passed as argument.

This will be used to read user policy before really mounting cryptohome,
to decide if migration to dircrypto is allowed.

BUG= chromium:722371 
TEST=cros_run_unit_tests --board=.. --packages "chromeos-login"
CQ-DEPEND=CL:562137,CL:562277

Change-Id: I6dad9293fd70df6bcab6e7356e4d7864457026e1
Reviewed-on: https://chromium-review.googlesource.com/562158
Commit-Ready: Pavol Marko <pmarko@chromium.org>
Tested-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/user_policy_service_factory.cc
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/user_policy_service_factory.h
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/SessionManager.conf
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/session_manager_impl.cc
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/dbus_bindings/org.chromium.SessionManagerInterface.xml
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/session_manager_impl_unittest.cc
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/mock_user_policy_service_factory.h
[modify] https://crrev.com/090f3a40f054f89d1f865cca868ce2e4fbcc1645/login_manager/session_manager_impl.h

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5e81e1592f5622002c720466015ffd2d6962aaa2

commit 5e81e1592f5622002c720466015ffd2d6962aaa2
Author: Pavol Marko <pmarko@chromium.org>
Date: Wed Jul 19 08:23:38 2017

cryptohome: Add support for hidden user home mounts

Adds support for performing a hidden user home mount using MountEx
(by passing the hidden_mount=true argument).
Such a mount is not exposed to the usual locations (/home/chronos,
/home/root).

Internally, this is performed by only setting up the mount in
/home/.shadow directories and not setting up the usual binds.

This will be used from chrome to read user policy when an ecryptfs
user home is detected to decide if user home migration is allowed.

BUG= chromium:722371 
TEST=cros_run_unit_tests --packages "cryptohome"
TEST=cryptohome --action=mount_ex --user=foo@foo.com --hidden_mount
CQ-DEPEND=CL:562137

Change-Id: Ie936420d519745c9cd095ae137724c7ef4cf4386
Reviewed-on: https://chromium-review.googlesource.com/562157
Commit-Ready: Pavol Marko <pmarko@chromium.org>
Tested-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@google.com>

[modify] https://crrev.com/5e81e1592f5622002c720466015ffd2d6962aaa2/cryptohome/service.h
[modify] https://crrev.com/5e81e1592f5622002c720466015ffd2d6962aaa2/cryptohome/mount_unittest.cc
[modify] https://crrev.com/5e81e1592f5622002c720466015ffd2d6962aaa2/cryptohome/cryptohome.cc
[modify] https://crrev.com/5e81e1592f5622002c720466015ffd2d6962aaa2/cryptohome/mount.cc
[modify] https://crrev.com/5e81e1592f5622002c720466015ffd2d6962aaa2/cryptohome/mount.h
[modify] https://crrev.com/5e81e1592f5622002c720466015ffd2d6962aaa2/cryptohome/service.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02f621665ac131123c6dbb1a5a4365bf7bd1404

commit a02f621665ac131123c6dbb1a5a4365bf7bd1404
Author: Pavol Marko <pmarko@chromium.org>
Date: Thu Jul 20 12:53:30 2017

User policy for ecryptfs migration

- Add user policy EcryptfsMigrationStrategy which controls ecryptfs
  to dircrypto cryptohome migration.
- Implement a pre-signin policy fetch mechanism which tries to fetch cached
  policy first, and if there is valid cached policy, also tries to fetch
  fresh policy.
- Wire up the pre-signin policy fetch into existing_user_controller.cc to
  decide what to do when a ecryptfs user home is detected.

Fetching cached policy is done by mounting cryptohome to a temporary
location, reading policy from there, and then unmounting.

Fetching fresh policy is done using the dm_token/client_id from the
cached policy with a fixed timeout.

TEST=unit_tests --gtest_filter=PreSigninPolicyFetcherTest*
TEST=Manual test with ecryptfs cryptohome and YAPS
BUG= 722371 

Change-Id: I040cf3626257447e4e0dd2c70cf2d10604cb1977
Reviewed-on: https://chromium-review.googlesource.com/564609
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488217}
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/login/existing_user_controller.h
[add] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos.cc
[add] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos.h
[add] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos_unittest.cc
[add] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[add] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h
[add] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chromeos/dbus/mock_session_manager_client.h
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/chromeos/dbus/session_manager_client.h
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/components/policy/resources/policy_templates.json
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/a02f621665ac131123c6dbb1a5a4365bf7bd1404/tools/metrics/histograms/enums.xml

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b05f97c3b1e1a1530bec43fb69434089d6180ce6

commit b05f97c3b1e1a1530bec43fb69434089d6180ce6
Author: Pavol Marko <pmarko@chromium.org>
Date: Fri Jul 21 05:28:08 2017

Fix ext4 migration histogram value on policy-forced migration

Make policy-forced migration to ext4 report the new
FIRST_SCREEN_START_AUTOMATICALLY UMA stat value instead of
FIRST_SCREEN_RESUME.

The introduction of EncryptionMigrationMode was required to distinguish
between these cases.

BUG= 722371 

Change-Id: I112406048e82c31762123a32775be445e6e731ab
Reviewed-on: https://chromium-review.googlesource.com/579382
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488590}
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/chromeos/login/existing_user_controller.h
[add] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/chromeos/login/screens/encryption_migration_mode.h
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/chromeos/login/screens/encryption_migration_screen.cc
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/chromeos/login/screens/encryption_migration_screen.h
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/chromeos/login/screens/encryption_migration_screen_view.h
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/b05f97c3b1e1a1530bec43fb69434089d6180ce6/tools/metrics/histograms/enums.xml

Comment 25 by pmarko@google.com, Jul 21 2017

Status update:

The CLs for the EcryptfsMigrationStrategy user policy have all landed.

When the branch for M61 is created, I will check if we need to ask for merges for any of them (possibly the last chromium-side CL, improving UMA histogram values for the policy-forced migration case https://chromium-review.googlesource.com/579382, will not be included in the branch).
Note: Efforts around the user policy for ext4 migration (for M61+) were forked off into  bug 747907 .

Going forward,
- this bug will be used to track efforts around device policy DeviceEcryptfsMigrationStrategy (<=M60)
-  bug 747907  will be used to track efforts around user policy EcryptfsMigrationStrategy (>=M61)

Labels: Merge-Request-61
Requesting to merge the last CL https://chromium-review.googlesource.com/579382 to M61 branch. It landed a few hours after branch point, and improves UMA stats for policy-controlled ext4 migration options.
Project Member

Comment 28 by sheriffbot@chromium.org, Jul 27 2017

Labels: -Merge-Request-61 Merge-Review-61
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: keta...@chromium.org
+ketakid
Please take a look at my merge request for CL https://chromium-review.googlesource.com/579382 to M61 branch.
This particular CL
- affect ChromeOS only
- does not touch DEPS
- Functionaliy: Adds additional histogram bucket value for policy-forced migration, so the usage of this feature can be tracked.
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4016485c26034ae9726d408f0c242abb87896faa

commit 4016485c26034ae9726d408f0c242abb87896faa
Author: Igor <igorcov@chromium.org>
Date: Mon Aug 07 20:50:47 2017

Revert "login: need-arc-migration-policy-check flag"

This reverts commit 69a3ec7f36f11a0fddc6e6b3083ebc1276358753.

Reason for revert: This functionality was needed for device
policy implemented in M-60. Starting from M-61 it is covered
by an user policy and the flag is not needed.

Original change's description:
> login: need-arc-migration-policy-check flag
>
> If arc_policy_migration_check USE flag is enabled, set
> need-arc-migration-policy-check.
>
> BUG= chromium:722371 
> TEST=none
>
> Change-Id: I8741984abc35669edbe8d443d4334d98005a7d8b
> Reviewed-on: https://chromium-review.googlesource.com/533236
> Commit-Ready: Igor <igorcov@chromium.org>
> Tested-by: Igor <igorcov@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>

Bug:  chromium:725493 
Change-Id: I1fa76bb683c6019ebff9ae47472a44d4a21182ad
Reviewed-on: https://chromium-review.googlesource.com/602150
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/4016485c26034ae9726d408f0c242abb87896faa/login_manager/chrome_setup.cc

Labels: M-61
Is this still pending merge to M61?
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 23 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/eccf1725cf9f5ce958b2ba8eb8d846128b0dd140

commit eccf1725cf9f5ce958b2ba8eb8d846128b0dd140
Author: Igor <igorcov@chromium.org>
Date: Wed Aug 23 06:45:13 2017

Revert "login: need-arc-migration-policy-check flag"

This reverts commit 69a3ec7f36f11a0fddc6e6b3083ebc1276358753.

Reason for revert: This functionality was needed for device
policy implemented in M-60. Starting from M-61 it is covered
by an user policy and the flag is not needed.

Original change's description:
> login: need-arc-migration-policy-check flag
>
> If arc_policy_migration_check USE flag is enabled, set
> need-arc-migration-policy-check.
>
> BUG= chromium:722371 
> TEST=none
>
> Change-Id: I8741984abc35669edbe8d443d4334d98005a7d8b
> Reviewed-on: https://chromium-review.googlesource.com/533236
> Commit-Ready: Igor <igorcov@chromium.org>
> Tested-by: Igor <igorcov@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>

Bug:  chromium:725493 
Change-Id: I1fa76bb683c6019ebff9ae47472a44d4a21182ad
Reviewed-on: https://chromium-review.googlesource.com/602150
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit 4016485c26034ae9726d408f0c242abb87896faa)
Reviewed-on: https://chromium-review.googlesource.com/626125
Commit-Queue: Igor <igorcov@chromium.org>

[modify] https://crrev.com/eccf1725cf9f5ce958b2ba8eb8d846128b0dd140/login_manager/chrome_setup.cc

Project Member

Comment 34 by sheriffbot@chromium.org, Aug 28 2017

Cc: pmarko@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 35 by bugdroid1@chromium.org, Aug 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3db690b631e82a3ea9a2d2ed7eb6b12186fb7287

commit 3db690b631e82a3ea9a2d2ed7eb6b12186fb7287
Author: Igor <igorcov@chromium.org>
Date: Mon Aug 28 22:24:13 2017

login: Flag for devices transitioning from ARC M to ARC N

There's a group of devices that had ARC M in version 60. The
devices from that group that are in EDU require a separate logic
when the migration policy is not set by admin. This flag allows
the device to recognize the group it is in. Design doc for this:
https://docs.google.com/document/d/1Wi5K1rTu74kHxznbaKGOP8fALfJsgPhvb5uA9K9AVPg/edit?ts=59a1f193#

BUG= chromium:722371 
TEST=None

Change-Id: Ie0b95a48146cfebe3b25d72f4a3ef770feba1fc6
Reviewed-on: https://chromium-review.googlesource.com/637771
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/3db690b631e82a3ea9a2d2ed7eb6b12186fb7287/login_manager/chrome_setup.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5ab5a6b8388cea8309de39e519b78dfcdd965965

commit 5ab5a6b8388cea8309de39e519b78dfcdd965965
Author: Igor <igorcov@chromium.org>
Date: Tue Aug 29 11:45:50 2017

chromeos-overlay: Arc transition from M to N flag.

The devices included in this CL had ARC M in version 60 and will
get ARC N in version 61. The part of them that are in EDU need a
separate logic when the admin left the migration policy unset.

Design doc for this:
https://docs.google.com/document/d/1Wi5K1rTu74kHxznbaKGOP8fALfJsgPhvb5uA9K9AVPg/edit?ts=59a1f193#

BUG= chromium:722371 
TEST=None

Change-Id: I6e041e4eaa0b67e1c6126f65fd3690ea560ed570
Reviewed-on: https://chromium-review.googlesource.com/637998
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5ab5a6b8388cea8309de39e519b78dfcdd965965/overlay-variant-veyron-minnie/make.conf
[modify] https://crrev.com/5ab5a6b8388cea8309de39e519b78dfcdd965965/overlay-variant-veyron-tiger/profiles/base/make.defaults
[modify] https://crrev.com/5ab5a6b8388cea8309de39e519b78dfcdd965965/overlay-variant-veyron-fievel/profiles/base/make.defaults
[modify] https://crrev.com/5ab5a6b8388cea8309de39e519b78dfcdd965965/overlay-samus/profiles/base/make.defaults
[modify] https://crrev.com/5ab5a6b8388cea8309de39e519b78dfcdd965965/overlay-kevin/profiles/base/make.defaults
[modify] https://crrev.com/5ab5a6b8388cea8309de39e519b78dfcdd965965/overlay-cyan/make.conf

Components: Enterprise
Project Member

Comment 38 by sheriffbot@chromium.org, Sep 1 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 39 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e4c1d3a4bd8edf4639d655ec3ca972a5968f6ada

commit e4c1d3a4bd8edf4639d655ec3ca972a5968f6ada
Author: Igor <igorcov@chromium.org>
Date: Mon Sep 04 15:51:50 2017

login: Flag for devices transitioning from ARC M to ARC N

There's a group of devices that had ARC M in version 60. The
devices from that group that are in EDU require a separate logic
when the migration policy is not set by admin. This flag allows
the device to recognize the group it is in. Design doc for this:
https://docs.google.com/document/d/1Wi5K1rTu74kHxznbaKGOP8fALfJsgPhvb5uA9K9AVPg/edit?ts=59a1f193#

BUG= chromium:722371 
TEST=None

Change-Id: Ie0b95a48146cfebe3b25d72f4a3ef770feba1fc6
Reviewed-on: https://chromium-review.googlesource.com/637771
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
(cherry picked from commit 3db690b631e82a3ea9a2d2ed7eb6b12186fb7287)
Reviewed-on: https://chromium-review.googlesource.com/647450
Commit-Queue: Igor <igorcov@chromium.org>

[modify] https://crrev.com/e4c1d3a4bd8edf4639d655ec3ca972a5968f6ada/login_manager/chrome_setup.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Sep 5 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58115698fe6465af7ff7583947bde0f00b37dbb

commit e58115698fe6465af7ff7583947bde0f00b37dbb
Author: Pavol Marko <pmarko@chromium.org>
Date: Tue Sep 05 06:55:51 2017

[Merge to M61] Fix ext4 migration histogram value on policy-forced migration

Make policy-forced migration to ext4 report the new
FIRST_SCREEN_START_AUTOMATICALLY UMA stat value instead of
FIRST_SCREEN_RESUME.

The introduction of EncryptionMigrationMode was required to distinguish
between these cases.

BUG= 722371 
TBR=pmarko@chromium.org

(cherry picked from commit b05f97c3b1e1a1530bec43fb69434089d6180ce6)

Change-Id: I112406048e82c31762123a32775be445e6e731ab
Reviewed-on: https://chromium-review.googlesource.com/579382
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488590}
Reviewed-on: https://chromium-review.googlesource.com/649646
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1096}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/chromeos/login/existing_user_controller.h
[add] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/chromeos/login/screens/encryption_migration_mode.h
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/chromeos/login/screens/encryption_migration_screen.cc
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/chromeos/login/screens/encryption_migration_screen.h
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/chromeos/login/screens/encryption_migration_screen_view.h
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/e58115698fe6465af7ff7583947bde0f00b37dbb/tools/metrics/histograms/enums.xml

Project Member

Comment 41 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/3b4ac39451a251854d17874eae4b9ba2e338d305

commit 3b4ac39451a251854d17874eae4b9ba2e338d305
Author: Igor <igorcov@chromium.org>
Date: Wed Sep 06 08:33:52 2017

chromeos-overlay: Arc transition from M to N flag.

The devices included in this CL had ARC M in version 60 and will
get ARC N in version 61. The part of them that are in EDU need a
separate logic when the admin left the migration policy unset.

Design doc for this:
https://docs.google.com/document/d/1Wi5K1rTu74kHxznbaKGOP8fALfJsgPhvb5uA9K9AVPg/edit?ts=59a1f193#

BUG= chromium:722371 
TEST=None

Change-Id: I6e041e4eaa0b67e1c6126f65fd3690ea560ed570
Reviewed-on: https://chromium-review.googlesource.com/637998
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 5ab5a6b8388cea8309de39e519b78dfcdd965965)
Reviewed-on: https://chromium-review.googlesource.com/649266
Commit-Queue: Igor <igorcov@chromium.org>

[modify] https://crrev.com/3b4ac39451a251854d17874eae4b9ba2e338d305/overlay-variant-veyron-minnie/make.conf
[modify] https://crrev.com/3b4ac39451a251854d17874eae4b9ba2e338d305/overlay-variant-veyron-tiger/profiles/base/make.defaults
[modify] https://crrev.com/3b4ac39451a251854d17874eae4b9ba2e338d305/overlay-variant-veyron-fievel/profiles/base/make.defaults
[modify] https://crrev.com/3b4ac39451a251854d17874eae4b9ba2e338d305/overlay-samus/profiles/base/make.defaults
[modify] https://crrev.com/3b4ac39451a251854d17874eae4b9ba2e338d305/overlay-kevin/profiles/base/make.defaults
[modify] https://crrev.com/3b4ac39451a251854d17874eae4b9ba2e338d305/overlay-cyan/make.conf

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5a7aaeb405bcb88a8e25c437d150db1d5ed82e1d

commit 5a7aaeb405bcb88a8e25c437d150db1d5ed82e1d
Author: Igor <igorcov@chromium.org>
Date: Tue Sep 12 11:19:31 2017

libchromeos USE flags: add arc_transition_m_to_n use flag

The flag is used to distinguish the devices that had ARC M in
version 60 and will get ARC N in version 61.

The flag used in version 60 (arc_migration_policy_check) is
removed.

BUG= chromium:722371 
TEST=none

Change-Id: I33f87d96f3e7b3c4a8dcc301a784b6734e6e229e
Reviewed-on: https://chromium-review.googlesource.com/660558
Commit-Ready: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/5a7aaeb405bcb88a8e25c437d150db1d5ed82e1d/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
[rename] https://crrev.com/5a7aaeb405bcb88a8e25c437d150db1d5ed82e1d/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r38.ebuild

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 12 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1abd794302ad4b4c8dfa252567da854c9f5e390c

commit 1abd794302ad4b4c8dfa252567da854c9f5e390c
Author: Igor <igorcov@chromium.org>
Date: Tue Sep 12 17:09:52 2017

libchromeos USE flags: add arc_transition_m_to_n use flag

The flag is used to distinguish the devices that had ARC M in
version 60 and will get ARC N in version 61.

The flag used in version 60 (arc_migration_policy_check) is
removed.

This is a cherry-pick from
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/660558

BUG= chromium:722371 
TEST=none

Change-Id: Ice89010c56277f60d7c1f172f677ea4c75c8e781
Reviewed-on: https://chromium-review.googlesource.com/663178
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>

[modify] https://crrev.com/1abd794302ad4b4c8dfa252567da854c9f5e390c/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
[rename] https://crrev.com/1abd794302ad4b4c8dfa252567da854c9f5e390c/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r38.ebuild

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a52228ac0e24908891b9de96c2bea59dc1a4c727

commit a52228ac0e24908891b9de96c2bea59dc1a4c727
Author: Igor <igorcov@chromium.org>
Date: Tue Sep 12 17:10:04 2017

libchromeos USE flags: add arc_transition_m_to_n use flag

The flag is used to distinguish the devices that had ARC M in
version 60 and will get ARC N in version 61.

The flag used in version 60 (arc_migration_policy_check) is
removed.

This is a cherry-pick from
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/660558

BUG= chromium:722371 
TEST=none

Change-Id: I30124b7d442a36a51931ec2a62589517af634cde
Reviewed-on: https://chromium-review.googlesource.com/663378
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Igor <igorcov@chromium.org>
Tested-by: Igor <igorcov@chromium.org>

[rename] https://crrev.com/a52228ac0e24908891b9de96c2bea59dc1a4c727/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r35.ebuild
[modify] https://crrev.com/a52228ac0e24908891b9de96c2bea59dc1a4c727/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified based on reviews and no issue in M67.0.3396.19 10575.18.0 dev paine.

Sign in to add a comment