Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8979519079696491744

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : performance_browser_tests
  Metric       : CastV2Performance_gpu_24fps/audio_jitter

Revision             Exit Code      N
chromium@470843      0 +- N/A       3      good
chromium@471691      0 +- N/A       3      bad

To Run This Test
  .\src\out\Release\performance_browser_tests.exe --test-launcher-print-test-stdio=always --enable-gpu

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979519079696491744

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5237982182768640


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8979512741325456160

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : performance_browser_tests
  Metric       : TabCapturePerformance/CaptureSucceeded

Revision             Exit Code      N
chromium@470843      0 +- N/A       20      good
chromium@471691      0 +- N/A       20      bad

To Run This Test
  .\src\out\Release_x64\performance_browser_tests.exe --test-launcher-print-test-stdio=always --enable-gpu

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979512741325456160

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5139345037590528


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

miu@, can you look at this failure?

This is probably a dupe of a known issue, WIP. I'm in the middle of a move right now, and don't have access to the machine I was working on, so ETA next week.

So, I thought this was related to  bug 709247 , but there was a recent "short-term" code change to fix the test breakage for that issue.

I'll have to look into this Monday...

Also, the logs show nothing. Just that the command was run and had exit status 1.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/107bc42153f7df4157a1beea973ca03bd34404d8

commit 107bc42153f7df4157a1beea973ca03bd34404d8
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri May 19 21:29:56 2017

Disable performance_browser_tests on failing bots

The failing bots are:

Mac Air 10.11 Perf 
Mac Pro 10.11 Perf
Mac Retina Perf
Win 7 ATI GPU Perf
Win 7 Nvidia GPU Perf 
Win 7 Perf

Bug:722367
Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540

NOTRY=true (since this doesn't affect any CQ test)
TBR=sullivan@chromium.org

Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
Reviewed-on: https://chromium-review.googlesource.com/509989
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#473326}
[modify] https://crrev.com/107bc42153f7df4157a1beea973ca03bd34404d8/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/107bc42153f7df4157a1beea973ca03bd34404d8/tools/perf/core/perf_data_generator.py

nednguyen: Please either supply test logs for these failing tests, or re-enable them and fix the infra issue preventing us from getting logs. There is nothing I can do to fix the problem without this information. :)

Furthermore, while the tests may return a fail status, are they still producing measurements? If so, let's leave them running. I can put in a quick fix to make the bots turn green, if need be. I'd really hate to stop all monitoring if it is just one out of the several measurements that is failing.

The test log is already fixed in https://codereview.chromium.org/2889153007/

You can try to reenable the test and see what's failing.

https://chromium-review.googlesource.com/c/511462 reenable the tests. Please fix the failing tests as soon as you see the log.

FWIW, the fix for  bug 709247  is in code review right now. It might turn out to fix this issue as well. Thanks for being patient w/ us! :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d47b5db0e581826d6a37b4448cc0509c7fc5472

commit 4d47b5db0e581826d6a37b4448cc0509c7fc5472
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue May 23 02:12:55 2017

Revert "Disable performance_browser_tests on failing bots"

This reverts commit 107bc42153f7df4157a1beea973ca03bd34404d8.

Reason for revert: reenable the benchmark to see which tests are failing.

Original change's description:
> Disable performance_browser_tests on failing bots
> 
> The failing bots are:
> 
> Mac Air 10.11 Perf 
> Mac Pro 10.11 Perf
> Mac Retina Perf
> Win 7 ATI GPU Perf
> Win 7 Nvidia GPU Perf 
> Win 7 Perf
> 
> Bug:722367
> Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
> 
> NOTRY=true (since this doesn't affect any CQ test)
> TBR=sullivan@chromium.org
> 
> Change-Id: Iffb4d077312a69c3fb2386603183c3737ecb6540
> Reviewed-on: https://chromium-review.googlesource.com/509989
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#473326}

TBR=nednguyen@google.com,martiniss@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug:722367

Change-Id: Ife4777108c4318b808d7bf1f8b9ffe2a9dda1ec1
Reviewed-on: https://chromium-review.googlesource.com/511462
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#473786}
[modify] https://crrev.com/4d47b5db0e581826d6a37b4448cc0509c7fc5472/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/4d47b5db0e581826d6a37b4448cc0509c7fc5472/tools/perf/core/perf_data_generator.py

Okay, CL was LGTM'ed. Confirming the tests work after rebasing to ToT before commit.

Win tests are fixed by change currently almost through the CQ: https://codereview.chromium.org/2866943002/

Mac tests are fixed by a separate change in code review now: https://codereview.chromium.org/2901113003/

 Issue 715965  has been merged into this issue.

 Issue 726834  has been merged into this issue.

miu@, performance_browser_test is failing completely on " Mac Air 10.11 Perf" config. We will disable it on this config.

https://chromium-swarm.appspot.com/task?id=3670c0a516b14910&refresh=10&show_raw=1

[19/19] TabCapturePerformanceTest.Performance/7 (331 ms)
19 tests failed:
    CastV2PerformanceTest.Performance/0 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/1 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/10 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/2 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/3 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/4 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/5 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/6 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/7 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/8 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    CastV2PerformanceTest.Performance/9 (../../chrome/browser/extensions/api/cast_streaming/performance_test.cc:706)
    TabCapturePerformanceTest.Performance/0 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/1 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/2 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/3 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/4 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/5 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/6 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)
    TabCapturePerformanceTest.Performance/7 (../../chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc:300)

That's fine. FWIW, the fix has been in code review for about a week now: https://codereview.chromium.org/2901113003/

Actually, if you haven't disabled it yet, I think I'll CQ it right now to reduce churn. There's nothing complicated about my fix.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e0e80c3608ac2a08e87ead7d103578f6751f2f6

commit 8e0e80c3608ac2a08e87ead7d103578f6751f2f6
Author: miu <miu@chromium.org>
Date: Wed May 31 03:35:57 2017

Fix breakages while performance_browser_tests was not running on Mac.

In our vain attempt to re-enable performance_browser_tests on the Mac
bots, a number of breakages seem to have happened over the months where
we were not even aware the tests weren't running.

This change fixes all of the following:

1. Adds a BUILD dependency on //chrome:chrome_app. Without this, the
test binary would be missing many runtime dependencies (e.g., the whole
"Chrome Framework" bundle).

2. Migrate MachPortsTest to use BrowserTestBase::embedded_test_server()
instead of its own server of "fake content" for its browser tests.

3. Add base::ScopedAllowIO for a test utility class that creates and
tears down its own set of threads. It's not clear why the thread
restriction is only checked on Mac (perhaps it's in the way the
browser test's main thread is set up?). Nevertheless, it's perfectly
reasonable for the main thread to block on stopping these other threads:
After the test has run, the threads are shut down before the data
analysis begins, since we want to be sure the data sets are no longer
mutating. Also, added PRESUBMIT.py exception for this use case.

BUG=697444, 722367 
TBR=nduca

Review-Url: https://codereview.chromium.org/2901113003
Cr-Commit-Position: refs/heads/master@{#475773}

[modify] https://crrev.com/8e0e80c3608ac2a08e87ead7d103578f6751f2f6/PRESUBMIT.py
[modify] https://crrev.com/8e0e80c3608ac2a08e87ead7d103578f6751f2f6/chrome/test/BUILD.gn
[modify] https://crrev.com/8e0e80c3608ac2a08e87ead7d103578f6751f2f6/chrome/test/perf/mach_ports_performancetest.cc
[modify] https://crrev.com/8e0e80c3608ac2a08e87ead7d103578f6751f2f6/media/cast/test/utility/standalone_cast_environment.cc

Closing-out old bug. The change in comment 25 fixed the issue.