New issue
Advanced search Search tips

Issue 722318 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: 1
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

APKs can't be built without depot_tools

Reported by jho...@akamai.com, May 15 2017

Issue description

Hi,
there is unused python import 'resource_sizes' in build/android/gyp/finalize_apk.py which tries to locate depot_tools and if not found an exception is thrown.

The python import 'resource_sizes' is unused and APKs creation works fine without it.

As you can see below in the diff the import is marked as unused by pylint too:


==== build/android/gyp/finalize_apk.py ====

@@ -17,7 +17,6 @@
 # resource_sizes modifies zipfile for zip64 compatibility. See
 # https://bugs.python.org/issue14315.
 sys.path.append(os.path.join(os.path.dirname(__file__), os.pardir))
-import resource_sizes  # pylint: disable=unused-import
 
 from util import build_utils



Please remove the import because we use Quic protocol from chromium with essential unittests and we must patch this file on our own.

 
Labels: TE-NeedsTriageHelp
Components: Infra>SDK
EstimatedDays: 1
Labels: -TE-NeedsTriageHelp
Status: WontFix (was: Unconfirmed)
***Bulk edit***

Closing due to inactivity, please feel free to reopen if needed.

Sign in to add a comment