New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722316 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

French keyboard mapping returns 'dot' rather 'comma' when pressing decimal separator on the numerical keypad

Reported by vpalatin@chromium.org, May 15 2017

Issue description

Chrome Version: 60.0.3092.0
OS: Chrome OS 9532.0

What steps will reproduce the problem?
(1) Plug an external USB keyboard with Azerty/FR mapping
(2) Select 'French keyboard' in Settings/Input method
(3) On the numeric keypad, press the '. Suppr' key (below the '3' key)

What is the expected result?

this should input a ',' character (comma)

What happens instead?

It's inputting a '.' character (dot)


The French locale uses a comma as decimal separator, but keyboards are labeled with a period. The '.' key on the numeric keypad should still be mapped as the locale decimal separator as done on other OSes.

This is done on the non-official french layout:
cf https://cgit.freedesktop.org/xkeyboard-config/tree/symbols/fr#n398
but not the one we are using.

As advised in https://bugs.chromium.org/p/chromium/issues/detail?id=335644#c37,
we should add "include kpdl(comma)" in the fr mapping.
 
Cc: shuchen@chromium.org
I have uploaded a CL to do it :
https://chromium-review.googlesource.com/506089 xkeyboard-config: map decimal separator to comma on FR keyboard

Comment 2 Deleted

Cc: bleung@chromium.org dtor@chromium.org adlr@chromium.org
Adding a few more (non-UI) input guys, not sure who is supposed to review this or owning it.

Comment 4 by bleung@chromium.org, May 15 2017

Cc: kroot@chromium.org

Comment 5 by bleung@chromium.org, May 15 2017

Cc: -bleung@chromium.org abodenha@chromium.org
Owner: benchan@chromium.org
Status: Assigned (was: Untriaged)
Grasping at straws on this one.  Over to benchan@ who sorted out keyboard mapping issues on falco recently.
Cc: -vpalatin@chromium.org benchan@chromium.org
Owner: vpalatin@chromium.org
Assign to +vpalatin, who has prepared a CL for that
I don't mind owning the bug, but I still need to find an owner for the package to put a +2 on the CL.
Project Member

Comment 9 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/34ca8788167d822d5ae9552b848e840c397e1332

commit 34ca8788167d822d5ae9552b848e840c397e1332
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Wed May 24 21:24:05 2017

xkeyboard-config: map decimal separator to comma on FR keyboard

The French locale uses a comma as decimal separator, but keyboards are
labeled with a period. The '.' key on the numeric keypad should still be
mapped as the locale decimal separator as done on other OSes.

BUG= chromium:722316 
TEST=manual: plug an external USB keyboard and press the '.' on the
numeric keypad, get a comma.

Change-Id: I5839d7d7a1e8137a6a4dd699799a706a2c616595
Reviewed-on: https://chromium-review.googlesource.com/506089
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/34ca8788167d822d5ae9552b848e840c397e1332/x11-misc/xkeyboard-config/xkeyboard-config-2.15.ebuild
[add] https://crrev.com/34ca8788167d822d5ae9552b848e840c397e1332/x11-misc/xkeyboard-config/files/xkeyboard-config-2.15-fr-keypad-comma.patch
[rename] https://crrev.com/34ca8788167d822d5ae9552b848e840c397e1332/x11-misc/xkeyboard-config/xkeyboard-config-2.15-r2.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/34ca8788167d822d5ae9552b848e840c397e1332

commit 34ca8788167d822d5ae9552b848e840c397e1332
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Wed May 24 21:24:05 2017

xkeyboard-config: map decimal separator to comma on FR keyboard

The French locale uses a comma as decimal separator, but keyboards are
labeled with a period. The '.' key on the numeric keypad should still be
mapped as the locale decimal separator as done on other OSes.

BUG= chromium:722316 
TEST=manual: plug an external USB keyboard and press the '.' on the
numeric keypad, get a comma.

Change-Id: I5839d7d7a1e8137a6a4dd699799a706a2c616595
Reviewed-on: https://chromium-review.googlesource.com/506089
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/34ca8788167d822d5ae9552b848e840c397e1332/x11-misc/xkeyboard-config/xkeyboard-config-2.15.ebuild
[add] https://crrev.com/34ca8788167d822d5ae9552b848e840c397e1332/x11-misc/xkeyboard-config/files/xkeyboard-config-2.15-fr-keypad-comma.patch
[rename] https://crrev.com/34ca8788167d822d5ae9552b848e840c397e1332/x11-misc/xkeyboard-config/xkeyboard-config-2.15-r2.ebuild

Status: Fixed (was: Assigned)
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment