New issue
Advanced search Search tips

Issue 722305 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Blink-Paint



Sign in to add a comment

Spec change: Limit DOMMatrix's special stringifier to Window

Reported by sim...@opera.com, May 15 2017

Issue description

https://github.com/w3c/fxtf-drafts/issues/145
https://github.com/w3c/fxtf-drafts/pull/151
https://github.com/w3c/web-platform-tests/pull/5895

In workers a DOMMatrix should stringify to "[object DOMMatrix]" instead of "matrix(...)".
 

Comment 1 by fs...@chromium.org, May 15 2017

Cc: -fs...@chromium.org
Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fs...@chromium.org, Jun 28 2017

Status: Started (was: Assigned)

Comment 3 by fs...@chromium.org, Jun 28 2017

The tests for this are not finalized, but I'll update the IDL anyway.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/668e108d975f27413dbf9487ec51ed78da6f0ed4

commit 668e108d975f27413dbf9487ec51ed78da6f0ed4
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue Jul 04 19:00:33 2017

Limit DOMMatrix stringifier to Window

Bug:  722305 
Change-Id: Ifb0894077e5245b6b6bfd666e5e208ecb46bde49
Reviewed-on: https://chromium-review.googlesource.com/552501
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#484141}
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/Source/core/geometry/DOMMatrix.idl
[modify] https://crrev.com/668e108d975f27413dbf9487ec51ed78da6f0ed4/third_party/WebKit/Source/core/geometry/DOMMatrixReadOnly.idl

Comment 5 by fs...@chromium.org, Jul 4 2017

Status: Fixed (was: Started)

Sign in to add a comment