Issue metadata
Sign in to add a comment
|
MD Bookmarks: Keyboard shortcuts should not trigger when dialogs/input fields are focused
Reported by
abom...@etouch.net,
May 15 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:60.0.3100.0 (Official Build) f472642fd6c20b63b0f1a2f62564f2aad56f4be3-refs/heads/master@{#471639} OS: MAC (10.12.3, 10.11.6) Pre-condition: 1. Enable Material Design bookmarks flag. 2. Bookmark any webpage or Ntp What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://bookmarks/?id=1#1 2. Click on ‘More Action icon’ and select ‘Edit’ option such that overlay is seen. 3. Edit the Name and try to hit ‘Enter’ from keyboard. 4. Repeat step 1 & 2 and then hit Backspace key from keyboard ,observe. Actual: 1. After step 3, edited name is not saved.(i.e Enter key is not working) 2. After step 4, Unnecessary bookmark is removed but overlay is seen. Expected: 1. After step 3, Edited name should be saved. 2, After step 4, Bookmark should not be removed. This is regression issue, broken in ‘M 60’ and below is manual bisect: Good build:60.0.3090.0 Bad build:60.0.3091.0 Note: Issue is not seen on Windows and Linux OS.
,
May 15 2017
MD Bookmarks is behind a runtime flag => Not a P1.
,
May 17 2017
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd commit 6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd Author: tsergeant <tsergeant@chromium.org> Date: Tue Jun 06 23:53:02 2017 MD Bookmarks: Improve keyboard shortcut targeting Keyboard shortcuts are no longer triggered by a global event listener looking at all events on the page. Instead, we process keyboard shortcuts as part of the existing input processing for the tree and the list, with an additional listener to pick up any key presses while nothing is focused. This has two benefits: 1. Pressing a keyboard shortcut with a sidebar folder focused will process shortcut for that node, rather than for the list selection. 2. Keyboard shortcuts will no longer activate when dialogs/buttons/input fields are active BUG= 722300 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2885353002 Cr-Commit-Position: refs/heads/master@{#477468} [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/browser/resources/md_bookmarks/folder_node.html [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/browser/resources/md_bookmarks/folder_node.js [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/browser/resources/md_bookmarks/list.js [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/test/data/webui/md_bookmarks/command_manager_test.js [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js [modify] https://crrev.com/6c3a6dffe1ba6e9f3594f43a47c31e885cf5ffbd/chrome/test/data/webui/md_bookmarks/toolbar_test.js
,
Jun 14 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abom...@etouch.net
, May 15 2017Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)