New issue
Advanced search Search tips

Issue 722239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.2% regression in speedometer at 471272:471287

Project Member Reported by mvstanton@google.com, May 15 2017

Issue description

Regression across speedometer, also runtime callstats
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=722239

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg6vzDrAoM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
The roll includes an update of V8 to version 6.0.191.
There were confusing rolls in and out of Chromium, but it looks like the problem started after 6.0.189.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 16 2017

Cc: rmcilroy@chromium.org
Owner: rmcilroy@chromium.org

=== Auto-CCing suspected CL author rmcilroy@chromium.org ===

Hi rmcilroy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : 11a211ff1b81e8d83d1aa4898743c2efb89603bd
  Date   : Wed May 10 15:04:35 2017
  Subject: Reland: [TypeFeedbackVector] Store optimized code in the vector

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : speedometer
  Metric       : React-TodoMVC/React-TodoMVC
  Change       : 3.35% | 6893.09537037 -> 7123.92555556

Revision                           Result                  N
chromium@471271                    6893.1 +- 370.347       9      good
chromium@471279                    6797.4 +- 81.7404       6      good
chromium@471280                    6857.32 +- 105.022      6      good
chromium@471280,v8@5c66d6fcd4      6871.55 +- 142.09       6      good
chromium@471280,v8@cf37556f0e      6869.28 +- 59.5746      6      good
chromium@471280,v8@69c6970fae      6869.27 +- 153.451      6      good
chromium@471280,v8@2026d5cb79      6891.43 +- 194.036      6      good
chromium@471280,v8@93fff34eaa      6856.05 +- 222.663      6      good
chromium@471280,v8@11a211ff1b      7088.24 +- 111.07       6      bad       <--
chromium@471280,v8@f86985ad11      7159.31 +- 188.28       6      bad
chromium@471281                    7120.86 +- 201.294      6      bad
chromium@471283                    7099.78 +- 178.446      6      bad
chromium@471287                    7123.93 +- 200.002      9      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979543255413991168

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5819243628593152


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, May 16 2017

Cc: mvstanton@google.com
 Issue 722350  has been merged into this issue.
Status: Fixed (was: Assigned)
Fixed after the roll in r471865.

Sign in to add a comment