New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722223 link

Starred by 4 users
Status: Fixed
Owner:
einbinder@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
nyerramilli@chromium.org
█ brajkumar@chromium.org
caseq@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
einbinder@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Devtools 'X' (Close) icon disappears after entering random characters in Console section.

Reported by avsha...@etouch.net, May 15 2017 
Chrome Version : 60.0.3100.0 (Official Build) f472642fd6c20b63b0f1a2f62564f2aad56f4be3-refs/heads/master@{#471639} 32/64 bit
OS : Windows (7,8,10), Linux (14.04 LTS), Mac (10.12.3, 10.11.6)

What steps will reproduce the problem?
1. Launch chrome, open devtools on NTP and navigate to 'Console' section.
2. In console area, type "gh" and hit Enter key such that red error icon appears in toolbar. 
3. Observe the 'X' (Close) button of devtools.

Actual : Devtools 'X' (Close) icon disappears after entering random characters in Console section.

Expected : Close 'X' icon should not disappear after typing random characters in Console section.

This is a regression issue broken in ‘M-60’, below is the Manual Regression range and will soon update other info.
Good build : 60.0.3097.0
Bad build : 60.0.3098.0
Actual_Result.mp4
1.2 MB View Download
Expected_Result.mp4
638 KB View Download

Comment 1 by avsha...@etouch.net, May 15 2017

Cc: caseq@chromium.org
Labels: hasbisect
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/ac1414588aedb11ae6a11223c7c3cca1057a4773..9f244bd91e540e716aa156a4ee29cfb47558fed4?pretty=fuller&n=10000

Suspecting : r 471208 from Narrow Bisect 

@einbinder : Could you please look into the issue and if possible please help to assign it to concern owner.

Thank you!

Comment 2 by msrchandra@chromium.org, May 15 2017

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9847aeaf079339c729859157552eabde17ae3b17

commit 9847aeaf079339c729859157552eabde17ae3b17
Author: einbinder <einbinder@chromium.org>
Date: Tue May 16 01:39:34 2017

DevTools: Remove contain strict from toolbars

Some toolbars don't take up the full width of their parent, so we can't use
contain strict on them.

BUG= 722223 ,  722203 

Review-Url: https://codereview.chromium.org/2888453002
Cr-Commit-Position: refs/heads/master@{#471976}

[modify] https://crrev.com/9847aeaf079339c729859157552eabde17ae3b17/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 4 by einbinder@chromium.org, May 16 2017

Status: Fixed (was: Assigned)

Comment 5 by einbinder@chromium.org, May 16 2017

Cc: kavvaru@chromium.org brajkumar@chromium.org einbinder@chromium.org ajha@chromium.org
 Issue 722736  has been merged into this issue.

Comment 6 by sureshkumari@chromium.org, May 23 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3107.4
Tested the issue on windows 7, Mac 10.12.4 and Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
722223.mov
3.9 MB Download

Comment 7 by einbinder@chromium.org, May 23 2017 

 Issue 722306  has been merged into this issue.
►

Sign in to add a comment