New issue
Advanced search Search tips

Issue 722178 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add metrics to determine why WebAPK installs are slow

Project Member Reported by pkotw...@chromium.org, May 15 2017

Issue description

Add client side UMA metrics to determine why WebAPK installs are slow

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5413280afdd44bd90e6dc90bd7a09090a9743290

commit 5413280afdd44bd90e6dc90bd7a09090a9743290
Author: pkotwicz <pkotwicz@chromium.org>
Date: Tue May 16 16:21:25 2017

Remove ChromeWebApkHost::GetGooglePlayInstallState() check from WebApkInstaller

In the install path:
GetGooglePlayInstallState() == GooglePlayInstallState::SUPPORTED
is checked via ChromeWebApkHost::CanCanInstallWebApk() in
add_to_homescreen_manager.cc and app_banner_manager_android.cc

In the update path:
GetGooglePlayInstallState() == GooglePlayInstallState::SUPPORTED
is not checked. However:
- it should be impossible for the WebAPK to be installed if
  ChromeWebApkHost::CanCanInstallWebApk() does not return true
- updates don't show any UI

BUG= 722178 

Review-Url: https://codereview.chromium.org/2882243002
Cr-Commit-Position: refs/heads/master@{#472126}

[modify] https://crrev.com/5413280afdd44bd90e6dc90bd7a09090a9743290/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/5413280afdd44bd90e6dc90bd7a09090a9743290/chrome/browser/android/webapk/webapk_installer.h
[modify] https://crrev.com/5413280afdd44bd90e6dc90bd7a09090a9743290/chrome/browser/android/webapk/webapk_installer_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9e46d37881ab3479d625ed0c9170e1d93f2605

commit 1d9e46d37881ab3479d625ed0c9170e1d93f2605
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed May 24 14:52:22 2017

Add more WebAPK install metrics

This CL adds metrics for:
- The duration of the processing prior to binding to the Play Install service.
  This includes computing the icon hashes and requesting the token from the
  WebAPK server.
- The amount of time that binding to the Play Install service takes

BUG= 722178 

Review-Url: https://codereview.chromium.org/2883843002
Cr-Commit-Position: refs/heads/master@{#474287}

[modify] https://crrev.com/1d9e46d37881ab3479d625ed0c9170e1d93f2605/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
[modify] https://crrev.com/1d9e46d37881ab3479d625ed0c9170e1d93f2605/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/1d9e46d37881ab3479d625ed0c9170e1d93f2605/chrome/browser/android/webapk/webapk_metrics.cc
[modify] https://crrev.com/1d9e46d37881ab3479d625ed0c9170e1d93f2605/chrome/browser/android/webapk/webapk_metrics.h
[modify] https://crrev.com/1d9e46d37881ab3479d625ed0c9170e1d93f2605/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, May 27 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ab129a68925a0ff840402665d12a9d2e3af78c6a

commit ab129a68925a0ff840402665d12a9d2e3af78c6a
Author: Peter Kotwicz <pkotwicz@google.com>
Date: Sat May 27 02:02:24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment