New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 722146 link

Starred by 2 users
Status: Fixed
Owner:
aleventhal@chromium.org
Closed: May 2017
Cc:
█ nek...@chromium.org
aboxhall@chromium.org
lpalmaro@chromium.org
aleventhal@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Name calculation should not include nameFrom:author descendants.

Project Member Reported by aleventhal@chromium.org, May 14 2017 
When computing nameFrom:contents, do not include descendant content for descendants that are not also nameFrom:contents.

For example, the treeitem in this example should have an accessible name of just 'A': 
<div role="treeitem>
  A
  <div role="group>
    B
  </div>
</div>
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70906e105560268db0efb67c3e072265e3d9582

commit b70906e105560268db0efb67c3e072265e3d9582
Author: aleventhal <aleventhal@chromium.org>
Date: Thu May 18 23:41:10 2017

Name calculation should not include nameFrom:author descendants.
Also, listitem should not compute name from descendants.

There are still a couple of failing tests that don't look related.

BUG= 722145 , 722146 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true

Review-Url: https://codereview.chromium.org/2867073003
Cr-Commit-Position: refs/heads/master@{#472972}

[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/chrome/test/data/extensions/api_test/automation/sites/tree_change.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/accessibility_ipc_error_browsertest.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/browser_accessibility_auralinux.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/browser_accessibility_com_win.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/browser_accessibility_manager_unittest.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/hit_testing_browsertest.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/browser/accessibility/snapshot_ax_tree_browsertest.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-activedescendant-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-atomic-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-atomic-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-details-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-dropeffect-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-dropeffect-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-errormessage-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-grabbed-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-grabbed-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-hidden-iframe-body-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-keyshortcuts-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-level-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-level-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-owns-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/aria-owns-list-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/aria/input-text-aria-placeholder-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/css/color-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/css/font-style-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/event/add-hidden-attribute-subtree-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/event/add-subtree-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/event/remove-hidden-attribute-subtree-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/event/remove-subtree-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/a-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/action-verbs-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/div-expected-android.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/div-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/div-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/div.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/iframe-coordinates-cross-process-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/iframe-coordinates-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/iframe-cross-process-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/iframe-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/iframe-transform-scrolled-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/img-empty-alt-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/img-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/img-link-empty-alt-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/in-page-links-expected-blink.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/li-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/li-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/list-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/list-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/list-markers-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/list-markers-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/ol-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/ol-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/ul-expected-mac.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/content/test/data/accessibility/html/ul-expected-win.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/aria-owns.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/chromium-only-roles-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/chromium-only-roles.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/description-calc-aria-describedby.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/div-within-anchors-causes-crash-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/focusable-div-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/focusable-div.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/image-map2-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/in-page-link-target.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/legend-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/listitem-presentation-inherited-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/listitem-presentation-inherited.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-label.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/name-calc-aria-labelledby.html
[add] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/name-calc-group-inside-treeitem.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/name-calc-visibility.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/presentational-leaf.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/role-attribute-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/scroll-div-horiz-sends-notification.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/scroll-div-sends-notification.html
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/table-detection-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/table-with-aria-role-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/accessibility/table-with-rules-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-labelledby-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/LayoutTests/platform/win/inspector-protocol/accessibility/accessibility-ignoredNodes-expected.txt
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXMenuList.h
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/third_party/WebKit/public/web/WebAXEnums.h
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/b70906e105560268db0efb67c3e072265e3d9582/ui/accessibility/platform/ax_platform_node_win.cc

Comment 2 by aleventhal@chromium.org, May 18 2017

Status: Fixed (was: Started)

Comment 3 by aleventhal@chromium.org, Jul 31 2017

Cc: lpalmaro@chromium.org nek...@chromium.org aboxhall@chromium.org aleventhal@chromium.org dmazz...@chromium.org
 Issue 645546  has been merged into this issue.
►

Sign in to add a comment