Sometimes the paint invalidation reason is "image" instead of expected "full". Should update the test to ensure the paint invalidation is caused by image change, so that we always get "image" reason.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d70b2b0e923c17a69ca47b24888cdd20ef177b3 commit 0d70b2b0e923c17a69ca47b24888cdd20ef177b3 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sun May 14 19:10:06 2017 Mark paint/invalidation/svg/image-animation-with-zoom.html flaky BUG= 722131 TBR=wangxianzhu@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2877313002 Cr-Commit-Position: refs/heads/master@{#471637} [modify] https://crrev.com/0d70b2b0e923c17a69ca47b24888cdd20ef177b3/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6e599fe4496e4f1aefdff8e73d1697f2d9da6b0 commit b6e599fe4496e4f1aefdff8e73d1697f2d9da6b0 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Tue May 16 18:23:22 2017 Deflake paint/invalidation/svg/image-animation-with-zoom.html It had been flaky after https://codereview.chromium.org/2872423002/ which defined PaintInvalidationReason::kImage for invalidations caused by image change. The test sometimes produced "full" and sometimes produced "image" as the invalidation reason of the image. The flakiness might be because of arbitrary timing of image animation. - Add image onload handler to start the test; - Advance image animation twice to avoid flakiness. - Convert it into a ref test. - Increase the size of the image to avoid the layout from being affected by different font sizes on different platforms. BUG= 722131 Review-Url: https://codereview.chromium.org/2882873002 Cr-Commit-Position: refs/heads/master@{#472165} [modify] https://crrev.com/b6e599fe4496e4f1aefdff8e73d1697f2d9da6b0/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/b6e599fe4496e4f1aefdff8e73d1697f2d9da6b0/third_party/WebKit/LayoutTests/paint/invalidation/svg/image-animation-with-zoom-expected.html [delete] https://crrev.com/13ae67b02915295a69a6ceea4ba8c7552b4f29cc/third_party/WebKit/LayoutTests/paint/invalidation/svg/image-animation-with-zoom-expected.txt [modify] https://crrev.com/b6e599fe4496e4f1aefdff8e73d1697f2d9da6b0/third_party/WebKit/LayoutTests/paint/invalidation/svg/image-animation-with-zoom.html [modify] https://crrev.com/b6e599fe4496e4f1aefdff8e73d1697f2d9da6b0/third_party/WebKit/LayoutTests/paint/invalidation/svg/resources/animate-center.svg [delete] https://crrev.com/13ae67b02915295a69a6ceea4ba8c7552b4f29cc/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/image-animation-with-zoom-expected.txt [delete] https://crrev.com/13ae67b02915295a69a6ceea4ba8c7552b4f29cc/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/svg/image-animation-with-zoom-expected.txt [delete] https://crrev.com/13ae67b02915295a69a6ceea4ba8c7552b4f29cc/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/svg/image-animation-with-zoom-expected.txt [delete] https://crrev.com/13ae67b02915295a69a6ceea4ba8c7552b4f29cc/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/image-animation-with-zoom-expected.txt
Comment 1 by bugdroid1@chromium.org
, May 14 2017