"isolate" is flaky (test_data/chrome/browser/resources/print_preview: no such file or directory) |
||||
Issue description"isolate" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyEgsSBUZsYWtlIgdpc29sYXRlDA. The chromium-try-flakes app is able to file bugs for individual tests when the test launcher is uploading results to the Test Results Server. If recent flakes above are caused by failing tests and you would like to have them filed as invidual bugs, please read more at https://goo.gl/QJKXV4. This flaky test/step was previously tracked in issue 671592 .
,
May 15 2017
earliest reports tsan: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/74034 - r471636 asan: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369377 - r471327 r471082 - maruel r470413 - rbpotter r373668 - jbudorick
,
May 15 2017
I suspect this is happening because of r470637 "Reland of: WebUI: Disable all JS tests in MSAN, ASAN, and TSAN bots." If the targets are not built but they're still listed in an isolate file there may be badness.
,
May 15 2017
Also pretty consistently broken on https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FCrWinAsan%2F5016%2F%2B%2Frecipes%2Fsteps%2Fisolate_tests%2F0%2Fstdout Can we get this fixed today, please?
,
May 15 2017
,
May 15 2017
@thakis: I'll take a look. There seems to be some obsolete reference to print_preview from some isolate test config file to a target that no longer exists in ASAN bots.
,
May 15 2017
,
May 15 2017
That's what adds the dep to the isolate, yes. In a few minutes of looking, I couldn't find what's supposed to generate that directory though.
,
May 15 2017
I think it is js2gtest.gni that generates the test_data directory [1]. Now that all the js2gtest targets are not run in ASAN/MSAN/TSAN, those files are not there anymore. [1] https://cs.chromium.org/chromium/src/chrome/test/base/js2gtest.gni?q=test_data+test_api.js&dr=C&l=29
,
May 15 2017
Perhaps https://codereview.chromium.org/2886493002 would fix the issue (have not tried yet).
,
May 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0712667572b158d0613b5f5a2ec8fa6f61cada34 commit 0712667572b158d0613b5f5a2ec8fa6f61cada34 Author: dpapad <dpapad@chromium.org> Date: Mon May 15 19:10:55 2017 Fix isolate tests flakiness because of test_data/chrome/browser/resources/print_preview. BUG= 722123 Review-Url: https://codereview.chromium.org/2886493002 Cr-Commit-Position: refs/heads/master@{#471856} [modify] https://crrev.com/0712667572b158d0613b5f5a2ec8fa6f61cada34/chrome/test/BUILD.gn
,
May 15 2017
Marking this as fixed. Please re-open if the flakiness continues. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, May 15 2017Summary: "isolate" is flaky (test_data/chrome/browser/resources/print_preview: no such file or directory) (was: "isolate" is flaky)
The errors go 22:48:59.201152 Unable to walk "/b/c/b/linux_chromium_tsan_rel_ng/src/out/Release/test_data/chrome/browser/resources/print_preview": walk("/b/c/b/linux_chromium_tsan_rel_ng/src/out/Release/test_data/chrome/browser/resources/print_preview"): lstat /b/c/b/linux_chromium_tsan_rel_ng/src/out/Release/test_data/chrome/browser/resources/print_preview: no such file or directory step returned non-zero exit code: 1