New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722039 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 16 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Sometimes the phone number is not validated against the currently selected country.

Project Member Reported by mad@chromium.org, May 13 2017

Issue description

The Phone entry is still broken, even though the IsValid returns true, SetInfo returns false, so the OK button doens't save and close the view.
 

Comment 1 by mad@chromium.org, May 15 2017

Summary: Sometimes the phone number is not validated against the currently selected country. (was: The OK button of the shipping address dialog doesn't work anymore.)
I found some scenarion where this works properly (e.g., it almost always works for US/Canada), but it often doesn't work when we select a country that has a phone number format that is different from US/Canada.

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09f15955329247e16c8547119e326ac8f35a269c

commit 09f15955329247e16c8547119e326ac8f35a269c
Author: mad <mad@chromium.org>
Date: Thu May 18 06:33:58 2017

Payment request shipping address editor now properly handles countries

The autofill profile needs the country to be set before other fields so that they can be properly internaionalized.

And the country must be set using its internationalized name (as opposed to country code) when using the SetInfo method.

BUG= 722039 , 722452 

Review-Url: https://codereview.chromium.org/2883333003
Cr-Commit-Position: refs/heads/master@{#472708}

[modify] https://crrev.com/09f15955329247e16c8547119e326ac8f35a269c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/09f15955329247e16c8547119e326ac8f35a269c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/09f15955329247e16c8547119e326ac8f35a269c/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Comment 3 by mad@chromium.org, May 18 2017

Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment