New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 722021 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::NinePieceImageGrid::SetDrawInfoCorner

Project Member Reported by ClusterFuzz, May 13 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6333812199129088

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::NinePieceImageGrid::SetDrawInfoCorner
  blink::NinePieceImageGrid::GetNinePieceDrawInfo
  PaintPieces
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=470545:470729

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6333812199129088


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 Deleted

Cc: msrchandra@chromium.org
Components: Blink>Paint
Labels: M-60 Test-Predator-Correct-CLs
Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: eae
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/7b05f774342393172073a9da34325957dde1d007
Time: Wed May 10 16:14:04 2017
Lines 33-55, 88-93, 103 of file NinePieceImagePainter.cpp which potentially caused crash are changed in this cl (frame #2, "PaintPieces"; frame #3, "blink::NinePieceImagePainter::Paint"). 

Lines 857 of file BoxPainter.cpp which potentially caused crash are changed in this cl (frame #4, "blink::BoxPainter::PaintNinePieceImage").
Minimum distance from crash line to modified line: 0. (file: BoxPainter.cpp, crashed on: 857, modified: 857).

@eae -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 3 by e...@chromium.org, May 16 2017

Doesn't look like it was caused by my change but I'll look into it. Pretty familiar with the code by now :)

Project Member

Comment 4 by ClusterFuzz, Oct 1 2017

Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Comment 6 by e...@chromium.org, Feb 27 2018

Status: WontFix (was: Assigned)
Non security int overflow bugs are considered WontFix for most blink code.
Project Member

Comment 7 by ClusterFuzz, Mar 6 2018

Labels: Needs-Feedback
ClusterFuzz testcase 6333812199129088 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.
Labels: ClusterFuzz-Ignore
Project Member

Comment 9 by ClusterFuzz, Apr 10 2018

ClusterFuzz has detected this issue as fixed in range 549059:549062.

Detailed report: https://clusterfuzz.com/testcase?key=6333812199129088

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::NinePieceImageGrid::SetDrawInfoCorner
  blink::NinePieceImageGrid::GetNinePieceDrawInfo
  PaintPieces
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=470545:470729
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6333812199129088

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Apr 10 2018

ClusterFuzz has detected this issue as fixed in range 549059:549062.

Detailed report: https://clusterfuzz.com/testcase?key=6333812199129088

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::NinePieceImageGrid::SetDrawInfoCorner
  blink::NinePieceImageGrid::GetNinePieceDrawInfo
  PaintPieces
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=470545:470729
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6333812199129088

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment