New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 721998 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

SVG not showing some CSS properties when selected in dev tools

Reported by n...@natcooper.com, May 13 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
1. Inspect an SVG 
2. Attempt to change it's "top" value in dev tools
3. Only "stop-color" and "stop-opacity" are available in the drop-down options

What is the expected behavior?
The CSS "top" property should still be available for SVG elements, in addition to the SVG specific CSS properties

What went wrong?
It appears that the dev tools only give the user SVG specific CSS properties when SVG elements are selected. It should also give the original, standard CSS properties that apply (positioning, in this example).

Did this work before? Yes not sure

Chrome version: 57.0.2987.133  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: 

This is my first bug report - hope it's enough info! Thanks for everything you do!!! <3
 

Comment 2 by woxxom@gmail.com, May 13 2017

Bisect: 438100 (good) - 438104 (bad), 57.0.2951.0
https://chromium.googlesource.com/chromium/src/+log/06e983db..d67e6b30?pretty=fuller
Suspecting r438101 "DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes"
(specifically [1]) 

Repro:
1. open github.com
2. rightclick the site logo, Inspect
3. click } under "element.style {" in the Styles sub-panel
4. type "to" without quotes

EXPECTED: autocomplete dropdown shows "top" and like 10 other properties
OBSERVED: autocomplete dropdown shows only 3 svg-specific properties

  [1]: https://codereview.chromium.org/2571713002/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Comment 3 by woxxom@gmail.com, May 13 2017

It should be noted that the bug was never fixed since and is observed in the latest Chrome canary 60 just the same.
Labels: Needs-Milestone
Cc: kkaluri@chromium.org
Labels: -Needs-Milestone hasbisect-per-revision M-60 OS-Linux OS-Windows
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.4 with Chrome stable #58.0.3029.110, Canary #60.0.3097.0
Issue Broken in M57.

Bisect Info:
===========
Good build : 57.0.2950.0 ,  Revision Range - 438011
Bad build  : 57.0.2951.0 ,  Revision Range - 438385

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/06e983db9148e48240a93cf44407296b6ca267dd..701e91a6709bb7849e51c8597da8e754079087e6

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/701e91a6709bb7849e51c8597da8e754079087e6

Review-Url:  https://codereview.chromium.org/2571713002

lushnikov@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

 Issue 760355  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452aaa142ed748a78013ca246859598537230c13

commit 452aaa142ed748a78013ca246859598537230c13
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Tue Dec 12 00:34:07 2017

DevTools: autocomplete non-SVG properties for SVG elements

This patch changes StylesSidebarPane autocomplete for property names in
the following maner:
- for regular nodes, only regular CSS properties are autocompleted
- for SVG nodes, both CSS and SVG properties are autocompleted

BUG= 721998 
R=dgozman

Change-Id: Ie06307d62a1b9685f0bf998b5b2714c47e3d5ee8
Reviewed-on: https://chromium-review.googlesource.com/820647
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523269}
[modify] https://crrev.com/452aaa142ed748a78013ca246859598537230c13/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Status: Fixed (was: Assigned)
Labels: TE-Verified-M65 TE-Verified-65.0.3292.0
Verified this issue on Mac10.12.6/Ubuntu 14.04 with chrome #65.0.3292.0 and on Windows #65.0.3293.0

Observed fix is working as expected.Hence adding TE-Verified labels

Attaching the screen-cast for reference.


721998.mp4
1.0 MB View Download

Sign in to add a comment