Issue metadata
Sign in to add a comment
|
DevTools: can't set breakpoints in a snippet while on the NTP |
||||||||||||||||||||||
Issue description
This is a solid 100% repro for me. clean profile on ToT.
Create new snippet.
For example:
function foo() {
var x = 4;
return x;
}
Now save it.
Run it once.
Now try to put a breakpoint inside it.
It seems possible to set breakpoints before it's ever evaluated, but not afterwards.
,
May 13 2017
Hah. Can't repro on about:blank. ;) Also not on example.com, etc. I've been reproing on the NTP. That does seem to be the problem here. :)
,
May 13 2017
Yeah, I know the root of this - will fix.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8bc6f196aa3279a2480d224a1f678a6680ceeef commit f8bc6f196aa3279a2480d224a1f678a6680ceeef Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu May 18 03:46:43 2017 [DevTools] breakpoint manager should be ready for location from different model There is no gurantees for debugger model of location returned from uiLocationToRawLocation call. BreakpointManager should be ready. BUG= chromium:722715 , chromium:721993 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2889853002 Cr-Commit-Position: refs/heads/master@{#472648} [add] https://crrev.com/f8bc6f196aa3279a2480d224a1f678a6680ceeef/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt [add] https://crrev.com/f8bc6f196aa3279a2480d224a1f678a6680ceeef/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.html [modify] https://crrev.com/f8bc6f196aa3279a2480d224a1f678a6680ceeef/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
,
May 18 2017
,
May 18 2017
Issue 722715 has been merged into this issue.
,
May 19 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cf34f3a7413e2f7913ca2e7757cedcdb2079970 commit 0cf34f3a7413e2f7913ca2e7757cedcdb2079970 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri May 19 19:19:48 2017 [DevTools] breakpoint manager should be ready for location from different model There is no gurantees for debugger model of location returned from uiLocationToRawLocation call. BreakpointManager should be ready. BUG= chromium:722715 , chromium:721993 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2889853002 Cr-Original-Commit-Position: refs/heads/master@{#472648} Review-Url: https://codereview.chromium.org/2898473002 . Cr-Commit-Position: refs/branch-heads/3071@{#637} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [add] https://crrev.com/0cf34f3a7413e2f7913ca2e7757cedcdb2079970/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt [add] https://crrev.com/0cf34f3a7413e2f7913ca2e7757cedcdb2079970/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets.html [modify] https://crrev.com/0cf34f3a7413e2f7913ca2e7757cedcdb2079970/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
,
May 19 2017
,
Jun 5 2017
Issue 702442 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kozyatinskiy@chromium.org
, May 13 2017