New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 721986 link

Starred by 1 user
Status: Fixed
Owner:
paulir...@chromium.org
Closed: May 2017
Cc:
█ lushnikov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Improve JavaScript syntax highlighting [sources]

Project Member Reported by paulir...@chromium.org, May 13 2017 
It could use some improvements. Compared to our Dark mode, the Light mode has really weak highlighting.
see attachment.
lightmodedarkmode.png
181 KB View Download

Comment 1 by paulir...@chromium.org, May 13 2017 

Screenshots of before and after my CL.
Screen Shot 2017-05-12 at 7.26.16 PM.png
321 KB View Download
Screen Shot 2017-05-12 at 7.26.04 PM.png
518 KB View Download
Screen Shot 2017-05-12 at 7.25.50 PM.png
377 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/165ea5770f4a008b149dec4706989344d6a61803

commit 165ea5770f4a008b149dec4706989344d6a61803
Author: paulirish <paulirish@chromium.org>
Date: Sat May 13 05:15:47 2017

DevTools: Colorize more types in JS syntax highlighting

BUG= 721986 

Review-Url: https://codereview.chromium.org/2881753003
Cr-Commit-Position: refs/heads/master@{#471562}

[modify] https://crrev.com/165ea5770f4a008b149dec4706989344d6a61803/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css

Comment 3 by paulir...@chromium.org, May 13 2017

Status: Fixed (was: Assigned)

Comment 4 by paulir...@chromium.org, May 13 2017 

Some tweaks were made after those screenshots. 
The version that landed:
beforeafter1.png
226 KB View Download
beforeafter2.png
264 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92abf957cbc29e3d166b20a1f0b7d66b0e86a5dc

commit 92abf957cbc29e3d166b20a1f0b7d66b0e86a5dc
Author: paulirish <paulirish@chromium.org>
Date: Mon May 15 20:41:57 2017

DevTools: JS color theme bikeshedding

BUG= 721986 

Review-Url: https://codereview.chromium.org/2882263002
Cr-Commit-Position: refs/heads/master@{#471889}

[modify] https://crrev.com/92abf957cbc29e3d166b20a1f0b7d66b0e86a5dc/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
Project Member

Comment 6 by bugdroid1@chromium.org, May 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/067dbc41af8c1f0858c94ebaf4baee0346b8407f

commit 067dbc41af8c1f0858c94ebaf4baee0346b8407f
Author: paulirish <paulirish@chromium.org>
Date: Tue May 23 23:46:31 2017

DevTools: JS color theme bikeshedding v2

BUG= 721986 

Review-Url: https://codereview.chromium.org/2878353003
Cr-Commit-Position: refs/heads/master@{#474106}

[modify] https://crrev.com/067dbc41af8c1f0858c94ebaf4baee0346b8407f/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
►

Sign in to add a comment